From: Matthias Fuchs <matthias.fuchs@esd.eu>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 9/9] board/esd/common/auto_update.c: fix Uninitialized variable
Date: Thu, 6 Nov 2014 14:33:12 +0100 [thread overview]
Message-ID: <545B7898.2010105@esd.eu> (raw)
In-Reply-To: <1415278985-8482-10-git-send-email-wd@denx.de>
On 11/06/2014 02:03 PM, Wolfgang Denk wrote:
> cppcheck reports:
>
> [board/esd/common/auto_update.c:458]: (error) Uninitialized variable: cnt
>
> The variable is not really used anywhere, so remove it.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> ---
> board/esd/common/auto_update.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/board/esd/common/auto_update.c b/board/esd/common/auto_update.c
> index 85c3567..b168074 100644
> --- a/board/esd/common/auto_update.c
> +++ b/board/esd/common/auto_update.c
> @@ -377,7 +377,7 @@ int do_auto_update(void)
> {
> block_dev_desc_t *stor_dev = NULL;
> long sz;
> - int i, res, cnt, old_ctrlc;
> + int i, res, old_ctrlc;
> char buffer[32];
> char str[80];
> int n;
> @@ -455,7 +455,6 @@ int do_auto_update(void)
> clear_ctrlc ();
> break;
> }
> - cnt++;
> } while (res < 0);
> }
>
>
Thanks for fixing!
Acked-by: Matthias Fuchs <matthias.fuchs@esd.eu>
next prev parent reply other threads:[~2014-11-06 13:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 13:02 [U-Boot] [PATCH 0/9] cppcheck cleanup Wolfgang Denk
2014-11-06 13:02 ` [U-Boot] [PATCH 1/9] cppcheck cleanup: fix nullPointer errors Wolfgang Denk
2014-11-10 21:27 ` [U-Boot] [U-Boot,1/9] " Tom Rini
2014-11-06 13:02 ` [U-Boot] [PATCH 2/9] board/cogent/lcd.c: fix syntax error Wolfgang Denk
2014-11-10 21:28 ` [U-Boot] [U-Boot,2/9] " Tom Rini
2014-11-06 13:02 ` [U-Boot] [PATCH 3/9] drivers/usb/host/isp116x-hcd.c: " Wolfgang Denk
2014-11-06 13:23 ` Marek Vasut
2014-11-06 13:03 ` [U-Boot] [PATCH 4/9] drivers/net/uli526x.c: " Wolfgang Denk
2014-11-10 21:28 ` [U-Boot] [U-Boot,4/9] " Tom Rini
2014-11-06 13:03 ` [U-Boot] [PATCH 5/9] common/cmd_fitupd.c: restore corrupted file Wolfgang Denk
2014-11-10 21:28 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-06 13:03 ` [U-Boot] [PATCH 6/9] board/matrix_vision/mvblx/sys_eeprom.c: fix buffer overflow Wolfgang Denk
2014-11-06 13:50 ` Michael Jones
2014-11-10 21:28 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-06 13:03 ` [U-Boot] [PATCH 7/9] board/renesas/ecovec/ecovec.c: " Wolfgang Denk
2014-11-09 23:52 ` Nobuhiro Iwamatsu
2014-11-06 13:03 ` [U-Boot] [PATCH 8/9] ARM: MXS: fix Uninitialized variable error Wolfgang Denk
2014-11-10 21:28 ` [U-Boot] [U-Boot, " Tom Rini
2014-11-06 13:03 ` [U-Boot] [PATCH 9/9] board/esd/common/auto_update.c: fix Uninitialized variable Wolfgang Denk
2014-11-06 13:33 ` Matthias Fuchs [this message]
2014-11-10 21:28 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B7898.2010105@esd.eu \
--to=matthias.fuchs@esd.eu \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox