[U-Boot] [PATCH 0/9] cppcheck cleanup

[U-Boot] [PATCH 0/9] cppcheck cleanup

[Wolfgang Denk]

The following patches clean up a number of errors and warnings
detected by running the "cppcheck" [1] tool over the U-Boot source
tree.  This discovers a number of issues that escape GCC, for example
because they are inside #ifdef branches which are never compiled for
any of the tested configurations.

This is just an initial patch series; some other error reports have
been sent to the respective code maintainers, so more patches should
follow soon.

The command used for these tests was:

	$ cd u-boot
	$ cppcheck --force --quiet --inline-suppr .

[1] http://cppcheck.sourceforge.net/

Wolfgang Denk (9):
  cppcheck cleanup: fix nullPointer errors
  board/cogent/lcd.c: fix syntax error
  drivers/usb/host/isp116x-hcd.c: fix syntax error
  drivers/net/uli526x.c: fix syntax error
  common/cmd_fitupd.c: restore corrupted file
  board/matrix_vision/mvblx/sys_eeprom.c: fix buffer overflow
  board/renesas/ecovec/ecovec.c: fix buffer overflow
  ARM: MXS: fix Uninitialized variable error
  board/esd/common/auto_update.c: fix Uninitialized variable

 arch/arm/cpu/arm926ejs/mxs/mxs.c          |  2 ++
 arch/arm/cpu/arm926ejs/mxs/spl_boot.c     |  2 ++
 arch/arm/cpu/arm926ejs/mxs/timer.c        |  2 ++
 arch/arm/cpu/armv7/zynq/ddrc.c            |  1 +
 arch/blackfin/cpu/initcode.c              |  1 +
 arch/powerpc/cpu/mpc85xx/cpu_init_early.c |  5 ++++-
 arch/sh/lib/zimageboot.c                  |  1 +
 board/cogent/lcd.c                        |  2 +-
 board/esd/common/auto_update.c            |  3 +--
 board/esd/pci405/cmd_pci405.c             |  4 +++-
 board/keymile/common/common.c             |  1 +
 board/matrix_vision/mvblx/sys_eeprom.c    |  2 +-
 board/renesas/ecovec/ecovec.c             |  2 +-
 board/scb9328/flash.c                     |  2 ++
 common/cmd_fitupd.c                       | 14 +++++---------
 drivers/net/uli526x.c                     |  2 +-
 drivers/usb/host/isp116x-hcd.c            |  2 +-
 17 files changed, 30 insertions(+), 18 deletions(-)

-- 
1.8.3.1

[U-Boot] [PATCH 1/9] cppcheck cleanup: fix nullPointer errors

[Wolfgang Denk]

There are a number of places where U-Boot intentionally and legally
accesses physical address 0x0000, for example when installing
exception vectors on systems where these are located in low memory.

Add "cppcheck-suppress nullPointer" comments to silence cppcheck
where this is intentional and legal.

Signed-off-by: Wolfgang Denk <wd@denx.de>
---
 arch/arm/cpu/arm926ejs/mxs/mxs.c          | 2 ++
 arch/arm/cpu/arm926ejs/mxs/spl_boot.c     | 2 ++
 arch/arm/cpu/armv7/zynq/ddrc.c            | 1 +
 arch/blackfin/cpu/initcode.c              | 1 +
 arch/powerpc/cpu/mpc85xx/cpu_init_early.c | 5 ++++-
 arch/sh/lib/zimageboot.c                  | 1 +
 board/esd/pci405/cmd_pci405.c             | 4 +++-
 board/keymile/common/common.c             | 1 +
 board/scb9328/flash.c                     | 2 ++
 9 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/arch/arm/cpu/arm926ejs/mxs/mxs.c b/arch/arm/cpu/arm926ejs/mxs/mxs.c
index 365542f..ef130ae 100644
--- a/arch/arm/cpu/arm926ejs/mxs/mxs.c
+++ b/arch/arm/cpu/arm926ejs/mxs/mxs.c
@@ -83,7 +83,9 @@ void mx28_fixup_vt(uint32_t start_addr)
 	int i;
 
 	for (i = 0; i < 8; i++) {
+		/* cppcheck-suppress nullPointer */
 		vt[i] = ldr_pc;
+		/* cppcheck-suppress nullPointer */
 		vt[i + 8] = start_addr + (4 * i);
 	}
 }
diff --git a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
index d3e1369..d29b9aa 100644
--- a/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
+++ b/arch/arm/cpu/arm926ejs/mxs/spl_boot.c
@@ -118,6 +118,8 @@ static void mxs_spl_fixup_vectors(void)
 	 * fine.
 	 */
 	extern uint32_t _start;
+
+	/* cppcheck-suppress nullPointer */
 	memcpy(0x0, &_start, 0x60);
 }
 
diff --git a/arch/arm/cpu/armv7/zynq/ddrc.c b/arch/arm/cpu/armv7/zynq/ddrc.c
index 1ea086d..d74f8db 100644
--- a/arch/arm/cpu/armv7/zynq/ddrc.c
+++ b/arch/arm/cpu/armv7/zynq/ddrc.c
@@ -40,6 +40,7 @@ void zynq_ddrc_init(void)
 		 * first stage bootloader. To get ECC to work all memory has
 		 * been initialized by writing any value.
 		 */
+		/* cppcheck-suppress nullPointer */
 		memset((void *)0, 0, 1 * 1024 * 1024);
 	} else {
 		puts("ECC disabled ");
diff --git a/arch/blackfin/cpu/initcode.c b/arch/blackfin/cpu/initcode.c
index 2e640af..fde54ea 100644
--- a/arch/blackfin/cpu/initcode.c
+++ b/arch/blackfin/cpu/initcode.c
@@ -955,6 +955,7 @@ check_hibernation(ADI_BOOT_DATA *bs, u16 vr_ctl, bool put_into_srfs)
 		uint32_t *hibernate_magic = 0;
 
 		SSYNC();
+		/* cppcheck-suppress nullPointer */
 		if (hibernate_magic[0] == 0xDEADBEEF) {
 			serial_putc('c');
 			bfin_write_EVT15(hibernate_magic[1]);
diff --git a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
index 47b712d..072387a 100644
--- a/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
+++ b/arch/powerpc/cpu/mpc85xx/cpu_init_early.c
@@ -161,9 +161,12 @@ void cpu_init_early_f(void *fdt)
 	setup_ifc_sram = (void *)SRAM_BASE_ADDR;
 	dst = (u32 *) SRAM_BASE_ADDR;
 	src = (u32 *) setup_ifc;
-	for (i = 0; i < 1024; i++)
+	for (i = 0; i < 1024; i++) {
+		/* cppcheck-suppress nullPointer */
 		*dst++ = *src++;
+	}
 
+	/* cppcheck-suppress nullPointer */
 	setup_ifc_sram();
 
 	/* CLEANUP */
diff --git a/arch/sh/lib/zimageboot.c b/arch/sh/lib/zimageboot.c
index 86d3998..3fea5f5 100644
--- a/arch/sh/lib/zimageboot.c
+++ b/arch/sh/lib/zimageboot.c
@@ -45,6 +45,7 @@ int do_sh_zimageboot (cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	bootargs = getenv("bootargs");
 
 	/* Clear zero page */
+	/* cppcheck-suppress nullPointer */
 	memset(param, 0, 0x1000);
 
 	/* Set commandline */
diff --git a/board/esd/pci405/cmd_pci405.c b/board/esd/pci405/cmd_pci405.c
index 55c20d0..29c688a 100644
--- a/board/esd/pci405/cmd_pci405.c
+++ b/board/esd/pci405/cmd_pci405.c
@@ -23,7 +23,7 @@
  */
 int do_loadpci(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
-	unsigned int *ptr = 0;
+	unsigned int *ptr;
 	int count = 0;
 	int count2 = 0;
 	int i;
@@ -35,12 +35,14 @@ int do_loadpci(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 	 * Mark sync address
 	 */
 	ptr = 0;
+	/* cppcheck-suppress nullPointer */
 	*ptr = 0xffffffff;
 	puts("\nWaiting for image from pci host -");
 
 	/*
 	 * Wait for host to write the start address
 	 */
+	/* cppcheck-suppress nullPointer */
 	while (*ptr == 0xffffffff) {
 		count++;
 		if (!(count % 100)) {
diff --git a/board/keymile/common/common.c b/board/keymile/common/common.c
index 2ddb3da..b9aff1a 100644
--- a/board/keymile/common/common.c
+++ b/board/keymile/common/common.c
@@ -360,6 +360,7 @@ static int do_checktestboot(cmd_tbl_t *cmdtp, int flag, int argc,
 	testboot = (testpin != 0) && (s);
 	if (verbose) {
 		printf("testpin   = %d\n", testpin);
+		/* cppcheck-suppress nullPointer */
 		printf("test_bank = %s\n", s ? s : "not set");
 		printf("boot test app : %s\n", (testboot) ? "yes" : "no");
 	}
diff --git a/board/scb9328/flash.c b/board/scb9328/flash.c
index e3a582f..73bfa00 100644
--- a/board/scb9328/flash.c
+++ b/board/scb9328/flash.c
@@ -72,8 +72,10 @@ static FLASH_BUS_RET flash_status_reg (void)
 
 	FLASH_BUS *addr = (FLASH_BUS *) 0;
 
+	/* cppcheck-suppress nullPointer */
 	*addr = FLASH_CMD (CFI_INTEL_CMD_READ_STATUS_REGISTER);
 
+	/* cppcheck-suppress nullPointer */
 	return *addr;
 }
 
-- 
1.8.3.1

[U-Boot] [PATCH 2/9] board/cogent/lcd.c: fix syntax error

[Wolfgang Denk]

Fix error detected by cppcheck:

[board/cogent/lcd.c:237]: (error) Invalid number of character (()
when these macros are defined:
'CONFIG_SHOW_ACTIVITY;CONFIG_STATUS_LED'.

Signed-off-by: Wolfgang Denk <wd@denx.de>
---
 board/cogent/lcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/cogent/lcd.c b/board/cogent/lcd.c
index 8e90f98..05ffc4d 100644
--- a/board/cogent/lcd.c
+++ b/board/cogent/lcd.c
@@ -234,7 +234,7 @@ lcd_heartbeat(void)
 void board_show_activity (ulong timestamp)
 {
 #ifdef CONFIG_STATUS_LED
-	if ((timestamp % (CONFIG_SYS_HZ / 2) == 0)
+	if ((timestamp % (CONFIG_SYS_HZ / 2)) == 0)
 		lcd_heartbeat ();
 #endif
 }
-- 
1.8.3.1

[U-Boot] [PATCH 3/9] drivers/usb/host/isp116x-hcd.c: fix syntax error

[Wolfgang Denk]

Fix error detected by cppcheck:

[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
character (() when these macros are defined: ''.
[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
character (() when these macros are defined: 'ISP116X_HCD_OC_ENABLE'.
[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
character (() when these macros are defined:
'ISP116X_HCD_REMOTE_WAKEUP_ENABLE'.
[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
character (() when these macros are defined: 'ISP116X_HCD_SEL15kRES'.
[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
character (() when these macros are defined:
'ISP116X_HCD_USE_EXTRA_DELAY'.
[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
character (() when these macros are defined: 'ISP116X_HCD_USE_UDELAY'.
[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
character (() when these macros are defined: 'TRACE'.
[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
character (() when these macros are defined: 'TRACE;VERBOSE'.
[drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
character (() when these macros are defined: 'VERBOSE'.

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>
Cc: Marek Vasut <marex@denx.de>
---
 drivers/usb/host/isp116x-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c
index 46e4cee..35d4e9f 100644
--- a/drivers/usb/host/isp116x-hcd.c
+++ b/drivers/usb/host/isp116x-hcd.c
@@ -1279,7 +1279,7 @@ int isp116x_check_id(struct isp116x *isp116x)
 	return 0;
 }
 
-int usb_lowlevel_init(int index, enum usb_init_type init, void **controller))
+int usb_lowlevel_init(int index, enum usb_init_type init, void **controller)
 {
 	struct isp116x *isp116x = &isp116x_dev;
 
-- 
1.8.3.1

[U-Boot] [PATCH 4/9] drivers/net/uli526x.c: fix syntax error

[Wolfgang Denk]

Fix error detected by cppcheck:

[drivers/net/uli526x.c:551]: (error) printf format string requires 3
parameters but only 2 are given.

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Roy Zang <tie-fei.zang@freescale.com>
---
 drivers/net/uli526x.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/uli526x.c b/drivers/net/uli526x.c
index 538f11e..9526faa 100644
--- a/drivers/net/uli526x.c
+++ b/drivers/net/uli526x.c
@@ -548,7 +548,7 @@ static int uli526x_rx_packet(struct eth_device *dev)
 
 	rdes0 = le32_to_cpu(rxptr->rdes0);
 #ifdef RX_DEBUG
-	printf("%s(): rxptr->rdes0=%x:%x\n", __FUNCTION__, rxptr->rdes0);
+	printf("%s(): rxptr->rdes0=%x\n", __FUNCTION__, rxptr->rdes0);
 #endif
 	if (!(rdes0 & 0x80000000)) {	/* packet owner check */
 		if ((rdes0 & 0x300) != 0x300) {
-- 
1.8.3.1

[U-Boot] [PATCH 5/9] common/cmd_fitupd.c: restore corrupted file

[Wolfgang Denk]

This file got corrupted by the automatic editin of commit 1a45966 "Add
GPL-2.0+ SPDX-License-Identifier to source files"; restore the
opiginal content and manually insert the SPDX ID.

The bug was detected by running cppcheck, which reported:
[common/cmd_fitupd.c:8]: (error) Invalid number of character ({) when
these macros are defined: 'CONFIG_UPDATE_TFTP'.

Signed-off-by: Wolfgang Denk <wd@denx.de>
---
 common/cmd_fitupd.c | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/common/cmd_fitupd.c b/common/cmd_fitupd.c
index e811473..b045974 100644
--- a/common/cmd_fitupd.c
+++ b/common/cmd_fitupd.c
@@ -1,12 +1,8 @@
-de <net.h>
-
-#if !defined(CONFIG_UPDATE_TFTP)
-#error "CONFIG_UPDATE_TFTP required"
-#endif
-
-static int do_fitupd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
-{
-	ulong addr = 0Un the root directory of the source tree for details.
+/*
+ * (C) Copyright 2011
+ * Andreas Pretzsch, carpe noctem engineering, apr at cn-eng.de
+ *
+ * SPDX-License-Identifier:	GPL-2.0+
  */
 
 #include <common.h>
-- 
1.8.3.1

[U-Boot] [PATCH 6/9] board/matrix_vision/mvblx/sys_eeprom.c: fix buffer overflow

[Wolfgang Denk]

Fix error detected by cppcheck:

[board/matrix_vision/mvblx/sys_eeprom.c:353]: (error) Buffer is
accessed out of bounds.

Signed-off-by: Wolfgang Denk <wd@denx.de>
cc: Michael Jones <michael.jones@matrix-vision.de>
---
 board/matrix_vision/mvblx/sys_eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/matrix_vision/mvblx/sys_eeprom.c b/board/matrix_vision/mvblx/sys_eeprom.c
index 1a2ac8d..db42987 100644
--- a/board/matrix_vision/mvblx/sys_eeprom.c
+++ b/board/matrix_vision/mvblx/sys_eeprom.c
@@ -348,7 +348,7 @@ int mac_read_from_eeprom(void)
 
 	if (memcmp(&e.mac, "\0\0\0\0\0\0", 6) &&
 		memcmp(&e.mac, "\xFF\xFF\xFF\xFF\xFF\xFF", 6)) {
-		char ethaddr[9];
+		char ethaddr[18];
 
 		sprintf(ethaddr, "%02X:%02X:%02X:%02X:%02X:%02X",
 			e.mac[0],
-- 
1.8.3.1

[U-Boot] [PATCH 7/9] board/renesas/ecovec/ecovec.c: fix buffer overflow

[Wolfgang Denk]

Fix error detected by cppcheck:

[board/renesas/ecovec/ecovec.c:66]: (error) Buffer is accessed out of
bounds.

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
---
 board/renesas/ecovec/ecovec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/renesas/ecovec/ecovec.c b/board/renesas/ecovec/ecovec.c
index 2804d91..d862d99 100644
--- a/board/renesas/ecovec/ecovec.c
+++ b/board/renesas/ecovec/ecovec.c
@@ -41,7 +41,7 @@ static void debug_led(u8 led)
 int board_late_init(void)
 {
 	u8 mac[6];
-	char env_mac[17];
+	char env_mac[18];
 
 	udelay(1000);
 
-- 
1.8.3.1

[U-Boot] [PATCH 8/9] ARM: MXS: fix Uninitialized variable error

[Wolfgang Denk]

cppcheck reports:

[arch/arm/cpu/arm926ejs/mxs/timer.c:96]: (error) Uninitialized
variable: now

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Marek Vasut <marex@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
---
 arch/arm/cpu/arm926ejs/mxs/timer.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm/cpu/arm926ejs/mxs/timer.c b/arch/arm/cpu/arm926ejs/mxs/timer.c
index 99d3fb8..f2e7225 100644
--- a/arch/arm/cpu/arm926ejs/mxs/timer.c
+++ b/arch/arm/cpu/arm926ejs/mxs/timer.c
@@ -91,6 +91,8 @@ unsigned long long get_ticks(void)
 		TIMROT_RUNNING_COUNTn_RUNNING_COUNT_OFFSET;
 #elif defined(CONFIG_MX28)
 	now = readl(&timrot_regs->hw_timrot_running_count0);
+#else
+#error "Don't know how to read timrot_regs"
 #endif
 
 	if (lastdec >= now) {
-- 
1.8.3.1

[U-Boot] [PATCH 9/9] board/esd/common/auto_update.c: fix Uninitialized variable

[Wolfgang Denk]

cppcheck reports:

[board/esd/common/auto_update.c:458]: (error) Uninitialized variable: cnt

The variable is not really used anywhere, so remove it.

Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
---
 board/esd/common/auto_update.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/board/esd/common/auto_update.c b/board/esd/common/auto_update.c
index 85c3567..b168074 100644
--- a/board/esd/common/auto_update.c
+++ b/board/esd/common/auto_update.c
@@ -377,7 +377,7 @@ int do_auto_update(void)
 {
 	block_dev_desc_t *stor_dev = NULL;
 	long sz;
-	int i, res, cnt, old_ctrlc;
+	int i, res, old_ctrlc;
 	char buffer[32];
 	char str[80];
 	int n;
@@ -455,7 +455,6 @@ int do_auto_update(void)
 				clear_ctrlc ();
 				break;
 			}
-			cnt++;
 		} while (res < 0);
 	}
 
-- 
1.8.3.1

[U-Boot] [PATCH 3/9] drivers/usb/host/isp116x-hcd.c: fix syntax error

[Marek Vasut]

On Thursday, November 06, 2014 at 02:02:59 PM, Wolfgang Denk wrote:
> Fix error detected by cppcheck:
> 
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: ''.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'ISP116X_HCD_OC_ENABLE'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined:
> 'ISP116X_HCD_REMOTE_WAKEUP_ENABLE'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'ISP116X_HCD_SEL15kRES'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined:
> 'ISP116X_HCD_USE_EXTRA_DELAY'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'ISP116X_HCD_USE_UDELAY'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'TRACE'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'TRACE;VERBOSE'.
> [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of
> character (() when these macros are defined: 'VERBOSE'.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Stephen Warren <swarren@wwwdotorg.org>
> Cc: Marek Vasut <marex@denx.de>

A brief grep:
marex at bfu:u-boot$ git grep USB_ISP116X_HCD
drivers/usb/host/Makefile:obj-$(CONFIG_USB_ISP116X_HCD) += isp116x-hcd.o
include/usb.h:  defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) 
|| \
marex at bfu:u-boot$

gives me a better idea on how to resolve this bug ... scrap this code 
altogether. Looks like the code was unused forever. Can you prepare a
patch for that please ?

Best regards,
Marek Vasut

[U-Boot] [PATCH 9/9] board/esd/common/auto_update.c: fix Uninitialized variable

[Matthias Fuchs]

On 11/06/2014 02:03 PM, Wolfgang Denk wrote:
> cppcheck reports:
> 
> [board/esd/common/auto_update.c:458]: (error) Uninitialized variable: cnt
> 
> The variable is not really used anywhere, so remove it.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> ---
>  board/esd/common/auto_update.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/board/esd/common/auto_update.c b/board/esd/common/auto_update.c
> index 85c3567..b168074 100644
> --- a/board/esd/common/auto_update.c
> +++ b/board/esd/common/auto_update.c
> @@ -377,7 +377,7 @@ int do_auto_update(void)
>  {
>  	block_dev_desc_t *stor_dev = NULL;
>  	long sz;
> -	int i, res, cnt, old_ctrlc;
> +	int i, res, old_ctrlc;
>  	char buffer[32];
>  	char str[80];
>  	int n;
> @@ -455,7 +455,6 @@ int do_auto_update(void)
>  				clear_ctrlc ();
>  				break;
>  			}
> -			cnt++;
>  		} while (res < 0);
>  	}
>  
> 
Thanks for fixing!

Acked-by: Matthias Fuchs <matthias.fuchs@esd.eu>

[U-Boot] [PATCH 6/9] board/matrix_vision/mvblx/sys_eeprom.c: fix buffer overflow

[Michael Jones]

On 11/06/2014 02:03 PM, Wolfgang Denk wrote:
> Fix error detected by cppcheck:
>
> [board/matrix_vision/mvblx/sys_eeprom.c:353]: (error) Buffer is
> accessed out of bounds.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> cc: Michael Jones <michael.jones@matrix-vision.de>
> ---
>   board/matrix_vision/mvblx/sys_eeprom.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/matrix_vision/mvblx/sys_eeprom.c b/board/matrix_vision/mvblx/sys_eeprom.c
> index 1a2ac8d..db42987 100644
> --- a/board/matrix_vision/mvblx/sys_eeprom.c
> +++ b/board/matrix_vision/mvblx/sys_eeprom.c
> @@ -348,7 +348,7 @@ int mac_read_from_eeprom(void)
>
>   	if (memcmp(&e.mac, "\0\0\0\0\0\0", 6) &&
>   		memcmp(&e.mac, "\xFF\xFF\xFF\xFF\xFF\xFF", 6)) {
> -		char ethaddr[9];
> +		char ethaddr[18];
>
>   		sprintf(ethaddr, "%02X:%02X:%02X:%02X:%02X:%02X",
>   			e.mac[0],
>

Thanks for the fix.

Acked-by: Michael Jones <michael.jones@matrix-vision.de>
-----------------------------------------------------------------
VISION 2014 in Stuttgart | 04.11.2014 - 06.11.2014
Meet us at the VISION show Hall 1 - Stand E12
-----------------------------------------------------------------

MATRIX VISION GmbH, Talstrasse 16, DE-71570 Oppenweiler
Registergericht: Amtsgericht Stuttgart, HRB 271090
Geschaeftsfuehrer: Uwe Furtner, Erhard Meier

[U-Boot] [PATCH 7/9] board/renesas/ecovec/ecovec.c: fix buffer overflow

[Nobuhiro Iwamatsu]

2014-11-06 22:03 GMT+09:00 Wolfgang Denk <wd@denx.de>:
> Fix error detected by cppcheck:
>
> [board/renesas/ecovec/ecovec.c:66]: (error) Buffer is accessed out of
> bounds.
>
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Nobuhiro Iwamatsu <iwamatsu.nobuhiro@renesas.com>
> ---
>  board/renesas/ecovec/ecovec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/board/renesas/ecovec/ecovec.c b/board/renesas/ecovec/ecovec.c
> index 2804d91..d862d99 100644
> --- a/board/renesas/ecovec/ecovec.c
> +++ b/board/renesas/ecovec/ecovec.c
> @@ -41,7 +41,7 @@ static void debug_led(u8 led)
>  int board_late_init(void)
>  {
>         u8 mac[6];
> -       char env_mac[17];
> +       char env_mac[18];
>
>         udelay(1000);
>
> --
> 1.8.3.1
>

Applied, thanks.

Best regards,
  Nobuhiro



-- 
Nobuhiro Iwamatsu
   iwamatsu at {nigauri.org / debian.org}
   GPG ID: 40AD1FA6

[U-Boot] [U-Boot,1/9] cppcheck cleanup: fix nullPointer errors

[Tom Rini]

On Thu, Nov 06, 2014 at 02:02:57PM +0100, Wolfgang Denk wrote:

> There are a number of places where U-Boot intentionally and legally
> accesses physical address 0x0000, for example when installing
> exception vectors on systems where these are located in low memory.
> 
> Add "cppcheck-suppress nullPointer" comments to silence cppcheck
> where this is intentional and legal.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141110/a00db655/attachment.pgp>

[U-Boot] [U-Boot,2/9] board/cogent/lcd.c: fix syntax error

[Tom Rini]

On Thu, Nov 06, 2014 at 02:02:58PM +0100, Wolfgang Denk wrote:

> Fix error detected by cppcheck:
> 
> [board/cogent/lcd.c:237]: (error) Invalid number of character (()
> when these macros are defined:
> 'CONFIG_SHOW_ACTIVITY;CONFIG_STATUS_LED'.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141110/012fc02b/attachment.pgp>

[U-Boot] [U-Boot,4/9] drivers/net/uli526x.c: fix syntax error

[Tom Rini]

On Thu, Nov 06, 2014 at 02:03:00PM +0100, Wolfgang Denk wrote:

> Fix error detected by cppcheck:
> 
> [drivers/net/uli526x.c:551]: (error) printf format string requires 3
> parameters but only 2 are given.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Roy Zang <tie-fei.zang@freescale.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141110/79920734/attachment.pgp>

[U-Boot] [U-Boot, 5/9] common/cmd_fitupd.c: restore corrupted file

[Tom Rini]

On Thu, Nov 06, 2014 at 02:03:01PM +0100, Wolfgang Denk wrote:

> This file got corrupted by the automatic editin of commit 1a45966 "Add
> GPL-2.0+ SPDX-License-Identifier to source files"; restore the
> opiginal content and manually insert the SPDX ID.
> 
> The bug was detected by running cppcheck, which reported:
> [common/cmd_fitupd.c:8]: (error) Invalid number of character ({) when
> these macros are defined: 'CONFIG_UPDATE_TFTP'.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141110/64615e4c/attachment.pgp>

[U-Boot] [U-Boot, 6/9] board/matrix_vision/mvblx/sys_eeprom.c: fix buffer overflow

[Tom Rini]

On Thu, Nov 06, 2014 at 02:03:02PM +0100, Wolfgang Denk wrote:

> Fix error detected by cppcheck:
> 
> [board/matrix_vision/mvblx/sys_eeprom.c:353]: (error) Buffer is
> accessed out of bounds.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> cc: Michael Jones <michael.jones@matrix-vision.de>
> Acked-by: Michael Jones <michael.jones@matrix-vision.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141110/2e65fb20/attachment.pgp>

[U-Boot] [U-Boot, 8/9] ARM: MXS: fix Uninitialized variable error

[Tom Rini]

On Thu, Nov 06, 2014 at 02:03:04PM +0100, Wolfgang Denk wrote:

> cppcheck reports:
> 
> [arch/arm/cpu/arm926ejs/mxs/timer.c:96]: (error) Uninitialized
> variable: now
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141110/af515f8d/attachment.pgp>

[U-Boot] [U-Boot, 9/9] board/esd/common/auto_update.c: fix Uninitialized variable

[Tom Rini]

On Thu, Nov 06, 2014 at 02:03:05PM +0100, Wolfgang Denk wrote:

> cppcheck reports:
> 
> [board/esd/common/auto_update.c:458]: (error) Uninitialized variable: cnt
> 
> The variable is not really used anywhere, so remove it.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>
> Cc: Matthias Fuchs <matthias.fuchs@esd-electronics.com>
> Acked-by: Matthias Fuchs <matthias.fuchs@esd.eu>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141110/310024f0/attachment.pgp>