public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [drivers/mtd/ubi/eba.c:1275]: (error) Uninitialized variable: aeb
Date: Thu, 06 Nov 2014 15:12:41 +0100	[thread overview]
Message-ID: <545B81D9.6070602@denx.de> (raw)
In-Reply-To: <20141106123418.EAF8C38334C@gemini.denx.de>

Hello Wolfgang,

Am 06.11.2014 13:34, schrieb Wolfgang Denk:
> Hello,
>
> cppcheck reports:
>
> [drivers/mtd/ubi/eba.c:1275]: (error) Uninitialized variable: aeb
>
> can you please have a look?  Thanks!

I see in drivers/mtd/ubi/eba.c:

1267:                ubi_rb_for_each_entry(rb, aeb, &av->root, u.rb)
1268:                        scan_eba[i][aeb->lnum] = aeb->pnum;
1269:
1270:                av = ubi_find_av(ai_fastmap, idx2vol_id(ubi, i));
1271:                if (!av)
1272:                       continue;
1273:
1274:                ubi_rb_for_each_entry(rb, aeb, &av->root, u.rb)
1275:                        fm_eba[i][aeb->lnum] = aeb->pnum;

Why does cppcheck only report line 1275 not also line 1268 and also
1351? I could not currently see, why this pops up for line 1274 ...

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2014-11-06 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 12:34 [U-Boot] [drivers/mtd/ubi/eba.c:1275]: (error) Uninitialized variable: aeb Wolfgang Denk
2014-11-06 14:12 ` Heiko Schocher [this message]
2014-11-06 15:10   ` Wolfgang Denk
2014-11-07  4:52     ` Heiko Schocher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=545B81D9.6070602@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox