From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Thu, 6 Nov 2014 15:31:46 -0800 Subject: [U-Boot] MPC85xx: Uninitialized variables and other problems In-Reply-To: <20141106115451.5F63F382347@gemini.denx.de> References: <20141106115451.5F63F382347@gemini.denx.de> Message-ID: <545C04E2.1060400@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 11/06/2014 03:54 AM, Wolfgang Denk wrote: > Hello, > > cppcheck reports: > > [arch/powerpc/cpu/mpc85xx/cmd_errata.c:62]: (error) Uninitialized variable: x108 > > [board/freescale/common/cds_pci_ft.c:36]: (error) Possible null pointer dereference: map > [board/freescale/common/cds_pci_ft.c:52]: (error) Uninitialized variable: len > > [board/freescale/t4qds/eth.c:289]: (error) Undefined behavior: Variable 'buf' is used as parameter and destination in s[n]printf(). > [board/freescale/t4qds/eth.c:298]: (error) Undefined behavior: Variable 'buf' is used as parameter and destination in s[n]printf(). > [board/freescale/t4qds/eth.c:307]: (error) Undefined behavior: Variable 'buf' is used as parameter and destination in s[n]printf(). > [board/freescale/t4qds/eth.c:316]: (error) Undefined behavior: Variable 'buf' is used as parameter and destination in s[n]printf(). > > [drivers/ddr/fsl/ctrl_regs.c:1659]: (error) Uninitialized variable: wr > [drivers/ddr/fsl/ctrl_regs.c:2257]: (error) Uninitialized variable: ea > [drivers/ddr/fsl/ctrl_regs.c:2256]: (error) Uninitialized variable: sa > [drivers/ddr/fsl/ctrl_regs.c:1985]: (error) Uninitialized variable: zqcs_init > > [drivers/mmc/fsl_esdhc_spl.c:95]: (error) Dereferencing 'tmp_buf' after it is deallocated / released > [drivers/mmc/fsl_esdhc_spl.c:98]: (error) Memory pointed to by 'tmp_buf' is freed twice. > [drivers/mmc/fsl_esdhc_spl.c:101]: (error) Dereferencing 'tmp_buf' after it is deallocated / released > [drivers/mmc/fsl_esdhc_spl.c:104]: (error) Memory pointed to by 'tmp_buf' is freed twice. > > > > Can you please have a look and fix these? > > Thanks in advance. Yes I will look into them when I have a chance. York