From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 07 Nov 2014 16:26:13 +0100 Subject: [U-Boot] [PATCH 1/4 v4] spi: Add Cadence QSPI DM driver used by SoCFPGA In-Reply-To: <201411071604.44091.marex@denx.de> References: <1415360272-13249-1-git-send-email-sr@denx.de> <1415360272-13249-2-git-send-email-sr@denx.de> <201411071604.44091.marex@denx.de> Message-ID: <545CE495.10801@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Dinh, Hi Vince! a quick question for you: On 07.11.2014 16:04, Marek Vasut wrote: >> diff --git a/drivers/spi/cadence_qspi_apb.c >> b/drivers/spi/cadence_qspi_apb.c new file mode 100644 >> index 0000000..00a115f >> --- /dev/null >> +++ b/drivers/spi/cadence_qspi_apb.c >> @@ -0,0 +1,898 @@ >> +/* >> + * Copyright (C) 2012 Altera Corporation >> + * All rights reserved. >> + * >> + * Redistribution and use in source and binary forms, with or without >> + * modification, are permitted provided that the following conditions are >> met: + * - Redistributions of source code must retain the above copyright >> + * notice, this list of conditions and the following disclaimer. + * >> - Redistributions in binary form must reproduce the above copyright + * >> notice, this list of conditions and the following disclaimer in the + * >> documentation and/or other materials provided with the distribution. + * >> - Neither the name of the Altera Corporation nor the >> + * names of its contributors may be used to endorse or promote products >> + * derived from this software without specific prior written >> permission. + * >> + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS >> IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED >> TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A >> PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL ALTERA >> CORPORATION BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, >> EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, >> PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR >> PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND + * ON ANY THEORY OF >> LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING >> NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF + * THIS >> SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ > > This license is kinda iffy. What is this all about please ? Yes, I was wondering about this as well. And in the Linux kernel (Rocketboards) this file is dual licensed. Here an extract: <------- /* * Driver for Cadence QSPI Controller * * Copyright (C) 2012 Altera Corporation * * This software is available to you under a choice of one of two * licenses. You may choose to be licensed under the terms of the GNU * General Public License (GPL) Version 2, available from the file * COPYING in the main directory of this source tree, or the * OpenIB.org BSD license below: * * Redistribution and use in source and binary forms, with or * without modification, are permitted provided that the following * conditions are met: * * - Redistributions of source code must retain the above * copyright notice, this list of conditions and the following * disclaimer. * * - Redistributions in binary form must reproduce the above * copyright notice, this list of conditions and the following * disclaimer in the documentation and/or other materials * provided with the distribution. * * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE * SOFTWARE. * */ <------ Could we not just use a "plain" GPL (v2) license here as well. Especially since the other files in this driver are just normal GPL files. Comments welcome. Thanks, Stefan