public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dinh Nguyen <dinguyen@opensource.altera.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/4 v4] arm: socfpga: dts: Add Cadence QSPI DT node to socfpga.dtsi
Date: Mon, 10 Nov 2014 09:48:00 -0600	[thread overview]
Message-ID: <5460DE30.3060504@opensource.altera.com> (raw)
In-Reply-To: <20141110104758.GA27292@amd>

+CC: Graham Moore

On 11/10/2014 04:47 AM, Pavel Machek wrote:
> On Fri 2014-11-07 18:26:05, Stefan Roese wrote:
>> Hi Simon,
>>
>> On 07.11.2014 18:21, Simon Glass wrote:
>>>> +               qspi: spi at ff705000 {
>>>> +                       compatible = "cadence,qspi";
>>>> +                       #address-cells = <1>;
>>>> +                       #size-cells = <0>;
>>>> +                       reg = <0xff705000 0x1000>,
>>>> +                               <0xffa00000 0x1000>;
>>>> +                       interrupts = <0 151 4>;
>>>> +                       clocks = <&qspi_clk>;
>>>> +                       ext-decoder = <0>;  /* external decoder */
>>>> +                       num-chipselect = <4>;
>>>> +                       fifo-depth = <128>;
>>>> +                       bus-num = <2>;
>>>> +                       status = "disabled";
>>>> +               };
>>>> +
>>>
>>> Is this the same binding as Linux? Can you please bring in the binding
>>> document too? Some of these feel like they should have a
>>> "manufacture," prefix.
>>
>> Yes, its from Linux. But not from kernel.org but from the Altera
>> Rocketboards.org version (v3.16). So the bindings might change if this
>> driver would be pushed to mainline Linux.
> 
> I guess it would be good to submit the binding to Linux for review, so
> that we don't end up with two incompatible bindings...
> 

Graham has already submitted an RFC, but have not gotten any feedback yet.

http://marc.info/?l=linux-kernel&m=141417787314186&w=2

  reply	other threads:[~2014-11-10 15:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-07 11:37 [U-Boot] [PATCH 0/4 v4] arm: socfpga: Add Cadence QSPI support Stefan Roese
2014-11-07 11:37 ` [U-Boot] [PATCH 1/4 v4] spi: Add Cadence QSPI DM driver used by SoCFPGA Stefan Roese
2014-11-07 15:04   ` Marek Vasut
2014-11-07 15:26     ` Stefan Roese
2014-11-07 19:56       ` Dinh Nguyen
2014-11-08 12:18         ` Stefan Roese
2014-12-06 12:56           ` Marek Vasut
2014-12-08  8:14             ` Stefan Roese
2016-01-14  2:17               ` Marek Vasut
2014-11-07 17:59   ` Simon Glass
2014-11-07 11:37 ` [U-Boot] [PATCH 2/4 v4] arm: socfpga: dts: Add Cadence QSPI DT node to socfpga.dtsi Stefan Roese
2014-11-07 17:21   ` Simon Glass
2014-11-07 17:26     ` Stefan Roese
2014-11-10 10:47       ` Pavel Machek
2014-11-10 15:48         ` Dinh Nguyen [this message]
2014-11-07 11:37 ` [U-Boot] [PATCH 3/4 v4] arm: socfpga: dts: Add spi0 alias for Cadence QSPI driver Stefan Roese
2014-11-07 15:06   ` Marek Vasut
2014-11-07 18:02   ` Simon Glass
2014-11-07 11:37 ` [U-Boot] [PATCH 4/4 v4] arm: socfpga: Add Cadence QSPI support to config header Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5460DE30.3060504@opensource.altera.com \
    --to=dinguyen@opensource.altera.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox