[U-Boot] [PATCH] ot1200: fix card detect for usdhc4

[U-Boot] [PATCH] ot1200: fix card detect for usdhc4

[Christian Gmeiner]

Today I got the final board and found out that a different
connector is used as the one on my development board. The
new connector has swaped pins for cd and wp.

This change is tested on a production ready baord.

Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
---
 board/bachmann/ot1200/ot1200.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
index 2ed8cf7..007c1ef 100644
--- a/board/bachmann/ot1200/ot1200.c
+++ b/board/bachmann/ot1200/ot1200.c
@@ -159,8 +159,8 @@ int board_mmc_getcd(struct mmc *mmc)
 		gpio_direction_input(IMX_GPIO_NR(4, 5));
 		ret = gpio_get_value(IMX_GPIO_NR(4, 5));
 	} else {
-		gpio_direction_input(IMX_GPIO_NR(1, 4));
-		ret = !gpio_get_value(IMX_GPIO_NR(1, 4));
+		gpio_direction_input(IMX_GPIO_NR(1, 5));
+		ret = !gpio_get_value(IMX_GPIO_NR(1, 5));
 	}
 
 	return ret;
-- 
1.9.3

[U-Boot] [PATCH] ot1200: fix card detect for usdhc4

[Stefano Babic]

Hi Christian,

On 11/11/2014 12:57, Christian Gmeiner wrote:
> Today I got the final board and found out that a different
> connector is used as the one on my development board. The
> new connector has swaped pins for cd and wp.

It is always so..final board is different from development board ;-)

> 
> This change is tested on a production ready baord.

baord --> board

Maybe your disappointment in the commit message can be removed, and let
that the production board has swaped pins.

> 
> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
>  board/bachmann/ot1200/ot1200.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
> index 2ed8cf7..007c1ef 100644
> --- a/board/bachmann/ot1200/ot1200.c
> +++ b/board/bachmann/ot1200/ot1200.c
> @@ -159,8 +159,8 @@ int board_mmc_getcd(struct mmc *mmc)
>  		gpio_direction_input(IMX_GPIO_NR(4, 5));
>  		ret = gpio_get_value(IMX_GPIO_NR(4, 5));
>  	} else {
> -		gpio_direction_input(IMX_GPIO_NR(1, 4));
> -		ret = !gpio_get_value(IMX_GPIO_NR(1, 4));
> +		gpio_direction_input(IMX_GPIO_NR(1, 5));
> +		ret = !gpio_get_value(IMX_GPIO_NR(1, 5));
>  	}
>  
>  	return ret;
> 

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH] ot1200: fix card detect for usdhc4

[Stefano Babic]

On 11/11/2014 12:57, Christian Gmeiner wrote:
> Today I got the final board and found out that a different
> connector is used as the one on my development board. The
> new connector has swaped pins for cd and wp.
> 
> This change is tested on a production ready baord.
> 

I fixed it myself.

> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
> ---
>  board/bachmann/ot1200/ot1200.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
> index 2ed8cf7..007c1ef 100644
> --- a/board/bachmann/ot1200/ot1200.c
> +++ b/board/bachmann/ot1200/ot1200.c
> @@ -159,8 +159,8 @@ int board_mmc_getcd(struct mmc *mmc)
>  		gpio_direction_input(IMX_GPIO_NR(4, 5));
>  		ret = gpio_get_value(IMX_GPIO_NR(4, 5));
>  	} else {
> -		gpio_direction_input(IMX_GPIO_NR(1, 4));
> -		ret = !gpio_get_value(IMX_GPIO_NR(1, 4));
> +		gpio_direction_input(IMX_GPIO_NR(1, 5));
> +		ret = !gpio_get_value(IMX_GPIO_NR(1, 5));
>  	}
>  
>  	return ret;
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH] ot1200: fix card detect for usdhc4

[Christian Gmeiner]

Hi Stefano


2014-11-13 16:34 GMT+01:00 Stefano Babic <sbabic@denx.de>:
> On 11/11/2014 12:57, Christian Gmeiner wrote:
>> Today I got the final board and found out that a different
>> connector is used as the one on my development board. The
>> new connector has swaped pins for cd and wp.
>>
>> This change is tested on a production ready baord.
>>
>
> I fixed it myself.
>

Thanks a lot!

>> Signed-off-by: Christian Gmeiner <christian.gmeiner@gmail.com>
>> ---
>>  board/bachmann/ot1200/ot1200.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/board/bachmann/ot1200/ot1200.c b/board/bachmann/ot1200/ot1200.c
>> index 2ed8cf7..007c1ef 100644
>> --- a/board/bachmann/ot1200/ot1200.c
>> +++ b/board/bachmann/ot1200/ot1200.c
>> @@ -159,8 +159,8 @@ int board_mmc_getcd(struct mmc *mmc)
>>               gpio_direction_input(IMX_GPIO_NR(4, 5));
>>               ret = gpio_get_value(IMX_GPIO_NR(4, 5));
>>       } else {
>> -             gpio_direction_input(IMX_GPIO_NR(1, 4));
>> -             ret = !gpio_get_value(IMX_GPIO_NR(1, 4));
>> +             gpio_direction_input(IMX_GPIO_NR(1, 5));
>> +             ret = !gpio_get_value(IMX_GPIO_NR(1, 5));
>>       }
>>
>>       return ret;
>>
>
> Applied to u-boot-imx, thanks !
>

greets
--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner