[U-Boot] [PATCH] spl: Change debug to printf for "Unsupported boot-device"

[U-Boot] [PATCH] spl: Change debug to printf for "Unsupported boot-device"

[Stefan Roese]

We had the problem on an AM33xx platform, that SPL detected an
unsupported boot-device. But since this message is a debug message
it took a bit of time to really know, where the hangup in SPL
resulted from. So let's change this debug message to a printf
and also print the detected boot-device that is not supported.
This makes debugging of such cases much easier.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Tom Rini <trini@ti.com>
---
 common/spl/spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/spl/spl.c b/common/spl/spl.c
index d85bab3..1e5ee95 100644
--- a/common/spl/spl.c
+++ b/common/spl/spl.c
@@ -216,7 +216,7 @@ void board_init_r(gd_t *dummy1, ulong dummy2)
 		break;
 #endif
 	default:
-		debug("SPL: Un-supported Boot Device\n");
+		printf("SPL: Unsupported Boot Device %d\n", boot_device);
 		hang();
 	}
 
-- 
2.1.3

[U-Boot] [PATCH] spl: Change debug to printf for "Unsupported boot-device"

[Tom Rini]

On Tue, Nov 11, 2014 at 04:59:13PM +0100, Stefan Roese wrote:

> We had the problem on an AM33xx platform, that SPL detected an
> unsupported boot-device. But since this message is a debug message
> it took a bit of time to really know, where the hangup in SPL
> resulted from. So let's change this debug message to a printf
> and also print the detected boot-device that is not supported.
> This makes debugging of such cases much easier.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Tom Rini <trini@ti.com>

Did you build all of ARM with this?  I _think_ this may break the
davinci/related boards that use SPL since they don't have printf due to
size.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141111/7dcba9f0/attachment.pgp>

[U-Boot] [PATCH] spl: Change debug to printf for "Unsupported boot-device"

[Stefan Roese]

On 11.11.2014 17:16, Tom Rini wrote:
> On Tue, Nov 11, 2014 at 04:59:13PM +0100, Stefan Roese wrote:
>
>> We had the problem on an AM33xx platform, that SPL detected an
>> unsupported boot-device. But since this message is a debug message
>> it took a bit of time to really know, where the hangup in SPL
>> resulted from. So let's change this debug message to a printf
>> and also print the detected boot-device that is not supported.
>> This makes debugging of such cases much easier.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Tom Rini <trini@ti.com>
>
> Did you build all of ARM with this?  I _think_ this may break the
> davinci/related boards that use SPL since they don't have printf due to
> size.

Yes, might be the case. I'm running the build for all ARM board right 
now. Will let you know if this breaks anything.

Thanks,
Stefan