public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] tools/kwbimage: Fix compilation warning
Date: Thu, 13 Nov 2014 14:51:55 -0800	[thread overview]
Message-ID: <5465360B.50109@freescale.com> (raw)
In-Reply-To: <20141028103825.C0A02382FFB@gemini.denx.de>

On 10/28/2014 03:38 AM, Wolfgang Denk wrote:
> Dear Stefan Roese,
> 
> In message <1414492344-19055-1-git-send-email-sr@denx.de> you wrote:
>> This patch fixes a compilation warning of kwbimage.c:
>>
>> tools/kwbimage.c: In function ?kwbimage_set_header?:
>> tools/kwbimage.c:784:8: warning: ?headersz? may be used uninitialized in this function [-Wmaybe-uninitialized]
>>   memcpy(ptr, image, headersz);
>>         ^
>> Instead of using multiple if statements, use a switch statement with
>> a default entry. And return with error if an unsupported version
>> is configured in the cfg file.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> ---
>> v2:
>> - Change error message so that it really makes sense (unsupported
>>   version instead of no version)
>> - Change this also in the commit text
>> - Small change (s/is/if)
> 
> Acked-By: Wolfgang Denk <wd@denx.de>
> 

I failed to see how the warning message got fixed. I still see this warning when
compiling.

York

  reply	other threads:[~2014-11-13 22:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-28 10:32 [U-Boot] [PATCH v2] tools/kwbimage: Fix compilation warning Stefan Roese
2014-10-28 10:38 ` Wolfgang Denk
2014-11-13 22:51   ` York Sun [this message]
2014-10-30 22:16 ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5465360B.50109@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox