From: Nikolay Dimitrov <picmaster@mail.bg>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mx6sabresd: Move the DCD settings to spl code
Date: Fri, 14 Nov 2014 14:22:47 +0200 [thread overview]
Message-ID: <5465F417.3040004@mail.bg> (raw)
In-Reply-To: <CAOMZO5D3er35eeE5noakBoQbB-3TmD8VDfqLpwRvc=kXdPT=Hg@mail.gmail.com>
Hi Fabio,
On 11/14/2014 01:57 PM, Fabio Estevam wrote:
> Hi Nikolay,
>
> On Fri, Nov 14, 2014 at 9:48 AM, Nikolay Dimitrov <picmaster@mail.bg> wrote:
>> Hi Fabio,
>>
>> On 11/13/2014 11:58 PM, Fabio Estevam wrote:
>>>
>>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>>
>>> mx6sabresd_spl.cfg configures CCM registers, GPR registers and CCM_CCOSR.
>>>
>>> Move the configuration to the spl code.
>>
>>
>> I forgot to asker earlier, but what are the benefits of going from DCD to
>> SPL code to provide HW initialization?
>
> We already went through the hard part of removing the DDR settings
> from DCD in the SPL case. Now all is left is a few register writes
> that could be better placed into SPL code.
>
> Some advantages:
>
> - Shorter and cleaner code - see the stat diff of this series. This
> will avoid lots of duplication of the same spl DCD settings for
> several boards.
> - Do all the register settings in C rather than in a static DCD table.
> Easier to maintain and provide future changes.
> - We really don't need to do such simple register settings from DCD ;-)
OK, understood. Thanks,
Nikolay
next prev parent reply other threads:[~2014-11-14 12:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 21:58 [U-Boot] [PATCH] mx6sabresd: Move the DCD settings to spl code Fabio Estevam
2014-11-13 22:25 ` Nikolay Dimitrov
2014-11-13 22:30 ` Fabio Estevam
2014-11-13 23:00 ` John Tobias
2014-11-14 10:17 ` Otavio Salvador
2014-11-14 10:26 ` Fabio Estevam
2014-11-13 23:16 ` Stefano Babic
2014-11-13 23:24 ` Fabio Estevam
2014-11-14 8:02 ` Stefano Babic
2014-11-14 11:48 ` Nikolay Dimitrov
2014-11-14 11:57 ` Fabio Estevam
2014-11-14 12:22 ` Nikolay Dimitrov [this message]
2014-11-14 13:23 ` Stefano Babic
2014-11-14 14:40 ` Nikolay Dimitrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5465F417.3040004@mail.bg \
--to=picmaster@mail.bg \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox