[U-Boot] [PATCH v3 3/3] arm: odroid: usb: add support for usb host including ethernet

Suriyan Ramasami
2014-11-18T03:30:43Z

Hello Minkyu Kang/Przemyslaw and of course anyone else who can direct me,

Thanks for the commit.

I just realized that the code in this particular patch is missing
the gpio_request() call before calling the gpio_direction_output()
call, and hence fails to initialize the USB3503A hub. This was pointed
out by Przemyslaw in another patch of mine (odroid: blue LED)

So, my question is, this patch is in u-boot-samsung. To correct the
above mentioned error, do I submit a patch directed to u-boot-samsung?
If so how do I do it? I mean, do I elaborate this in the subject
/.body of the mail?

Thanks and regards,
- Suriyan

On Mon, Nov 17, 2014 at 6:02 AM, Minkyu Kang <mk7.kang@samsung.com> wrote:
> On 30/10/14 01:22, Suriyan Ramasami wrote:
>> This change adds support for enabling the USB host features of the board.
>> This includes the USB3503A hub and the SMC LAN9730 ethernet controller
>> as well.
>>
>> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>>
>> ---
>>
>> Changes in v3:
>> * removed set_usb_ethaddr() and related code as the GUID registers do not
>> seem to be documented anywhere. This is sad, as this mechanism allows
>> for each Odroid to boot up with the same MAC address every time, but no
>> two odroids shall have the same MAC address on boot. This ensures multiple
>> odroids in the same LAN to come up without conflicting MAC addresses.
>> * Minkyu - Do not mix cpu_is... and proid_is...
>>
>> Changes in v2:
>> * Jaehoon - Split power.[ch] as a separate patch
>> * Removed an unneeded header file from ehci-exynos.c
>> * Jaehoon - Fix indentation in the dts file
>>
>> Changes in v1:
>> * First try
>>
>> arch/arm/dts/exynos4412-odroid.dts | 11 +++++++
>> arch/arm/include/asm/arch-exynos/ehci.h | 13 ++++++++
>> board/samsung/odroid/odroid.c | 32 +++++++++++++++++++
>> drivers/usb/host/ehci-exynos.c | 55 ++++++++++++++++++++++++++++-----
>> include/configs/odroid.h | 13 ++++++++
>> 5 files changed, 116 insertions(+), 8 deletions(-)
>>
>
> applied to u-boot-samsung.
>
> Thanks,
> Minkyu Kang.
>