* [U-Boot] [PATCH] exynos: dts: Correct USB vbus-gpio numbering for Snow
@ 2014-11-06 10:44 Sjoerd Simons
2014-11-07 17:06 ` Simon Glass
2014-11-17 14:04 ` Minkyu Kang
0 siblings, 2 replies; 3+ messages in thread
From: Sjoerd Simons @ 2014-11-06 10:44 UTC (permalink / raw)
To: u-boot
The current vbus GPIOs on snow make very little sense, their number is
far above the maximum. As a result, USB doesn't work on snow.
Correct the GPIO numbering so they match the current scheme for exynos5.
Tested both EHCI and XHCI to correctly work after this change.
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
arch/arm/dts/exynos5250-snow.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/dts/exynos5250-snow.dts b/arch/arm/dts/exynos5250-snow.dts
index 6fd9275..95af025 100644
--- a/arch/arm/dts/exynos5250-snow.dts
+++ b/arch/arm/dts/exynos5250-snow.dts
@@ -131,11 +131,11 @@
};
ehci at 12110000 {
- samsung,vbus-gpio = <&gpio 0x309 0>; /* X11 */
+ samsung,vbus-gpio = <&gpio 0xb1 0>; /* X11 */
};
xhci at 12000000 {
- samsung,vbus-gpio = <&gpio 0x317 0>; /* X27 */
+ samsung,vbus-gpio = <&gpio 0xbf 0>; /* X27 */
};
tmu at 10060000 {
--
2.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] exynos: dts: Correct USB vbus-gpio numbering for Snow
2014-11-06 10:44 [U-Boot] [PATCH] exynos: dts: Correct USB vbus-gpio numbering for Snow Sjoerd Simons
@ 2014-11-07 17:06 ` Simon Glass
2014-11-17 14:04 ` Minkyu Kang
1 sibling, 0 replies; 3+ messages in thread
From: Simon Glass @ 2014-11-07 17:06 UTC (permalink / raw)
To: u-boot
On 6 November 2014 03:44, Sjoerd Simons <sjoerd.simons@collabora.co.uk> wrote:
> The current vbus GPIOs on snow make very little sense, their number is
> far above the maximum. As a result, USB doesn't work on snow.
>
> Correct the GPIO numbering so they match the current scheme for exynos5.
> Tested both EHCI and XHCI to correctly work after this change.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Acked-by: Simon Glass <sjg@chromium.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] exynos: dts: Correct USB vbus-gpio numbering for Snow
2014-11-06 10:44 [U-Boot] [PATCH] exynos: dts: Correct USB vbus-gpio numbering for Snow Sjoerd Simons
2014-11-07 17:06 ` Simon Glass
@ 2014-11-17 14:04 ` Minkyu Kang
1 sibling, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2014-11-17 14:04 UTC (permalink / raw)
To: u-boot
On 06/11/14 19:44, Sjoerd Simons wrote:
> The current vbus GPIOs on snow make very little sense, their number is
> far above the maximum. As a result, USB doesn't work on snow.
>
> Correct the GPIO numbering so they match the current scheme for exynos5.
> Tested both EHCI and XHCI to correctly work after this change.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
> arch/arm/dts/exynos5250-snow.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/dts/exynos5250-snow.dts b/arch/arm/dts/exynos5250-snow.dts
> index 6fd9275..95af025 100644
> --- a/arch/arm/dts/exynos5250-snow.dts
> +++ b/arch/arm/dts/exynos5250-snow.dts
> @@ -131,11 +131,11 @@
> };
>
> ehci at 12110000 {
> - samsung,vbus-gpio = <&gpio 0x309 0>; /* X11 */
> + samsung,vbus-gpio = <&gpio 0xb1 0>; /* X11 */
> };
>
> xhci at 12000000 {
> - samsung,vbus-gpio = <&gpio 0x317 0>; /* X27 */
> + samsung,vbus-gpio = <&gpio 0xbf 0>; /* X27 */
> };
>
> tmu at 10060000 {
>
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-17 14:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-06 10:44 [U-Boot] [PATCH] exynos: dts: Correct USB vbus-gpio numbering for Snow Sjoerd Simons
2014-11-07 17:06 ` Simon Glass
2014-11-17 14:04 ` Minkyu Kang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox