From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Tue, 18 Nov 2014 12:14:31 +0100 Subject: [U-Boot] [PATCH v3 3/3] arm: odroid: usb: add support for usb host including ethernet In-Reply-To: <546AFFFD.1080803@samsung.com> References: <1414599763-15861-1-git-send-email-suriyan.r@gmail.com> <1414599763-15861-3-git-send-email-suriyan.r@gmail.com> <546A0012.5050101@samsung.com> <546AFFFD.1080803@samsung.com> Message-ID: <546B2A17.9050106@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Minkyu, On 11/18/2014 09:14 AM, Minkyu Kang wrote: > Hi, > > On 18/11/14 12:30, Suriyan Ramasami wrote: >> Hello Minkyu Kang/Przemyslaw and of course anyone else who can direct me, >> >> Thanks for the commit. >> >> I just realized that the code in this particular patch is missing >> the gpio_request() call before calling the gpio_direction_output() >> call, and hence fails to initialize the USB3503A hub. This was pointed >> out by Przemyslaw in another patch of mine (odroid: blue LED) >> >> So, my question is, this patch is in u-boot-samsung. To correct the >> above mentioned error, do I submit a patch directed to u-boot-samsung? > > Yes. Please send new patch. > >> If so how do I do it? I mean, do I elaborate this in the subject >> /.body of the mail? > > sorry, I can't catch the point of your question. > >> >> Thanks and regards, >> - Suriyan > > Thanks, > Minkyu Kang. > > Could you please wait for the test/ack next time before you merge the patches to the tree? It will prevent before making an additional work on testing or fixing some code. Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com