public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] odroid: Turn blue LED on
@ 2014-11-17 23:50 Suriyan Ramasami
  2014-11-18 11:23 ` Przemyslaw Marczak
  2014-11-24  2:22 ` Minkyu Kang
  0 siblings, 2 replies; 3+ messages in thread
From: Suriyan Ramasami @ 2014-11-17 23:50 UTC (permalink / raw)
  To: u-boot

To indicate that U-Boot is active, turn on the blue LED.

Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>

---

Changes in v2:
- Przemyslaw Marczak, Add gpio_request call.

Changes in v1:
- First try

 board/samsung/odroid/odroid.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
index 33003ee..e1a86f9 100644
--- a/board/samsung/odroid/odroid.c
+++ b/board/samsung/odroid/odroid.c
@@ -382,6 +382,11 @@ static void board_gpio_init(void)
 	gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
 	gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
 	gpio_direction_input(EXYNOS4X12_GPIO_X31);
+
+	/* Blue LED (Odroid X2/U2/U3) */
+	gpio_request(EXYNOS4X12_GPIO_C10, "Blue LED");
+
+	gpio_direction_output(EXYNOS4X12_GPIO_C10, 0);
 }
 
 static int pmic_init_max77686(void)
-- 
1.8.3.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] odroid: Turn blue LED on
  2014-11-17 23:50 [U-Boot] [PATCH v2] odroid: Turn blue LED on Suriyan Ramasami
@ 2014-11-18 11:23 ` Przemyslaw Marczak
  2014-11-24  2:22 ` Minkyu Kang
  1 sibling, 0 replies; 3+ messages in thread
From: Przemyslaw Marczak @ 2014-11-18 11:23 UTC (permalink / raw)
  To: u-boot

Hello Suriyan,

On 11/18/2014 12:50 AM, Suriyan Ramasami wrote:
> To indicate that U-Boot is active, turn on the blue LED.
>
> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>
> ---
>
> Changes in v2:
> - Przemyslaw Marczak, Add gpio_request call.
>
> Changes in v1:
> - First try
>
>   board/samsung/odroid/odroid.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
> index 33003ee..e1a86f9 100644
> --- a/board/samsung/odroid/odroid.c
> +++ b/board/samsung/odroid/odroid.c
> @@ -382,6 +382,11 @@ static void board_gpio_init(void)
>   	gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
>   	gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
>   	gpio_direction_input(EXYNOS4X12_GPIO_X31);
> +
> +	/* Blue LED (Odroid X2/U2/U3) */
> +	gpio_request(EXYNOS4X12_GPIO_C10, "Blue LED");
> +
> +	gpio_direction_output(EXYNOS4X12_GPIO_C10, 0);
>   }
>
>   static int pmic_init_max77686(void)
>

Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>

Best regards,
-- 
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] odroid: Turn blue LED on
  2014-11-17 23:50 [U-Boot] [PATCH v2] odroid: Turn blue LED on Suriyan Ramasami
  2014-11-18 11:23 ` Przemyslaw Marczak
@ 2014-11-24  2:22 ` Minkyu Kang
  1 sibling, 0 replies; 3+ messages in thread
From: Minkyu Kang @ 2014-11-24  2:22 UTC (permalink / raw)
  To: u-boot

Dear Suriyan Ramasami,

On 18/11/14 08:50, Suriyan Ramasami wrote:
> To indicate that U-Boot is active, turn on the blue LED.
> 
> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
> 
> ---
> 
> Changes in v2:
> - Przemyslaw Marczak, Add gpio_request call.
> 
> Changes in v1:
> - First try
> 
>  board/samsung/odroid/odroid.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
> index 33003ee..e1a86f9 100644
> --- a/board/samsung/odroid/odroid.c
> +++ b/board/samsung/odroid/odroid.c
> @@ -382,6 +382,11 @@ static void board_gpio_init(void)
>  	gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
>  	gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
>  	gpio_direction_input(EXYNOS4X12_GPIO_X31);
> +
> +	/* Blue LED (Odroid X2/U2/U3) */
> +	gpio_request(EXYNOS4X12_GPIO_C10, "Blue LED");
> +
> +	gpio_direction_output(EXYNOS4X12_GPIO_C10, 0);
>  }
>  
>  static int pmic_init_max77686(void)
> 

Because board_gpio_init was changed by you, please rebase this patch.

Thanks,
Minkyu Kang.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-11-24  2:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-17 23:50 [U-Boot] [PATCH v2] odroid: Turn blue LED on Suriyan Ramasami
2014-11-18 11:23 ` Przemyslaw Marczak
2014-11-24  2:22 ` Minkyu Kang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox