From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Date: Tue, 18 Nov 2014 13:47:59 +0100 Subject: [U-Boot] [PATCH 4/5] sun6i: Drop some "unknown magic" from dram init In-Reply-To: <1416250917.25454.33.camel@hellion.org.uk> References: <1416154613-8506-1-git-send-email-hdegoede@redhat.com> <1416154613-8506-4-git-send-email-hdegoede@redhat.com> <1416250917.25454.33.camel@hellion.org.uk> Message-ID: <546B3FFF.2080202@redhat.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 11/17/2014 08:01 PM, Ian Campbell wrote: > On Sun, 2014-11-16 at 17:16 +0100, Hans de Goede wrote: >> This bit of code is the rtc ram being used to detect coming out of >> "super-standby" mode, and if that is the case, going out of self-refresh mode. >> >> Since we do not support "super-standby" mode, this can be dropped. >> >> Signed-off-by: Hans de Goede > > Acked-by: Ian Campbell > > (perhaps start the commit log with "Allwinner tells us that..."? Ack > either way) Fixed in my local tree. Regards, Hans > >> --- >> arch/arm/cpu/armv7/sunxi/dram_sun6i.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/arch/arm/cpu/armv7/sunxi/dram_sun6i.c b/arch/arm/cpu/armv7/sunxi/dram_sun6i.c >> index 2ac0b58..5e163cb 100644 >> --- a/arch/arm/cpu/armv7/sunxi/dram_sun6i.c >> +++ b/arch/arm/cpu/armv7/sunxi/dram_sun6i.c >> @@ -140,9 +140,6 @@ static void mctl_channel_init(int ch_index, struct dram_sun6i_para *para) >> >> writel((MCTL_TITMSRST << 18) | (MCTL_TDLLLOCK << 6) | MCTL_TDLLSRST, >> &mctl_phy->ptr0); >> - /* Unknown magic performed by boot0 */ >> - if ((readl(SUNXI_RTC_BASE + 0x20c) & 3) == 2) >> - setbits_le32(&mctl_phy->ptr0, 1 << 18); >> >> writel((MCTL_TDINIT1 << 19) | MCTL_TDINIT0, &mctl_phy->ptr1); >> writel((MCTL_TDINIT3 << 17) | MCTL_TDINIT2, &mctl_phy->ptr2); > >