public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/3] arm: odroid: usb: add support for usb host including ethernet
Date: Tue, 18 Nov 2014 23:05:37 +0900	[thread overview]
Message-ID: <546B5231.7030307@samsung.com> (raw)
In-Reply-To: <546B2A17.9050106@samsung.com>

Dear Przemyslaw Marczak,

On 18/11/14 20:14, Przemyslaw Marczak wrote:
> Dear Minkyu,
> 
> On 11/18/2014 09:14 AM, Minkyu Kang wrote:
>> Hi,
>>
>> On 18/11/14 12:30, Suriyan Ramasami wrote:
>>> Hello Minkyu Kang/Przemyslaw and of course anyone else who can direct me,
>>>
>>> Thanks for the commit.
>>>
>>>      I just realized that the code in this particular patch is missing
>>> the gpio_request() call before calling the gpio_direction_output()
>>> call, and hence fails to initialize the USB3503A hub. This was pointed
>>> out by Przemyslaw in another patch of mine (odroid: blue LED)
>>>
>>>     So, my question is, this patch is in u-boot-samsung. To correct the
>>> above mentioned error, do I submit a patch directed to u-boot-samsung?
>>
>> Yes. Please send new patch.
>>
>>> If so how do I do it? I mean, do I elaborate this in the subject
>>> /.body of the mail?
>>
>> sorry, I can't catch the point of your question.
>>
>>>
>>> Thanks and regards,
>>> - Suriyan
>>
>> Thanks,
>> Minkyu Kang.
>>
>>
> 
> Could you please wait for the test/ack next time before you merge the patches to the tree? It will prevent before making an additional work on testing or fixing some code.
> 
> Best regards,

It's my bad that I didn't check it carefully.
I usually wait somebody's response.
But this patch is waited 18 days on the queue.
How long will I wait?

Thanks,
Minkyu Kang.

  reply	other threads:[~2014-11-18 14:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 16:22 [U-Boot] [PATCH v3 1/3] arm: odroid: pmic77686: allow buck voltage settings Suriyan Ramasami
2014-10-29 16:22 ` [U-Boot] [PATCH v3 2/3] arm: odroid: enable/disable usb host phy for exynos4412 Suriyan Ramasami
2014-11-17 14:03   ` Minkyu Kang
2014-10-29 16:22 ` [U-Boot] [PATCH v3 3/3] arm: odroid: usb: add support for usb host including ethernet Suriyan Ramasami
2014-10-30  1:17   ` Jaehoon Chung
2014-10-30  4:40     ` Suriyan Ramasami
2014-10-30  5:11       ` Suriyan Ramasami
2014-11-17 14:02   ` Minkyu Kang
2014-11-18  3:30     ` Suriyan Ramasami
2014-11-18  8:14       ` Minkyu Kang
2014-11-18 11:14         ` Przemyslaw Marczak
2014-11-18 14:05           ` Minkyu Kang [this message]
2014-11-18 14:33             ` Przemyslaw Marczak
2014-11-18 11:09       ` Przemyslaw Marczak
2014-11-18 17:34         ` Suriyan Ramasami
2014-11-19 17:18           ` Przemyslaw Marczak
2014-11-17 14:03 ` [U-Boot] [PATCH v3 1/3] arm: odroid: pmic77686: allow buck voltage settings Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546B5231.7030307@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox