From mboxrd@z Thu Jan 1 00:00:00 1970 From: Przemyslaw Marczak Date: Tue, 18 Nov 2014 15:33:36 +0100 Subject: [U-Boot] [PATCH v3 3/3] arm: odroid: usb: add support for usb host including ethernet In-Reply-To: <546B5231.7030307@samsung.com> References: <1414599763-15861-1-git-send-email-suriyan.r@gmail.com> <1414599763-15861-3-git-send-email-suriyan.r@gmail.com> <546A0012.5050101@samsung.com> <546AFFFD.1080803@samsung.com> <546B2A17.9050106@samsung.com> <546B5231.7030307@samsung.com> Message-ID: <546B58C0.2090600@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Minkyu, On 11/18/2014 03:05 PM, Minkyu Kang wrote: > Dear Przemyslaw Marczak, > > On 18/11/14 20:14, Przemyslaw Marczak wrote: >> Dear Minkyu, >> >> On 11/18/2014 09:14 AM, Minkyu Kang wrote: >>> Hi, >>> >>> On 18/11/14 12:30, Suriyan Ramasami wrote: >>>> Hello Minkyu Kang/Przemyslaw and of course anyone else who can direct me, >>>> >>>> Thanks for the commit. >>>> >>>> I just realized that the code in this particular patch is missing >>>> the gpio_request() call before calling the gpio_direction_output() >>>> call, and hence fails to initialize the USB3503A hub. This was pointed >>>> out by Przemyslaw in another patch of mine (odroid: blue LED) >>>> >>>> So, my question is, this patch is in u-boot-samsung. To correct the >>>> above mentioned error, do I submit a patch directed to u-boot-samsung? >>> >>> Yes. Please send new patch. >>> >>>> If so how do I do it? I mean, do I elaborate this in the subject >>>> /.body of the mail? >>> >>> sorry, I can't catch the point of your question. >>> >>>> >>>> Thanks and regards, >>>> - Suriyan >>> >>> Thanks, >>> Minkyu Kang. >>> >>> >> >> Could you please wait for the test/ack next time before you merge the patches to the tree? It will prevent before making an additional work on testing or fixing some code. >> >> Best regards, > > It's my bad that I didn't check it carefully. > I usually wait somebody's response. > But this patch is waited 18 days on the queue. > How long will I wait? > > Thanks, > Minkyu Kang. > It's easy to miss something without test on a hardware and this is the reason why the code should be tested before the merge. The 18 days is quite long, I agree with you - but is this a reason for those patches to be merged, without the test? You are a busy person at work, the same as I am, but I hope that "ping" somebody to check the code is a good manner. And then I believe, we can provide stable and tested master tree as a maintainers of our boards. Best regards, -- Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com