From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Freescale t104x: Do not exclude SGMII
Date: Tue, 18 Nov 2014 15:23:11 -0800 [thread overview]
Message-ID: <546BD4DF.9060808@freescale.com> (raw)
In-Reply-To: <1414162142-31336-1-git-send-email-Joakim.Tjernlund@transmode.se>
On 10/24/2014 07:49 AM, Joakim Tjernlund wrote:
> fman_port_enet_if() tests if FM1_DTSEC2 or FM1_DTSEC4 uses
> RGMII or MII and if not returns PHY_INTERFACE_MODE_NONE.
> This excludes testing for SGMII further down.
>
> Remove the unconditional "else return PHY_INTERFACE_MODE_NONE"
> so SGMII can be tested too.
>
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> ---
> drivers/net/fm/t1040.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/fm/t1040.c b/drivers/net/fm/t1040.c
> index 4cce46d..d2a097e 100644
> --- a/drivers/net/fm/t1040.c
> +++ b/drivers/net/fm/t1040.c
> @@ -25,8 +25,6 @@ phy_interface_t fman_port_enet_if(enum fm_port port)
> else if ((rcwsr13 & FSL_CORENET_RCWSR13_EC1) ==
> FSL_CORENET_RCWSR13_EC1_FM1_DTSEC4_MII)
> return PHY_INTERFACE_MODE_MII;
> - else
> - return PHY_INTERFACE_MODE_NONE;
> }
>
> if ((port == FM1_DTSEC4) &&
> @@ -38,8 +36,6 @@ phy_interface_t fman_port_enet_if(enum fm_port port)
> else if ((rcwsr13 & FSL_CORENET_RCWSR13_EC1) ==
> FSL_CORENET_RCWSR13_EC1_FM1_DTSEC4_MII)
> return PHY_INTERFACE_MODE_MII;
> - else
> - return PHY_INTERFACE_MODE_NONE;
> }
>
> if (port == FM1_DTSEC5) {
>
Prabhakar,
Can you test/ack this patch?
York
next prev parent reply other threads:[~2014-11-18 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 14:49 [U-Boot] [PATCH] Freescale t104x: Do not exclude SGMII Joakim Tjernlund
2014-11-18 23:23 ` York Sun [this message]
2014-12-05 16:17 ` York Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546BD4DF.9060808@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox