* [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information
@ 2014-11-19 16:21 Suriyan Ramasami
2014-11-19 16:21 ` [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call Suriyan Ramasami
2014-11-19 17:39 ` [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information Przemyslaw Marczak
0 siblings, 2 replies; 10+ messages in thread
From: Suriyan Ramasami @ 2014-11-19 16:21 UTC (permalink / raw)
To: u-boot
Add information wrt the USB host side of things for the Odroid-U2/U3 and the
Odroid-X/X2
Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
---
Changes in v1:
- Add USB host notes for the Odroid
doc/README.odroid | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 48 insertions(+)
diff --git a/doc/README.odroid b/doc/README.odroid
index 528bb95..0eaf3ff 100644
--- a/doc/README.odroid
+++ b/doc/README.odroid
@@ -141,3 +141,51 @@ And the boot sequence is:
- boot_fit - if "Image.itb" exists
- boot_zimg - if "zImage" exists
- boot_uimg - if "uImage" exists
+
+11. USB host support
+====================
+The Odroid-X/X2 have the below schematics wrt USB:
+
+Exynos USB_HOST1 -> USB3503 HUB ----> LAN9514 USB HUB -----> LAN9514 Ethernet
+ | |
+ | +-------Host1---------> USB port
+ | |
+ | +-------Host2---------> USB port
+ | |
+ | +-------Host3---------> USB port
+ | |
+ | +-------Host4---------> USB port
+ |
+ +-------------------------------------> USB port
+ |
+ +-------------------------------------> USB port
+
+The Odroid-U2/U3 have the below schematics wrt USB:
+
+Exynos HSIC1 -----------------------------------------------> LAN9514 Ethernet
+
+Exynos HSIC2 -----> USB3503A HUB ---------------Host1---------> USB port
+ |
+ +-----------------------Host2---------> USB port
+ |
+ +-----------------------HOst3---------> USB port (U3)
+
+The HSICs are used in the case of the Odroid-Us and the USB Host in the SoC
+is used in the case of the Odroid-Xs.
+
+In drivers/usb/host/ehci-exynos.c, function names starting with exysno4412*
+have been added to initialize the HSICs and the PHYs.
+
+In board/samsung/odroid/odroid.c, function board_usb_init() adds code to
+initialize the USB3503 hub.
+The initializing of the USB3503 hub is as defined in the USB3503A spec sheet.
+Please refer to Figure 4.1 in the Datasheet.
+a) Set the INT_N (X30) low (Odroid-Us) or high (Odroid-Xs). This is so that the
+correct REFCLK frequency is selected. 24MHz for Odroid Us and 26MHz for Odroid
+Xs.
+b) Disconnect the HUB (Set HUB_CONNECT (X34) to 0)
+c) Reset the HUB (Set RESET_N (X35) to 0 and then to 1)
+d) HUB waits for REF_CLK (which we have set appropriately)
+e) Timeout waiting for HUB configuration stage
+f) Connect the HUB (Set HUB_CONNECT (X34) to 1)
+g) Power recycle the LAN9730 which is connected to BUCK8 (Odroid Us)
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call
2014-11-19 16:21 [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information Suriyan Ramasami
@ 2014-11-19 16:21 ` Suriyan Ramasami
2014-11-19 17:41 ` Przemyslaw Marczak
2014-11-20 8:41 ` Minkyu Kang
2014-11-19 17:39 ` [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information Przemyslaw Marczak
1 sibling, 2 replies; 10+ messages in thread
From: Suriyan Ramasami @ 2014-11-19 16:21 UTC (permalink / raw)
To: u-boot
The USB host code was missing gpio_request() calls before using the gpio
functions, causing errors to be printed out.
Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
---
Changes in v1:
- Added gpio_request() call in board_gpio_init()
board/samsung/odroid/odroid.c | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
index f7396ab..a2c008e 100644
--- a/board/samsung/odroid/odroid.c
+++ b/board/samsung/odroid/odroid.c
@@ -382,6 +382,17 @@ static void board_gpio_init(void)
gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
gpio_direction_input(EXYNOS4X12_GPIO_X31);
+
+#ifdef CONFIG_CMD_USB
+ /* USB3503A Reference frequency */
+ gpio_request(EXYNOS4X12_GPIO_X30, "USB3503A RefFreq");
+
+ /* USB3503A Connect */
+ gpio_request(EXYNOS4X12_GPIO_X34, "USB3503A Connect");
+
+ /* USB3503A Reset */
+ gpio_request(EXYNOS4X12_GPIO_X35, "USB3503A Reset");
+#endif
}
static int pmic_init_max77686(void)
@@ -489,10 +500,8 @@ int board_usb_init(int index, enum usb_init_type init)
p_pmic = pmic_get("MAX77686_PMIC");
if (p_pmic && !pmic_probe(p_pmic)) {
- max77686_set_buck_mode(p_pmic, 8, OPMODE_OFF);
max77686_set_buck_voltage(p_pmic, 8, 750000);
max77686_set_buck_voltage(p_pmic, 8, 3300000);
- max77686_set_buck_mode(p_pmic, 8, OPMODE_ON);
}
#endif
--
1.8.3.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information
2014-11-19 16:21 [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information Suriyan Ramasami
2014-11-19 16:21 ` [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call Suriyan Ramasami
@ 2014-11-19 17:39 ` Przemyslaw Marczak
2014-11-19 18:29 ` Suriyan Ramasami
1 sibling, 1 reply; 10+ messages in thread
From: Przemyslaw Marczak @ 2014-11-19 17:39 UTC (permalink / raw)
To: u-boot
Hello,
On 11/19/2014 05:21 PM, Suriyan Ramasami wrote:
> Add information wrt the USB host side of things for the Odroid-U2/U3 and the
> Odroid-X/X2
>
> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
> ---
>
> Changes in v1:
> - Add USB host notes for the Odroid
>
> doc/README.odroid | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
>
> diff --git a/doc/README.odroid b/doc/README.odroid
> index 528bb95..0eaf3ff 100644
> --- a/doc/README.odroid
> +++ b/doc/README.odroid
> @@ -141,3 +141,51 @@ And the boot sequence is:
> - boot_fit - if "Image.itb" exists
> - boot_zimg - if "zImage" exists
> - boot_uimg - if "uImage" exists
> +
> +11. USB host support
> +====================
> +The Odroid-X/X2 have the below schematics wrt USB:
> +
> +Exynos USB_HOST1 -> USB3503 HUB ----> LAN9514 USB HUB -----> LAN9514 Ethernet
> + | |
> + | +-------Host1---------> USB port
> + | |
> + | +-------Host2---------> USB port
> + | |
> + | +-------Host3---------> USB port
> + | |
> + | +-------Host4---------> USB port
> + |
> + +-------------------------------------> USB port
> + |
> + +-------------------------------------> USB port
> +
> +The Odroid-U2/U3 have the below schematics wrt USB:
> +
> +Exynos HSIC1 -----------------------------------------------> LAN9514 Ethernet
> +
> +Exynos HSIC2 -----> USB3503A HUB ---------------Host1---------> USB port
> + |
> + +-----------------------Host2---------> USB port
> + |
> + +-----------------------HOst3---------> USB port (U3)
> +
> +The HSICs are used in the case of the Odroid-Us and the USB Host in the SoC
> +is used in the case of the Odroid-Xs.
> +
> +In drivers/usb/host/ehci-exynos.c, function names starting with exysno4412*
> +have been added to initialize the HSICs and the PHYs.
> +
> +In board/samsung/odroid/odroid.c, function board_usb_init() adds code to
> +initialize the USB3503 hub.
> +The initializing of the USB3503 hub is as defined in the USB3503A spec sheet.
> +Please refer to Figure 4.1 in the Datasheet.
> +a) Set the INT_N (X30) low (Odroid-Us) or high (Odroid-Xs). This is so that the
> +correct REFCLK frequency is selected. 24MHz for Odroid Us and 26MHz for Odroid
> +Xs.
> +b) Disconnect the HUB (Set HUB_CONNECT (X34) to 0)
> +c) Reset the HUB (Set RESET_N (X35) to 0 and then to 1)
> +d) HUB waits for REF_CLK (which we have set appropriately)
> +e) Timeout waiting for HUB configuration stage
> +f) Connect the HUB (Set HUB_CONNECT (X34) to 1)
> +g) Power recycle the LAN9730 which is connected to BUCK8 (Odroid Us)
>
Suriyan, you quite misunderstand my intention. You added really useful
part of code - now user can read/write data to USB mass storage or boot
over the Ethernet. Probably you are using this feature. And this is a
usage of the USB for the user.
For the user - it's not important how it works in the hardware - I would
like to get some simple instructions, e.g. How to boot Odroid over the
Ethernet, or how to write data to USB stick. I believe that users read
this documentation when they starting use of Odroid with the mainline
U-Boot, and a description of another boot option is welcome here.
It should be "How to start with this board", rather than how to develop
USB hub driver on it.
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call
2014-11-19 16:21 ` [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call Suriyan Ramasami
@ 2014-11-19 17:41 ` Przemyslaw Marczak
2014-11-20 8:41 ` Minkyu Kang
1 sibling, 0 replies; 10+ messages in thread
From: Przemyslaw Marczak @ 2014-11-19 17:41 UTC (permalink / raw)
To: u-boot
Hello,
On 11/19/2014 05:21 PM, Suriyan Ramasami wrote:
> The USB host code was missing gpio_request() calls before using the gpio
> functions, causing errors to be printed out.
>
> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>
> ---
>
> Changes in v1:
> - Added gpio_request() call in board_gpio_init()
>
> board/samsung/odroid/odroid.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
> index f7396ab..a2c008e 100644
> --- a/board/samsung/odroid/odroid.c
> +++ b/board/samsung/odroid/odroid.c
> @@ -382,6 +382,17 @@ static void board_gpio_init(void)
> gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
> gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
> gpio_direction_input(EXYNOS4X12_GPIO_X31);
> +
> +#ifdef CONFIG_CMD_USB
> + /* USB3503A Reference frequency */
> + gpio_request(EXYNOS4X12_GPIO_X30, "USB3503A RefFreq");
> +
> + /* USB3503A Connect */
> + gpio_request(EXYNOS4X12_GPIO_X34, "USB3503A Connect");
> +
> + /* USB3503A Reset */
> + gpio_request(EXYNOS4X12_GPIO_X35, "USB3503A Reset");
> +#endif
> }
>
> static int pmic_init_max77686(void)
> @@ -489,10 +500,8 @@ int board_usb_init(int index, enum usb_init_type init)
>
> p_pmic = pmic_get("MAX77686_PMIC");
> if (p_pmic && !pmic_probe(p_pmic)) {
> - max77686_set_buck_mode(p_pmic, 8, OPMODE_OFF);
> max77686_set_buck_voltage(p_pmic, 8, 750000);
> max77686_set_buck_voltage(p_pmic, 8, 3300000);
> - max77686_set_buck_mode(p_pmic, 8, OPMODE_ON);
> }
>
> #endif
>
The first commit needs to be changed but for this one:
Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information
2014-11-19 17:39 ` [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information Przemyslaw Marczak
@ 2014-11-19 18:29 ` Suriyan Ramasami
2014-11-19 18:40 ` Przemyslaw Marczak
0 siblings, 1 reply; 10+ messages in thread
From: Suriyan Ramasami @ 2014-11-19 18:29 UTC (permalink / raw)
To: u-boot
Hello Przemyslaw,
On Wed, Nov 19, 2014 at 9:39 AM, Przemyslaw Marczak
<p.marczak@samsung.com> wrote:
> Hello,
>
> On 11/19/2014 05:21 PM, Suriyan Ramasami wrote:
>>
>> Add information wrt the USB host side of things for the Odroid-U2/U3 and
>> the
>> Odroid-X/X2
>>
>> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>> ---
>>
>> Changes in v1:
>> - Add USB host notes for the Odroid
>>
>> doc/README.odroid | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 48 insertions(+)
>>
>> diff --git a/doc/README.odroid b/doc/README.odroid
>> index 528bb95..0eaf3ff 100644
>> --- a/doc/README.odroid
>> +++ b/doc/README.odroid
>> @@ -141,3 +141,51 @@ And the boot sequence is:
>> - boot_fit - if "Image.itb" exists
>> - boot_zimg - if "zImage" exists
>> - boot_uimg - if "uImage" exists
>> +
>> +11. USB host support
>> +====================
>> +The Odroid-X/X2 have the below schematics wrt USB:
>> +
>> +Exynos USB_HOST1 -> USB3503 HUB ----> LAN9514 USB HUB -----> LAN9514
>> Ethernet
>> + | |
>> + | +-------Host1---------> USB port
>> + | |
>> + | +-------Host2---------> USB port
>> + | |
>> + | +-------Host3---------> USB port
>> + | |
>> + | +-------Host4---------> USB port
>> + |
>> + +-------------------------------------> USB port
>> + |
>> + +-------------------------------------> USB port
>> +
>> +The Odroid-U2/U3 have the below schematics wrt USB:
>> +
>> +Exynos HSIC1 -----------------------------------------------> LAN9514
>> Ethernet
>> +
>> +Exynos HSIC2 -----> USB3503A HUB ---------------Host1---------> USB port
>> + |
>> + +-----------------------Host2---------> USB port
>> + |
>> + +-----------------------HOst3---------> USB port
>> (U3)
>> +
>> +The HSICs are used in the case of the Odroid-Us and the USB Host in the
>> SoC
>> +is used in the case of the Odroid-Xs.
>> +
>> +In drivers/usb/host/ehci-exynos.c, function names starting with
>> exysno4412*
>> +have been added to initialize the HSICs and the PHYs.
>> +
>> +In board/samsung/odroid/odroid.c, function board_usb_init() adds code to
>> +initialize the USB3503 hub.
>> +The initializing of the USB3503 hub is as defined in the USB3503A spec
>> sheet.
>> +Please refer to Figure 4.1 in the Datasheet.
>> +a) Set the INT_N (X30) low (Odroid-Us) or high (Odroid-Xs). This is so
>> that the
>> +correct REFCLK frequency is selected. 24MHz for Odroid Us and 26MHz for
>> Odroid
>> +Xs.
>> +b) Disconnect the HUB (Set HUB_CONNECT (X34) to 0)
>> +c) Reset the HUB (Set RESET_N (X35) to 0 and then to 1)
>> +d) HUB waits for REF_CLK (which we have set appropriately)
>> +e) Timeout waiting for HUB configuration stage
>> +f) Connect the HUB (Set HUB_CONNECT (X34) to 1)
>> +g) Power recycle the LAN9730 which is connected to BUCK8 (Odroid Us)
>>
>
> Suriyan, you quite misunderstand my intention. You added really useful part
> of code - now user can read/write data to USB mass storage or boot over the
> Ethernet. Probably you are using this feature. And this is a usage of the
> USB for the user.
>
> For the user - it's not important how it works in the hardware - I would
> like to get some simple instructions, e.g. How to boot Odroid over the
> Ethernet, or how to write data to USB stick. I believe that users read this
> documentation when they starting use of Odroid with the mainline U-Boot, and
> a description of another boot option is welcome here.
> It should be "How to start with this board", rather than how to develop USB
> hub driver on it.
>
Ah! I see. You are right, I totally misunderstood you. I shall get rid
of the hardware part of things, and add the sections that you have
mentioned, viz:
- How to boot Odroid over Ethernet
- How to boot Odroid over USB storage etc
Thanks
- Suriyan
> Best regards,
> --
> Przemyslaw Marczak
> Samsung R&D Institute Poland
> Samsung Electronics
> p.marczak at samsung.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information
2014-11-19 18:29 ` Suriyan Ramasami
@ 2014-11-19 18:40 ` Przemyslaw Marczak
2014-11-19 18:47 ` Suriyan Ramasami
0 siblings, 1 reply; 10+ messages in thread
From: Przemyslaw Marczak @ 2014-11-19 18:40 UTC (permalink / raw)
To: u-boot
Hi,
On 11/19/2014 07:29 PM, Suriyan Ramasami wrote:
> Hello Przemyslaw,
>
> On Wed, Nov 19, 2014 at 9:39 AM, Przemyslaw Marczak
> <p.marczak@samsung.com> wrote:
>> Hello,
>>
>> On 11/19/2014 05:21 PM, Suriyan Ramasami wrote:
>>>
>>> Add information wrt the USB host side of things for the Odroid-U2/U3 and
>>> the
>>> Odroid-X/X2
>>>
>>> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>>> ---
>>>
>>> Changes in v1:
>>> - Add USB host notes for the Odroid
>>>
>>> doc/README.odroid | 48 ++++++++++++++++++++++++++++++++++++++++++++++++
>>> 1 file changed, 48 insertions(+)
>>>
>>> diff --git a/doc/README.odroid b/doc/README.odroid
>>> index 528bb95..0eaf3ff 100644
>>> --- a/doc/README.odroid
>>> +++ b/doc/README.odroid
>>> @@ -141,3 +141,51 @@ And the boot sequence is:
>>> - boot_fit - if "Image.itb" exists
>>> - boot_zimg - if "zImage" exists
>>> - boot_uimg - if "uImage" exists
>>> +
>>> +11. USB host support
>>> +====================
>>> +The Odroid-X/X2 have the below schematics wrt USB:
>>> +
>>> +Exynos USB_HOST1 -> USB3503 HUB ----> LAN9514 USB HUB -----> LAN9514
>>> Ethernet
>>> + | |
>>> + | +-------Host1---------> USB port
>>> + | |
>>> + | +-------Host2---------> USB port
>>> + | |
>>> + | +-------Host3---------> USB port
>>> + | |
>>> + | +-------Host4---------> USB port
>>> + |
>>> + +-------------------------------------> USB port
>>> + |
>>> + +-------------------------------------> USB port
>>> +
>>> +The Odroid-U2/U3 have the below schematics wrt USB:
>>> +
>>> +Exynos HSIC1 -----------------------------------------------> LAN9514
>>> Ethernet
>>> +
>>> +Exynos HSIC2 -----> USB3503A HUB ---------------Host1---------> USB port
>>> + |
>>> + +-----------------------Host2---------> USB port
>>> + |
>>> + +-----------------------HOst3---------> USB port
>>> (U3)
>>> +
>>> +The HSICs are used in the case of the Odroid-Us and the USB Host in the
>>> SoC
>>> +is used in the case of the Odroid-Xs.
>>> +
>>> +In drivers/usb/host/ehci-exynos.c, function names starting with
>>> exysno4412*
>>> +have been added to initialize the HSICs and the PHYs.
>>> +
>>> +In board/samsung/odroid/odroid.c, function board_usb_init() adds code to
>>> +initialize the USB3503 hub.
>>> +The initializing of the USB3503 hub is as defined in the USB3503A spec
>>> sheet.
>>> +Please refer to Figure 4.1 in the Datasheet.
>>> +a) Set the INT_N (X30) low (Odroid-Us) or high (Odroid-Xs). This is so
>>> that the
>>> +correct REFCLK frequency is selected. 24MHz for Odroid Us and 26MHz for
>>> Odroid
>>> +Xs.
>>> +b) Disconnect the HUB (Set HUB_CONNECT (X34) to 0)
>>> +c) Reset the HUB (Set RESET_N (X35) to 0 and then to 1)
>>> +d) HUB waits for REF_CLK (which we have set appropriately)
>>> +e) Timeout waiting for HUB configuration stage
>>> +f) Connect the HUB (Set HUB_CONNECT (X34) to 1)
>>> +g) Power recycle the LAN9730 which is connected to BUCK8 (Odroid Us)
>>>
>>
>> Suriyan, you quite misunderstand my intention. You added really useful part
>> of code - now user can read/write data to USB mass storage or boot over the
>> Ethernet. Probably you are using this feature. And this is a usage of the
>> USB for the user.
>>
>> For the user - it's not important how it works in the hardware - I would
>> like to get some simple instructions, e.g. How to boot Odroid over the
>> Ethernet, or how to write data to USB stick. I believe that users read this
>> documentation when they starting use of Odroid with the mainline U-Boot, and
>> a description of another boot option is welcome here.
>> It should be "How to start with this board", rather than how to develop USB
>> hub driver on it.
>>
>
> Ah! I see. You are right, I totally misunderstood you. I shall get rid
> of the hardware part of things, and add the sections that you have
> mentioned, viz:
> - How to boot Odroid over Ethernet
> - How to boot Odroid over USB storage etc
Yes, this will be full enough, but I'm not sure if those both cases will
not require additional environment variables, like setting special bootargs?
>
> Thanks
> - Suriyan
>
>> Best regards,
>> --
>> Przemyslaw Marczak
>> Samsung R&D Institute Poland
>> Samsung Electronics
>> p.marczak at samsung.com
>
Thank you,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information
2014-11-19 18:40 ` Przemyslaw Marczak
@ 2014-11-19 18:47 ` Suriyan Ramasami
2014-11-19 19:26 ` Przemyslaw Marczak
0 siblings, 1 reply; 10+ messages in thread
From: Suriyan Ramasami @ 2014-11-19 18:47 UTC (permalink / raw)
To: u-boot
Hello Przemyslaw,
On Wed, Nov 19, 2014 at 10:40 AM, Przemyslaw Marczak
<p.marczak@samsung.com> wrote:
> Hi,
>
>
> On 11/19/2014 07:29 PM, Suriyan Ramasami wrote:
>>
>> Hello Przemyslaw,
>>
>> On Wed, Nov 19, 2014 at 9:39 AM, Przemyslaw Marczak
>> <p.marczak@samsung.com> wrote:
>>>
>>> Hello,
>>>
>>> On 11/19/2014 05:21 PM, Suriyan Ramasami wrote:
>>>>
>>>>
>>>> Add information wrt the USB host side of things for the Odroid-U2/U3 and
>>>> the
>>>> Odroid-X/X2
>>>>
>>>> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>>>> ---
>>>>
>>>> Changes in v1:
>>>> - Add USB host notes for the Odroid
>>>>
>>>> doc/README.odroid | 48
>>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>>> 1 file changed, 48 insertions(+)
>>>>
>>>> diff --git a/doc/README.odroid b/doc/README.odroid
>>>> index 528bb95..0eaf3ff 100644
>>>> --- a/doc/README.odroid
>>>> +++ b/doc/README.odroid
>>>> @@ -141,3 +141,51 @@ And the boot sequence is:
>>>> - boot_fit - if "Image.itb" exists
>>>> - boot_zimg - if "zImage" exists
>>>> - boot_uimg - if "uImage" exists
>>>> +
>>>> +11. USB host support
>>>> +====================
>>>> +The Odroid-X/X2 have the below schematics wrt USB:
>>>> +
>>>> +Exynos USB_HOST1 -> USB3503 HUB ----> LAN9514 USB HUB -----> LAN9514
>>>> Ethernet
>>>> + | |
>>>> + | +-------Host1---------> USB port
>>>> + | |
>>>> + | +-------Host2---------> USB port
>>>> + | |
>>>> + | +-------Host3---------> USB port
>>>> + | |
>>>> + | +-------Host4---------> USB port
>>>> + |
>>>> + +-------------------------------------> USB port
>>>> + |
>>>> + +-------------------------------------> USB port
>>>> +
>>>> +The Odroid-U2/U3 have the below schematics wrt USB:
>>>> +
>>>> +Exynos HSIC1 -----------------------------------------------> LAN9514
>>>> Ethernet
>>>> +
>>>> +Exynos HSIC2 -----> USB3503A HUB ---------------Host1---------> USB
>>>> port
>>>> + |
>>>> + +-----------------------Host2---------> USB port
>>>> + |
>>>> + +-----------------------HOst3---------> USB port
>>>> (U3)
>>>> +
>>>> +The HSICs are used in the case of the Odroid-Us and the USB Host in the
>>>> SoC
>>>> +is used in the case of the Odroid-Xs.
>>>> +
>>>> +In drivers/usb/host/ehci-exynos.c, function names starting with
>>>> exysno4412*
>>>> +have been added to initialize the HSICs and the PHYs.
>>>> +
>>>> +In board/samsung/odroid/odroid.c, function board_usb_init() adds code
>>>> to
>>>> +initialize the USB3503 hub.
>>>> +The initializing of the USB3503 hub is as defined in the USB3503A spec
>>>> sheet.
>>>> +Please refer to Figure 4.1 in the Datasheet.
>>>> +a) Set the INT_N (X30) low (Odroid-Us) or high (Odroid-Xs). This is so
>>>> that the
>>>> +correct REFCLK frequency is selected. 24MHz for Odroid Us and 26MHz for
>>>> Odroid
>>>> +Xs.
>>>> +b) Disconnect the HUB (Set HUB_CONNECT (X34) to 0)
>>>> +c) Reset the HUB (Set RESET_N (X35) to 0 and then to 1)
>>>> +d) HUB waits for REF_CLK (which we have set appropriately)
>>>> +e) Timeout waiting for HUB configuration stage
>>>> +f) Connect the HUB (Set HUB_CONNECT (X34) to 1)
>>>> +g) Power recycle the LAN9730 which is connected to BUCK8 (Odroid Us)
>>>>
>>>
>>> Suriyan, you quite misunderstand my intention. You added really useful
>>> part
>>> of code - now user can read/write data to USB mass storage or boot over
>>> the
>>> Ethernet. Probably you are using this feature. And this is a usage of the
>>> USB for the user.
>>>
>>> For the user - it's not important how it works in the hardware - I would
>>> like to get some simple instructions, e.g. How to boot Odroid over the
>>> Ethernet, or how to write data to USB stick. I believe that users read
>>> this
>>> documentation when they starting use of Odroid with the mainline U-Boot,
>>> and
>>> a description of another boot option is welcome here.
>>> It should be "How to start with this board", rather than how to develop
>>> USB
>>> hub driver on it.
>>>
>>
>> Ah! I see. You are right, I totally misunderstood you. I shall get rid
>> of the hardware part of things, and add the sections that you have
>> mentioned, viz:
>> - How to boot Odroid over Ethernet
>> - How to boot Odroid over USB storage etc
>
>
> Yes, this will be full enough, but I'm not sure if those both cases will not
> require additional environment variables, like setting special bootargs?
>
I shall go through the whole setup including bootarg changes if any to
accomplish the said method of booting.
For example I could walk through an example of just getting ping to work:
Odroid # usb start
(Re)start USB...
USB0: USB EHCI 1.00
scanning bus 0 for devices... 3 USB Device(s) found
scanning usb for storage devices... 0 Storage Device(s) found
scanning usb for ethernet devices... 1 Ethernet Device(s) found
Odroid # setenv autoload no
Odroid # setenv usbethaddr 02:de:ad:be:ef:ff
Odroid # dhcp
Waiting for Ethernet connection... done.
BOOTP broadcast 1
DHCP client bound to address 192.168.1.10 (507 ms)
Odroid # ping 192.168.1.1
Waiting for Ethernet connection... done.
Using sms0 device
host 192.168.1.1 is alive
Odroid #
And go on from there to get tftp loading the linux kernel etc.
Thanks
- Suriyan
>>
>> Thanks
>> - Suriyan
>>
>>> Best regards,
>>> --
>>> Przemyslaw Marczak
>>> Samsung R&D Institute Poland
>>> Samsung Electronics
>>> p.marczak at samsung.com
>>
>>
>
> Thank you,
>
> --
> Przemyslaw Marczak
> Samsung R&D Institute Poland
> Samsung Electronics
> p.marczak at samsung.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information
2014-11-19 18:47 ` Suriyan Ramasami
@ 2014-11-19 19:26 ` Przemyslaw Marczak
0 siblings, 0 replies; 10+ messages in thread
From: Przemyslaw Marczak @ 2014-11-19 19:26 UTC (permalink / raw)
To: u-boot
Hello,
On 11/19/2014 07:47 PM, Suriyan Ramasami wrote:
> Hello Przemyslaw,
>
> On Wed, Nov 19, 2014 at 10:40 AM, Przemyslaw Marczak
> <p.marczak@samsung.com> wrote:
>> Hi,
>>
>>
>> On 11/19/2014 07:29 PM, Suriyan Ramasami wrote:
>>>
>>> Hello Przemyslaw,
>>>
>>> On Wed, Nov 19, 2014 at 9:39 AM, Przemyslaw Marczak
>>> <p.marczak@samsung.com> wrote:
>>>>
>>>> Hello,
>>>>
>>>> On 11/19/2014 05:21 PM, Suriyan Ramasami wrote:
>>>>>
>>>>>
>>>>> Add information wrt the USB host side of things for the Odroid-U2/U3 and
>>>>> the
>>>>> Odroid-X/X2
>>>>>
>>>>> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>>>>> ---
>>>>>
>>>>> Changes in v1:
>>>>> - Add USB host notes for the Odroid
>>>>>
>>>>> doc/README.odroid | 48
>>>>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>>>> 1 file changed, 48 insertions(+)
>>>>>
>>>>> diff --git a/doc/README.odroid b/doc/README.odroid
>>>>> index 528bb95..0eaf3ff 100644
>>>>> --- a/doc/README.odroid
>>>>> +++ b/doc/README.odroid
>>>>> @@ -141,3 +141,51 @@ And the boot sequence is:
>>>>> - boot_fit - if "Image.itb" exists
>>>>> - boot_zimg - if "zImage" exists
>>>>> - boot_uimg - if "uImage" exists
>>>>> +
>>>>> +11. USB host support
>>>>> +====================
>>>>> +The Odroid-X/X2 have the below schematics wrt USB:
>>>>> +
>>>>> +Exynos USB_HOST1 -> USB3503 HUB ----> LAN9514 USB HUB -----> LAN9514
>>>>> Ethernet
>>>>> + | |
>>>>> + | +-------Host1---------> USB port
>>>>> + | |
>>>>> + | +-------Host2---------> USB port
>>>>> + | |
>>>>> + | +-------Host3---------> USB port
>>>>> + | |
>>>>> + | +-------Host4---------> USB port
>>>>> + |
>>>>> + +-------------------------------------> USB port
>>>>> + |
>>>>> + +-------------------------------------> USB port
>>>>> +
>>>>> +The Odroid-U2/U3 have the below schematics wrt USB:
>>>>> +
>>>>> +Exynos HSIC1 -----------------------------------------------> LAN9514
>>>>> Ethernet
>>>>> +
>>>>> +Exynos HSIC2 -----> USB3503A HUB ---------------Host1---------> USB
>>>>> port
>>>>> + |
>>>>> + +-----------------------Host2---------> USB port
>>>>> + |
>>>>> + +-----------------------HOst3---------> USB port
>>>>> (U3)
>>>>> +
>>>>> +The HSICs are used in the case of the Odroid-Us and the USB Host in the
>>>>> SoC
>>>>> +is used in the case of the Odroid-Xs.
>>>>> +
>>>>> +In drivers/usb/host/ehci-exynos.c, function names starting with
>>>>> exysno4412*
>>>>> +have been added to initialize the HSICs and the PHYs.
>>>>> +
>>>>> +In board/samsung/odroid/odroid.c, function board_usb_init() adds code
>>>>> to
>>>>> +initialize the USB3503 hub.
>>>>> +The initializing of the USB3503 hub is as defined in the USB3503A spec
>>>>> sheet.
>>>>> +Please refer to Figure 4.1 in the Datasheet.
>>>>> +a) Set the INT_N (X30) low (Odroid-Us) or high (Odroid-Xs). This is so
>>>>> that the
>>>>> +correct REFCLK frequency is selected. 24MHz for Odroid Us and 26MHz for
>>>>> Odroid
>>>>> +Xs.
>>>>> +b) Disconnect the HUB (Set HUB_CONNECT (X34) to 0)
>>>>> +c) Reset the HUB (Set RESET_N (X35) to 0 and then to 1)
>>>>> +d) HUB waits for REF_CLK (which we have set appropriately)
>>>>> +e) Timeout waiting for HUB configuration stage
>>>>> +f) Connect the HUB (Set HUB_CONNECT (X34) to 1)
>>>>> +g) Power recycle the LAN9730 which is connected to BUCK8 (Odroid Us)
>>>>>
>>>>
>>>> Suriyan, you quite misunderstand my intention. You added really useful
>>>> part
>>>> of code - now user can read/write data to USB mass storage or boot over
>>>> the
>>>> Ethernet. Probably you are using this feature. And this is a usage of the
>>>> USB for the user.
>>>>
>>>> For the user - it's not important how it works in the hardware - I would
>>>> like to get some simple instructions, e.g. How to boot Odroid over the
>>>> Ethernet, or how to write data to USB stick. I believe that users read
>>>> this
>>>> documentation when they starting use of Odroid with the mainline U-Boot,
>>>> and
>>>> a description of another boot option is welcome here.
>>>> It should be "How to start with this board", rather than how to develop
>>>> USB
>>>> hub driver on it.
>>>>
>>>
>>> Ah! I see. You are right, I totally misunderstood you. I shall get rid
>>> of the hardware part of things, and add the sections that you have
>>> mentioned, viz:
>>> - How to boot Odroid over Ethernet
>>> - How to boot Odroid over USB storage etc
>>
>>
>> Yes, this will be full enough, but I'm not sure if those both cases will not
>> require additional environment variables, like setting special bootargs?
>>
> I shall go through the whole setup including bootarg changes if any to
> accomplish the said method of booting.
> For example I could walk through an example of just getting ping to work:
>
> Odroid # usb start
> (Re)start USB...
> USB0: USB EHCI 1.00
> scanning bus 0 for devices... 3 USB Device(s) found
> scanning usb for storage devices... 0 Storage Device(s) found
> scanning usb for ethernet devices... 1 Ethernet Device(s) found
> Odroid # setenv autoload no
> Odroid # setenv usbethaddr 02:de:ad:be:ef:ff
> Odroid # dhcp
> Waiting for Ethernet connection... done.
> BOOTP broadcast 1
> DHCP client bound to address 192.168.1.10 (507 ms)
> Odroid # ping 192.168.1.1
> Waiting for Ethernet connection... done.
> Using sms0 device
> host 192.168.1.1 is alive
> Odroid #
>
> And go on from there to get tftp loading the linux kernel etc.
>
> Thanks
> - Suriyan
>
That's great. And if you have a time for it, then you could add required
changes to CONFIG_EXTRA_ENV_SETTINGS or if no, then the above example of
usage is also helpful.
>>>
>>> Thanks
>>> - Suriyan
>>>
>>>> Best regards,
>>>> --
>>>> Przemyslaw Marczak
>>>> Samsung R&D Institute Poland
>>>> Samsung Electronics
>>>> p.marczak at samsung.com
>>>
>>>
>>
>> Thank you,
>>
>> --
>> Przemyslaw Marczak
>> Samsung R&D Institute Poland
>> Samsung Electronics
>> p.marczak at samsung.com
>
Best regards,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marczak at samsung.com
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call
2014-11-19 16:21 ` [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call Suriyan Ramasami
2014-11-19 17:41 ` Przemyslaw Marczak
@ 2014-11-20 8:41 ` Minkyu Kang
2014-11-20 15:05 ` Suriyan Ramasami
1 sibling, 1 reply; 10+ messages in thread
From: Minkyu Kang @ 2014-11-20 8:41 UTC (permalink / raw)
To: u-boot
Dear Suriyan Ramasami,
On 20/11/14 01:21, Suriyan Ramasami wrote:
> The USB host code was missing gpio_request() calls before using the gpio
> functions, causing errors to be printed out.
>
> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>
> ---
>
> Changes in v1:
> - Added gpio_request() call in board_gpio_init()
>
> board/samsung/odroid/odroid.c | 13 +++++++++++--
> 1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
> index f7396ab..a2c008e 100644
> --- a/board/samsung/odroid/odroid.c
> +++ b/board/samsung/odroid/odroid.c
> @@ -382,6 +382,17 @@ static void board_gpio_init(void)
> gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
> gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
> gpio_direction_input(EXYNOS4X12_GPIO_X31);
> +
> +#ifdef CONFIG_CMD_USB
> + /* USB3503A Reference frequency */
> + gpio_request(EXYNOS4X12_GPIO_X30, "USB3503A RefFreq");
> +
> + /* USB3503A Connect */
> + gpio_request(EXYNOS4X12_GPIO_X34, "USB3503A Connect");
> +
> + /* USB3503A Reset */
> + gpio_request(EXYNOS4X12_GPIO_X35, "USB3503A Reset");
> +#endif
> }
>
> static int pmic_init_max77686(void)
> @@ -489,10 +500,8 @@ int board_usb_init(int index, enum usb_init_type init)
>
> p_pmic = pmic_get("MAX77686_PMIC");
> if (p_pmic && !pmic_probe(p_pmic)) {
> - max77686_set_buck_mode(p_pmic, 8, OPMODE_OFF);
> max77686_set_buck_voltage(p_pmic, 8, 750000);
> max77686_set_buck_voltage(p_pmic, 8, 3300000);
> - max77686_set_buck_mode(p_pmic, 8, OPMODE_ON);
why you remove those two lines?
This patch is for adding gpio_request call, and there's no explain for this change.
Thanks,
Minkyu Kang.
^ permalink raw reply [flat|nested] 10+ messages in thread
* [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call
2014-11-20 8:41 ` Minkyu Kang
@ 2014-11-20 15:05 ` Suriyan Ramasami
0 siblings, 0 replies; 10+ messages in thread
From: Suriyan Ramasami @ 2014-11-20 15:05 UTC (permalink / raw)
To: u-boot
Hello Minkyu Kang,
On Thu, Nov 20, 2014 at 12:41 AM, Minkyu Kang <mk7.kang@samsung.com> wrote:
> Dear Suriyan Ramasami,
>
> On 20/11/14 01:21, Suriyan Ramasami wrote:
>> The USB host code was missing gpio_request() calls before using the gpio
>> functions, causing errors to be printed out.
>>
>> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
>>
>> ---
>>
>> Changes in v1:
>> - Added gpio_request() call in board_gpio_init()
>>
>> board/samsung/odroid/odroid.c | 13 +++++++++++--
>> 1 file changed, 11 insertions(+), 2 deletions(-)
>>
>> diff --git a/board/samsung/odroid/odroid.c b/board/samsung/odroid/odroid.c
>> index f7396ab..a2c008e 100644
>> --- a/board/samsung/odroid/odroid.c
>> +++ b/board/samsung/odroid/odroid.c
>> @@ -382,6 +382,17 @@ static void board_gpio_init(void)
>> gpio_set_pull(EXYNOS4X12_GPIO_X31, S5P_GPIO_PULL_UP);
>> gpio_set_drv(EXYNOS4X12_GPIO_X31, S5P_GPIO_DRV_4X);
>> gpio_direction_input(EXYNOS4X12_GPIO_X31);
>> +
>> +#ifdef CONFIG_CMD_USB
>> + /* USB3503A Reference frequency */
>> + gpio_request(EXYNOS4X12_GPIO_X30, "USB3503A RefFreq");
>> +
>> + /* USB3503A Connect */
>> + gpio_request(EXYNOS4X12_GPIO_X34, "USB3503A Connect");
>> +
>> + /* USB3503A Reset */
>> + gpio_request(EXYNOS4X12_GPIO_X35, "USB3503A Reset");
>> +#endif
>> }
>>
>> static int pmic_init_max77686(void)
>> @@ -489,10 +500,8 @@ int board_usb_init(int index, enum usb_init_type init)
>>
>> p_pmic = pmic_get("MAX77686_PMIC");
>> if (p_pmic && !pmic_probe(p_pmic)) {
>> - max77686_set_buck_mode(p_pmic, 8, OPMODE_OFF);
>> max77686_set_buck_voltage(p_pmic, 8, 750000);
>> max77686_set_buck_voltage(p_pmic, 8, 3300000);
>> - max77686_set_buck_mode(p_pmic, 8, OPMODE_ON);
>
> why you remove those two lines?
> This patch is for adding gpio_request call, and there's no explain for this change.
>
Sorry about the confusion caused. This topic was discussed in another
thread, and I shall add the comments (from Przemyslaw) in the next
version as to why the BUCK OFF and ON does not work as expected on the
Odroid boards.
Regards
- Suriyan
> Thanks,
> Minkyu Kang.
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-11-20 15:05 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-19 16:21 [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information Suriyan Ramasami
2014-11-19 16:21 ` [U-Boot] [PATCH v1 2/2] odroid: usbhost - Add missing gpio_request call Suriyan Ramasami
2014-11-19 17:41 ` Przemyslaw Marczak
2014-11-20 8:41 ` Minkyu Kang
2014-11-20 15:05 ` Suriyan Ramasami
2014-11-19 17:39 ` [U-Boot] [PATCH v1 1/2] odroid: Update README with USB host information Przemyslaw Marczak
2014-11-19 18:29 ` Suriyan Ramasami
2014-11-19 18:40 ` Przemyslaw Marczak
2014-11-19 18:47 ` Suriyan Ramasami
2014-11-19 19:26 ` Przemyslaw Marczak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox