public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds
Date: Thu, 20 Nov 2014 10:21:32 +0100	[thread overview]
Message-ID: <546DB29C.7060500@myspectrum.nl> (raw)
In-Reply-To: <1416406618-16276-1-git-send-email-stefan@agner.ch>

Hello Stefan,

On 19-11-14 15:16, Stefan Agner wrote:
> Resynchronize memcpy/memset with kernel and build them explicitly
> in Thumb2 mode (unified syntax). Those assembler files can be
> built and linked in ARM mode too, however when calling them from
> Thumb2 built code, the stack got corrupted and the copy did not
> succeed (the exact details have not been traced back). Hoever,
> the Linux kernel builds those files in Thumb2 mode. Hence U-Boot
> should build them in Thumb2 mode too when CONFIG_SYS_THUMB_BUILD
> is set.
>
> Also add implicit-it=always to AFLAGS when building for Thumb2.
> Furthermore add no-warn-deprecated option to AFLAGS to rid of
> deprecated unified syntax:


> arch/arm/lib/memcpy.S: Assembler messages:
> arch/arm/lib/memcpy.S:153: Warning: conditional infixes are deprecated in unified syntax
> arch/arm/lib/memcpy.S:154: Warning: conditional infixes are deprecated in unified syntax
> ...

Any particular reason not to fix these warnings instead? It Is
just a matter of making the conditionals suffixes. [I guess
you can even disassemble to file to get the UAL represenation].
Or are there gas version around which actually choke on that?

Regards,
Jeroen

  reply	other threads:[~2014-11-20  9:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-19 14:16 [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds Stefan Agner
2014-11-20  9:21 ` Jeroen Hofstee [this message]
2014-11-20 12:15   ` Stefan Agner
2014-11-20 13:10     ` Jeroen Hofstee
2014-11-20 15:18       ` Bill Pringlemeir
2014-11-20 15:53         ` Jeroen Hofstee
2014-11-20 18:21           ` Bill Pringlemeir
2014-11-20 19:14             ` Jeroen Hofstee
2014-11-21 15:10               ` Stefan Agner
2014-11-21 16:45                 ` Bill Pringlemeir
2014-11-21 15:43               ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=546DB29C.7060500@myspectrum.nl \
    --to=jeroen@myspectrum.nl \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox