From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Thu, 20 Nov 2014 10:21:32 +0100 Subject: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds In-Reply-To: <1416406618-16276-1-git-send-email-stefan@agner.ch> References: <1416406618-16276-1-git-send-email-stefan@agner.ch> Message-ID: <546DB29C.7060500@myspectrum.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Stefan, On 19-11-14 15:16, Stefan Agner wrote: > Resynchronize memcpy/memset with kernel and build them explicitly > in Thumb2 mode (unified syntax). Those assembler files can be > built and linked in ARM mode too, however when calling them from > Thumb2 built code, the stack got corrupted and the copy did not > succeed (the exact details have not been traced back). Hoever, > the Linux kernel builds those files in Thumb2 mode. Hence U-Boot > should build them in Thumb2 mode too when CONFIG_SYS_THUMB_BUILD > is set. > > Also add implicit-it=always to AFLAGS when building for Thumb2. > Furthermore add no-warn-deprecated option to AFLAGS to rid of > deprecated unified syntax: > arch/arm/lib/memcpy.S: Assembler messages: > arch/arm/lib/memcpy.S:153: Warning: conditional infixes are deprecated in unified syntax > arch/arm/lib/memcpy.S:154: Warning: conditional infixes are deprecated in unified syntax > ... Any particular reason not to fix these warnings instead? It Is just a matter of making the conditionals suffixes. [I guess you can even disassemble to file to get the UAL represenation]. Or are there gas version around which actually choke on that? Regards, Jeroen