From: Jeroen Hofstee <jeroen@myspectrum.nl>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds
Date: Thu, 20 Nov 2014 16:53:33 +0100 [thread overview]
Message-ID: <546E0E7D.90203@myspectrum.nl> (raw)
In-Reply-To: <87bno1nbo0.fsf@nbsps.com>
Hi,
On 20-11-14 16:18, Bill Pringlemeir wrote:
>
>> ---
>> arch/arm/lib/memset.S | 40 ++++++++++++++++++++--------------------
>> 1 file changed, 20 insertions(+), 20 deletions(-)
>>
>> diff --git a/arch/arm/lib/memset.S b/arch/arm/lib/memset.S
>> index 0cdf895..4fe38f6 100644
>> --- a/arch/arm/lib/memset.S
>> +++ b/arch/arm/lib/memset.S
>> @@ -18,8 +18,8 @@
>> 1: subs r2, r2, #4 @ 1 do we have enough
>> blt 5f @ 1 bytes to align with?
>> cmp r3, #2 @ 1
>> - strltb r1, [r0], #1 @ 1
>> - strleb r1, [r0], #1 @ 1
>> + strblt r1, [r0], #1 @ 1
>> + strble r1, [r0], #1 @ 1
> To test this, can we just use 'objdump'. The hex codes should be
> identical; there is only one encoding. It should produce the same
> binaries. No need to run test-suites, etc.
>
yes, I should be trivial to test (and find the trivial problem, with
the patch I attached). I am wondering though if all version of
gas accept the suffix notation... any idea?
Regards,
Jeroen
next prev parent reply other threads:[~2014-11-20 15:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-19 14:16 [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds Stefan Agner
2014-11-20 9:21 ` Jeroen Hofstee
2014-11-20 12:15 ` Stefan Agner
2014-11-20 13:10 ` Jeroen Hofstee
2014-11-20 15:18 ` Bill Pringlemeir
2014-11-20 15:53 ` Jeroen Hofstee [this message]
2014-11-20 18:21 ` Bill Pringlemeir
2014-11-20 19:14 ` Jeroen Hofstee
2014-11-21 15:10 ` Stefan Agner
2014-11-21 16:45 ` Bill Pringlemeir
2014-11-21 15:43 ` Albert ARIBAUD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546E0E7D.90203@myspectrum.nl \
--to=jeroen@myspectrum.nl \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox