From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeroen Hofstee Date: Thu, 20 Nov 2014 16:53:33 +0100 Subject: [U-Boot] [PATCH] arm: make arch memset/memcpy to work with Thumb2 builds In-Reply-To: <87bno1nbo0.fsf@nbsps.com> References: <1416406618-16276-1-git-send-email-stefan@agner.ch> <546DB29C.7060500@myspectrum.nl> <546DE833.3090707@myspectrum.nl> <87bno1nbo0.fsf@nbsps.com> Message-ID: <546E0E7D.90203@myspectrum.nl> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi, On 20-11-14 16:18, Bill Pringlemeir wrote: > >> --- >> arch/arm/lib/memset.S | 40 ++++++++++++++++++++-------------------- >> 1 file changed, 20 insertions(+), 20 deletions(-) >> >> diff --git a/arch/arm/lib/memset.S b/arch/arm/lib/memset.S >> index 0cdf895..4fe38f6 100644 >> --- a/arch/arm/lib/memset.S >> +++ b/arch/arm/lib/memset.S >> @@ -18,8 +18,8 @@ >> 1: subs r2, r2, #4 @ 1 do we have enough >> blt 5f @ 1 bytes to align with? >> cmp r3, #2 @ 1 >> - strltb r1, [r0], #1 @ 1 >> - strleb r1, [r0], #1 @ 1 >> + strblt r1, [r0], #1 @ 1 >> + strble r1, [r0], #1 @ 1 > To test this, can we just use 'objdump'. The hex codes should be > identical; there is only one encoding. It should produce the same > binaries. No need to run test-suites, etc. > yes, I should be trivial to test (and find the trivial problem, with the patch I attached). I am wondering though if all version of gas accept the suffix notation... any idea? Regards, Jeroen