public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 0/3] Remove redundant CONFIG_SPL_START_S_PATH
@ 2014-11-21  2:50 Masahiro Yamada
  2014-11-21  2:50 ` [U-Boot] [PATCH 1/3] powerpc: lwmon5: remove redundant CONFIG_SPL_* defines Masahiro Yamada
                   ` (2 more replies)
  0 siblings, 3 replies; 9+ messages in thread
From: Masahiro Yamada @ 2014-11-21  2:50 UTC (permalink / raw)
  To: u-boot


Daniel has posted a nice patch to introduce arch/$ARCH/Makefile.
http://patchwork.ozlabs.org/patch/412497/

Because it is touching CONFIG_SPL_START_S_PATH,
I'd like to remove redundant CONFIG_SPL_START_S_PATH beforehand
in order to help to review Daniel's patch.

It turned out all the CONFIG_SPL_START_S_PATH defines on powerpc
boards are totally bogus.
Now it is very clear why Daniel did not add START_S_PATH handling
in arch/powerpc/Makefile.



Masahiro Yamada (3):
  powerpc: lwmon5: remove redundant CONFIG_SPL_* defines
  powerpc: a3m071: remove redundant CONFIG_SPL_* defines
  imx6: remove redudant CONFIG_SPL_START_S_PATH define

 include/configs/a3m071.h   | 2 --
 include/configs/imx6_spl.h | 1 -
 include/configs/lwmon5.h   | 2 --
 3 files changed, 5 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 1/3] powerpc: lwmon5: remove redundant CONFIG_SPL_* defines
  2014-11-21  2:50 [U-Boot] [PATCH 0/3] Remove redundant CONFIG_SPL_START_S_PATH Masahiro Yamada
@ 2014-11-21  2:50 ` Masahiro Yamada
  2014-11-21  8:23   ` Stefan Roese
  2014-12-08 21:42   ` [U-Boot] [U-Boot, " Tom Rini
  2014-11-21  2:50 ` [U-Boot] [PATCH 2/3] powerpc: a3m071: " Masahiro Yamada
  2014-11-21  2:50 ` [U-Boot] [PATCH 3/3] imx6: remove redudant CONFIG_SPL_START_S_PATH define Masahiro Yamada
  2 siblings, 2 replies; 9+ messages in thread
From: Masahiro Yamada @ 2014-11-21  2:50 UTC (permalink / raw)
  To: u-boot

The CPU directory of this board is arch/powerpc/cpu/ppc4xx.
Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines,
the same start.o and u-boot-spl.lds are selected by default.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Wolfgang Denk <wd@denx.de>
---

 include/configs/lwmon5.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/configs/lwmon5.h b/include/configs/lwmon5.h
index 58e7295..d43db52 100644
--- a/include/configs/lwmon5.h
+++ b/include/configs/lwmon5.h
@@ -671,8 +671,6 @@
 #define CONFIG_SPL_TEXT_BASE		0xffff0000 /* last 64 KiB for SPL */
 #define CONFIG_SYS_SPL_MAX_LEN		(64 << 10)
 #define CONFIG_UBOOT_PAD_TO		458752	/* decimal for 'dd' */
-#define	CONFIG_SPL_START_S_PATH	"arch/powerpc/cpu/ppc4xx"
-#define CONFIG_SPL_LDSCRIPT	"arch/powerpc/cpu/ppc4xx/u-boot-spl.lds"
 #define CONFIG_SPL_LIBCOMMON_SUPPORT	/* image.c */
 #define CONFIG_SPL_LIBGENERIC_SUPPORT	/* string.c */
 #define CONFIG_SPL_SERIAL_SUPPORT
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 2/3] powerpc: a3m071: remove redundant CONFIG_SPL_* defines
  2014-11-21  2:50 [U-Boot] [PATCH 0/3] Remove redundant CONFIG_SPL_START_S_PATH Masahiro Yamada
  2014-11-21  2:50 ` [U-Boot] [PATCH 1/3] powerpc: lwmon5: remove redundant CONFIG_SPL_* defines Masahiro Yamada
@ 2014-11-21  2:50 ` Masahiro Yamada
  2014-11-21  8:23   ` Stefan Roese
  2014-12-08 21:42   ` [U-Boot] [U-Boot, " Tom Rini
  2014-11-21  2:50 ` [U-Boot] [PATCH 3/3] imx6: remove redudant CONFIG_SPL_START_S_PATH define Masahiro Yamada
  2 siblings, 2 replies; 9+ messages in thread
From: Masahiro Yamada @ 2014-11-21  2:50 UTC (permalink / raw)
  To: u-boot

The CPU directory of this board is arch/powerpc/cpu/mpc5xxx.
Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines,
the same start.o and u-boot-spl.lds are selected by default.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Stefan Roese <sr@denx.de>
---

 include/configs/a3m071.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/include/configs/a3m071.h b/include/configs/a3m071.h
index a4050f3..565f258 100644
--- a/include/configs/a3m071.h
+++ b/include/configs/a3m071.h
@@ -416,8 +416,6 @@
 #define CONFIG_SPL_BOARD_INIT
 #define CONFIG_SPL_NOR_SUPPORT
 #define CONFIG_SPL_TEXT_BASE	0xfc000000
-#define	CONFIG_SPL_START_S_PATH	"arch/powerpc/cpu/mpc5xxx"
-#define CONFIG_SPL_LDSCRIPT	"arch/powerpc/cpu/mpc5xxx/u-boot-spl.lds"
 #define CONFIG_SPL_LIBCOMMON_SUPPORT	/* image.c */
 #define CONFIG_SPL_LIBGENERIC_SUPPORT	/* string.c */
 #define CONFIG_SPL_SERIAL_SUPPORT
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 3/3] imx6: remove redudant CONFIG_SPL_START_S_PATH define
  2014-11-21  2:50 [U-Boot] [PATCH 0/3] Remove redundant CONFIG_SPL_START_S_PATH Masahiro Yamada
  2014-11-21  2:50 ` [U-Boot] [PATCH 1/3] powerpc: lwmon5: remove redundant CONFIG_SPL_* defines Masahiro Yamada
  2014-11-21  2:50 ` [U-Boot] [PATCH 2/3] powerpc: a3m071: " Masahiro Yamada
@ 2014-11-21  2:50 ` Masahiro Yamada
  2014-12-08 21:42   ` [U-Boot] [U-Boot, " Tom Rini
  2 siblings, 1 reply; 9+ messages in thread
From: Masahiro Yamada @ 2014-11-21  2:50 UTC (permalink / raw)
  To: u-boot

The CPU directory of IMX6 is arch/arm/cpu/armv7, so setting
CONFIG_SPL_START_S_PATH to arch/arm/cpu/armv7 is totally redundant.

Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: Stefano Babic <sbabic@denx.de>
---

 include/configs/imx6_spl.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h
index 5a5f940..2fb1cc9 100644
--- a/include/configs/imx6_spl.h
+++ b/include/configs/imx6_spl.h
@@ -28,7 +28,6 @@
 #define CONFIG_SPL_LDSCRIPT	"arch/arm/cpu/armv7/omap-common/u-boot-spl.lds"
 #define CONFIG_SPL_TEXT_BASE		0x00908000
 #define CONFIG_SPL_MAX_SIZE		0x10000
-#define CONFIG_SPL_START_S_PATH		"arch/arm/cpu/armv7"
 #define CONFIG_SPL_STACK		0x0091FFB8
 #define CONFIG_SPL_LIBCOMMON_SUPPORT
 #define CONFIG_SPL_LIBGENERIC_SUPPORT
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 1/3] powerpc: lwmon5: remove redundant CONFIG_SPL_* defines
  2014-11-21  2:50 ` [U-Boot] [PATCH 1/3] powerpc: lwmon5: remove redundant CONFIG_SPL_* defines Masahiro Yamada
@ 2014-11-21  8:23   ` Stefan Roese
  2014-12-08 21:42   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 9+ messages in thread
From: Stefan Roese @ 2014-11-21  8:23 UTC (permalink / raw)
  To: u-boot

On 21.11.2014 03:50, Masahiro Yamada wrote:
> The CPU directory of this board is arch/powerpc/cpu/ppc4xx.
> Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines,
> the same start.o and u-boot-spl.lds are selected by default.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Wolfgang Denk <wd@denx.de>

Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [PATCH 2/3] powerpc: a3m071: remove redundant CONFIG_SPL_* defines
  2014-11-21  2:50 ` [U-Boot] [PATCH 2/3] powerpc: a3m071: " Masahiro Yamada
@ 2014-11-21  8:23   ` Stefan Roese
  2014-12-08 21:42   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 9+ messages in thread
From: Stefan Roese @ 2014-11-21  8:23 UTC (permalink / raw)
  To: u-boot

On 21.11.2014 03:50, Masahiro Yamada wrote:
> The CPU directory of this board is arch/powerpc/cpu/mpc5xxx.
> Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines,
> the same start.o and u-boot-spl.lds are selected by default.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Stefan Roese <sr@denx.de>

Acked-by: Stefan Roese <sr@denx.de>

Thanks,
Stefan

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [U-Boot, 1/3] powerpc: lwmon5: remove redundant CONFIG_SPL_* defines
  2014-11-21  2:50 ` [U-Boot] [PATCH 1/3] powerpc: lwmon5: remove redundant CONFIG_SPL_* defines Masahiro Yamada
  2014-11-21  8:23   ` Stefan Roese
@ 2014-12-08 21:42   ` Tom Rini
  1 sibling, 0 replies; 9+ messages in thread
From: Tom Rini @ 2014-12-08 21:42 UTC (permalink / raw)
  To: u-boot

On Fri, Nov 21, 2014 at 11:50:08AM +0900, Masahiro Yamada wrote:

> The CPU directory of this board is arch/powerpc/cpu/ppc4xx.
> Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines,
> the same start.o and u-boot-spl.lds are selected by default.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Wolfgang Denk <wd@denx.de>
> Acked-by: Stefan Roese <sr@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141208/38fd9068/attachment.pgp>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [U-Boot, 2/3] powerpc: a3m071: remove redundant CONFIG_SPL_* defines
  2014-11-21  2:50 ` [U-Boot] [PATCH 2/3] powerpc: a3m071: " Masahiro Yamada
  2014-11-21  8:23   ` Stefan Roese
@ 2014-12-08 21:42   ` Tom Rini
  1 sibling, 0 replies; 9+ messages in thread
From: Tom Rini @ 2014-12-08 21:42 UTC (permalink / raw)
  To: u-boot

On Fri, Nov 21, 2014 at 11:50:09AM +0900, Masahiro Yamada wrote:

> The CPU directory of this board is arch/powerpc/cpu/mpc5xxx.
> Without the CONFIG_SPL_START_S_PATH and CONFIG_SPL_LDSCRIPT defines,
> the same start.o and u-boot-spl.lds are selected by default.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Stefan Roese <sr@denx.de>
> Acked-by: Stefan Roese <sr@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141208/a02c6f21/attachment.pgp>

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [U-Boot] [U-Boot, 3/3] imx6: remove redudant CONFIG_SPL_START_S_PATH define
  2014-11-21  2:50 ` [U-Boot] [PATCH 3/3] imx6: remove redudant CONFIG_SPL_START_S_PATH define Masahiro Yamada
@ 2014-12-08 21:42   ` Tom Rini
  0 siblings, 0 replies; 9+ messages in thread
From: Tom Rini @ 2014-12-08 21:42 UTC (permalink / raw)
  To: u-boot

On Fri, Nov 21, 2014 at 11:50:10AM +0900, Masahiro Yamada wrote:

> The CPU directory of IMX6 is arch/arm/cpu/armv7, so setting
> CONFIG_SPL_START_S_PATH to arch/arm/cpu/armv7 is totally redundant.
> 
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Cc: Stefano Babic <sbabic@denx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141208/c62d7393/attachment.pgp>

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2014-12-08 21:42 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-21  2:50 [U-Boot] [PATCH 0/3] Remove redundant CONFIG_SPL_START_S_PATH Masahiro Yamada
2014-11-21  2:50 ` [U-Boot] [PATCH 1/3] powerpc: lwmon5: remove redundant CONFIG_SPL_* defines Masahiro Yamada
2014-11-21  8:23   ` Stefan Roese
2014-12-08 21:42   ` [U-Boot] [U-Boot, " Tom Rini
2014-11-21  2:50 ` [U-Boot] [PATCH 2/3] powerpc: a3m071: " Masahiro Yamada
2014-11-21  8:23   ` Stefan Roese
2014-12-08 21:42   ` [U-Boot] [U-Boot, " Tom Rini
2014-11-21  2:50 ` [U-Boot] [PATCH 3/3] imx6: remove redudant CONFIG_SPL_START_S_PATH define Masahiro Yamada
2014-12-08 21:42   ` [U-Boot] [U-Boot, " Tom Rini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox