From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Fri, 21 Nov 2014 12:42:47 +0200 Subject: [U-Boot] [PATCH 5/5] lcd: refactor lcd console stuff into its own file In-Reply-To: References: <1416500028-3859-1-git-send-email-nikita@compulab.co.il> <1416500028-3859-6-git-send-email-nikita@compulab.co.il> Message-ID: <546F1727.8070106@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 11/20/2014 08:35 PM, Simon Glass wrote: > Hi Nikita, > > On 20 November 2014 16:13, Nikita Kiryanov wrote: >> common/lcd.c is a mix of code portions that do different but related >> things. To improve modularity, the various code portions should be split >> into their own modules. Separate lcd console code into its own file. >> >> In the process of making this move, some minor changes are introduced: >> CONSOLE_ROWS and CONSOLE_COLS macros are replaced with variables which >> are assigned using a new function lcd_init_console(). >> >> Minor changes were done to facilitate communication between lcd code >> and lcd_console code, specifically in the introduction of lcd_console >> functions set_console_col(), set_console_row(), lcd_get_screen_rows(), >> lcd_get_screen_columns(), and lcd funcitons lcd_getbgcolor(), >> lcd_getfgcolor(). >> >> Signed-off-by: Nikita Kiryanov >> Cc: Anatolij Gustschin >> Cc: Wolfgang Denk >> Cc: Simon Glass > > To my mind this patch should be split - one that changes the code and > another to move part of it into a separate file. Also how about adding > function comments to the header file (lcd_console.h and lcd.h)? Sure, I can do that. I also just noticed that I forgot the license headers in the new files, so V2 coming up. > > Regards, > Simon > -- Regards, Nikita Kiryanov