public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Minkyu Kang <mk7.kang@samsung.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/2] odroid: usbhost - Add missing gpio_request call
Date: Mon, 24 Nov 2014 11:20:10 +0900	[thread overview]
Message-ID: <547295DA.2030102@samsung.com> (raw)
In-Reply-To: <1416533190-10662-2-git-send-email-suriyan.r@gmail.com>

On 21/11/14 10:26, Suriyan Ramasami wrote:
> The USB host code was missing gpio_request() calls before using the gpio
> functions, causing errors to be printed out.
> 
> As a side note calls to max77686_set_buck_mode(OPMODE_OFF/OPMODE_ON) have
> been removed, as they did not have any effect. This is as per Przemyslaw:
> I looked into the documentation and there is a "ENB8" pin in PMIC package.
> This pin allows steering BUCK8 ON/OFF by the vhardware. If ENB8 is set to low
> then you can do on/off. If high, then you cannot change its state by I2C
> write, which seems to be the case with the Odroids.
> 
> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
> Acked-by: Przemyslaw Marczak <p.marczak@samsung.com>
> ---
> 
> Changes in v2:
> - Add comment why max77686_set_buck_mode() has been removed
> Series-changes: 1
> - Added gpio_request() call in board_gpio_init()
> 
>  board/samsung/odroid/odroid.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.

  parent reply	other threads:[~2014-11-24  2:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-21  1:26 [U-Boot] [PATCH v2 1/2] odroid: Update README with USB host usage Suriyan Ramasami
2014-11-21  1:26 ` [U-Boot] [PATCH v2 2/2] odroid: usbhost - Add missing gpio_request call Suriyan Ramasami
2014-11-21 16:05   ` Sjoerd Simons
2014-11-24  2:20   ` Minkyu Kang [this message]
2014-11-21  7:58 ` [U-Boot] [PATCH v2 1/2] odroid: Update README with USB host usage Przemyslaw Marczak
2014-11-24  2:19 ` Minkyu Kang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=547295DA.2030102@samsung.com \
    --to=mk7.kang@samsung.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox