From mboxrd@z Thu Jan 1 00:00:00 1970 From: Minkyu Kang Date: Mon, 24 Nov 2014 11:20:10 +0900 Subject: [U-Boot] [PATCH v2 2/2] odroid: usbhost - Add missing gpio_request call In-Reply-To: <1416533190-10662-2-git-send-email-suriyan.r@gmail.com> References: <1416533190-10662-1-git-send-email-suriyan.r@gmail.com> <1416533190-10662-2-git-send-email-suriyan.r@gmail.com> Message-ID: <547295DA.2030102@samsung.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 21/11/14 10:26, Suriyan Ramasami wrote: > The USB host code was missing gpio_request() calls before using the gpio > functions, causing errors to be printed out. > > As a side note calls to max77686_set_buck_mode(OPMODE_OFF/OPMODE_ON) have > been removed, as they did not have any effect. This is as per Przemyslaw: > I looked into the documentation and there is a "ENB8" pin in PMIC package. > This pin allows steering BUCK8 ON/OFF by the vhardware. If ENB8 is set to low > then you can do on/off. If high, then you cannot change its state by I2C > write, which seems to be the case with the Odroids. > > Signed-off-by: Suriyan Ramasami > Acked-by: Przemyslaw Marczak > --- > > Changes in v2: > - Add comment why max77686_set_buck_mode() has been removed > Series-changes: 1 > - Added gpio_request() call in board_gpio_init() > > board/samsung/odroid/odroid.c | 13 +++++++++++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > applied to u-boot-samsung. Thanks, Minkyu Kang.