From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Schwierzeck Date: Tue, 25 Nov 2014 14:32:40 +0100 Subject: [U-Boot] [PATCH 1/7] common/board_f: add setup of initial stack frame for MIPS In-Reply-To: <20141124222022.GX21184@bill-the-cat> References: <1416091618-18700-1-git-send-email-daniel.schwierzeck@gmail.com> <1416091618-18700-2-git-send-email-daniel.schwierzeck@gmail.com> <546CCC74.4030606@gmail.com> <546E1CCB.7030208@gmail.com> <546FA491.4010801@gmail.com> <20141124222022.GX21184@bill-the-cat> Message-ID: <547484F8.1080502@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 24.11.2014 23:20, Tom Rini wrote: >>>> >>>> ok I'll send an updated patch. >>> >>> Thanks - and as I mentioned it seems wrong to write to a word >>> above the top of the stack. >>> >> >> I discard this patch. The only requirement for the stack pointer >> on MIPS is alignment on a 8 Byte boundary. reserve_stacks already >> aligns it to 16 Byte (gd->start_addr_sp &= ~0xf;). >> >> To make stack walking and backtraces working flawlessy in gdb, I >> found another solution [1]. >> >> [1] http://patchwork.ozlabs.org/patch/413182/ > > And I of course missed this email while sorting out other problems > with stuff I was applying. I'll just back this out and take the > better fix. > hm, the patch landed in v2015.01-rc2. Do you want to create a revert patch or shall I include one in my next pull request? - -- - - Daniel -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJUdITqAAoJEPf1RifdDuszTuIIAJQzh2/EU16Hn+l/JC+TvJ3h 802FJMuKWeZRoF6NPrvZQ8x2SUloc2PfEOyQnMgUtChKOjzuba64Gk08ymzLQQ2Z r7Iv4W3so/9jv41PLeuFpVCAzypRuOi01cXGOxJYLgj1U9QRxAmGXxyIM/v4IFP+ 13ykcJLzxsp4qM12dEyBMQ+8uxysO3yjOwqEdk/q8agqttgnNd1ZjQ1Qzifs9udd ITuxfuii4iwzM+XWg06Q01kC60hEHis4P/HHgHile/Wd0yKrX1rGPYozpvZO+mIr r9w8Bnsdm/wgJOLX604MHMMjy6fkivrI7ZlCishEwMmOpnwElfnVwubjPFRQH0I= =r3h1 -----END PGP SIGNATURE-----