From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [Patch] mmc: fsl_esdhc: fix f_max retrieval during init
Date: Tue, 25 Nov 2014 09:47:42 -0800 [thread overview]
Message-ID: <5474C0BE.5040008@freescale.com> (raw)
In-Reply-To: <544ED31A.8010609@boundarydevices.com>
On 10/27/2014 04:19 PM, Eric Nelson wrote:
> Hi Markus,
>
> On 10/24/2014 02:44 AM, Markus Niebel wrote:
>> From: Markus Niebel <Markus.Niebel@tq-group.com>
>>
>> for multi instance API we use struct fsl_esdhc_cfg to
>> pass the clock rate. Do not set f_max from global data,
>> since this is wrong for multi instance case.
>>
>> Signed-off-by: Markus Niebel <Markus.Niebel@tq-group.com>
>> ---
>> drivers/mmc/fsl_esdhc.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
>> index 2640607..8a1a461 100644
>> --- a/drivers/mmc/fsl_esdhc.c
>> +++ b/drivers/mmc/fsl_esdhc.c
>> @@ -610,7 +610,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct fsl_esdhc_cfg *cfg)
>> #endif
>>
>> cfg->cfg.f_min = 400000;
>> - cfg->cfg.f_max = min(gd->arch.sdhc_clk, 52000000);
>> + cfg->cfg.f_max = min(cfg->sdhc_clk, 52000000);
>>
>> cfg->cfg.b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT;
>>
>
> This seems the right thing to do.
>
> Tested-by: Eric Nelson <eric.nelson@boundarydevices.com>
>
Applied to u-boot-mpc85xx master. Awaiting upstream. Thanks.
York
prev parent reply other threads:[~2014-11-25 17:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 9:44 [U-Boot] [Patch] mmc: fsl_esdhc: fix f_max retrieval during init Markus Niebel
2014-10-24 11:35 ` Stefano Babic
2014-10-27 23:19 ` Eric Nelson
2014-11-25 17:47 ` York Sun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5474C0BE.5040008@freescale.com \
--to=yorksun@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox