From mboxrd@z Thu Jan 1 00:00:00 1970 From: vikasm Date: Tue, 25 Nov 2014 11:33:07 -0800 Subject: [U-Boot] [PATCH 0/5] PL01x: baudrate & line control fixes In-Reply-To: References: <1416269873-16841-1-git-send-email-vikas.manocha@st.com> <546B9707.9020002@st.com> <5473D007.6050809@st.com> Message-ID: <5474D973.3000907@st.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hello Simon, On 11/24/2014 07:51 PM, Simon Glass wrote: > Hi Vikas, > > On 24 November 2014 at 17:40, vikasm wrote: >> Hi Simon, >> >> >> On 11/24/2014 07:51 AM, Simon Glass wrote: >>> Hi Vikas, >>> >>> On 18 November 2014 at 11:59, vikasm wrote: >>>> Thanks Simon, >>>> >>>> >>>> On 11/17/2014 09:30 PM, Simon Glass wrote: >>>>> Hi Vikas, >>>>> >>>>> On 18 November 2014 00:17, Vikas Manocha wrote: >>>>>> This patchset fixes the pl01x driver esp for pl011 baudrate & line >>>>>> control. >>>>>> >>>>>> Vikas Manocha (5): >>>>>> serial: pl01x: pass pl01x_type to set baudrate >>>>>> serial: pl01x: fix pl011 baud rate configuration >>>>>> serial: pl01x: move all line control at same place >>>>>> serial: pl01x: disable as per type of pl01x >>>>>> serial: pl01x: avoid pl01x type check two times >>>>>> >>>>>> drivers/serial/serial_pl01x.c | 46 >>>>>> +++++++++++++++++++++-------------------- >>>>>> 1 file changed, 24 insertions(+), 22 deletions(-) >>>>> Great to see this series. If you have not tested on p1010 I can do >>>>> this in a week or so (am travelling). At least a few of these looks >>>>> like bug fixes to my recent refactor so I could bring them through the >>>>> DM tree if no one else picks them up. >>>> >>>> I was able to test it only for pl011, don't have any board with pl010. >>> Sadly I was wrong, I only have pl011 also. It makes me wonder how it >>> worked so nicely for me without your patches. >> Please find below the possible explanation for all patches: >> >> serial: pl01x: pass pl01x_type to set baudrate >> - This patch only affect if DM is not defined. >> If you are using driver model for pl011, pl011 will work without this patch. >> >> serial: pl01x: fix pl011 baud rate configuration >> - If pl011 is already configured to correct baudrate or LCR register is >> being written later. >> >> serial: pl01x: move all line control at same place >> - this patch does not affect the functionality. >> >> serial: pl01x: disable as per type of pl01x >> - pl011 might work without disabling it properly at start. >> pl010 control register(disable bit) location is reserved in case of pl011. >> >> serial: pl01x: avoid pl01x type check two times >> - does not affect the functionality. > I didn't mean for you to go to that much trouble, but thank you. Not a problem, i was also curious to know it. > > Raspberry Pi is running without driver model (I tested it both ways) > so I guess I'm just lucky (or actually unlucky since I might have > noticed these problems). just guessing... (don't want to bother you....don't reply if is not the case) could it be possible uart is already initialized before u-boot like in xloader if it exists for Raspberry.... > > When Stephen ACKs my Raspberry Pi driver rmodel series then I'll pull > this series in to DM. ok. > > Regards, > Simon Regards, Vikas