[U-Boot] [PATCH] mvebu_mmc: Speed up access time

[U-Boot] [PATCH] mvebu_mmc: Speed up access time

[Mario Schuknecht]

Remove udelay, because card status is polled in a loop.

Signed-off-by: Mario Schuknecht <mario.schuknecht@dresearch-fe.de>
---
 drivers/mmc/mvebu_mmc.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/mmc/mvebu_mmc.c b/drivers/mmc/mvebu_mmc.c
index 9f98c3f..2bf9444 100644
--- a/drivers/mmc/mvebu_mmc.c
+++ b/drivers/mmc/mvebu_mmc.c
@@ -72,8 +72,6 @@ static int mvebu_mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
 	debug("cmdidx [0x%x] resp_type[0x%x] cmdarg[0x%x]\n",
 	      cmd->cmdidx, cmd->resp_type, cmd->cmdarg);
 
-	udelay(10*1000);
-
 	debug("%s: cmd %d (hw state 0x%04x)\n", DRIVER_NAME,
 	      cmd->cmdidx, mvebu_mmc_read(SDIO_HW_STATE));
 
-- 
1.8.4.5

[U-Boot] [PATCH] mvebu_mmc: Speed up access time

[drEagle]

Hi Mario,

I test this patch but it is unsuccessfull with the seevaplug :

After upgrade with U-Boot 2015.01-rc2-dirty (Nov 25 2014 - 08:10:39)                               
Marvell-Sheevaplug                                                              

Marvell>> mmc list                                                              
MVEBU_MMC: 0                                                                    
Marvell>> mmc part                                                              
Marvell>> mmc dev 0 1                                                           
Card did not respond to voltage select!                                         
Marvell>> mmc rescan                                                            
Marvell>> ext2ls mmc 0:1                                                        
** Bad device mmc 0 **                                                          
Marvell>> 

The same master branch (without your patch) work as before...

The udelay removal get the MVEBU_MMC driver bug with sheevaplug.

Regards,
G?rald

Le 03/11/2014 20:36, Mario Schuknecht a ?crit :
> Remove udelay, because card status is polled in a loop.
> 
> Signed-off-by: Mario Schuknecht <mario.schuknecht@dresearch-fe.de>
> ---
>  drivers/mmc/mvebu_mmc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/mmc/mvebu_mmc.c b/drivers/mmc/mvebu_mmc.c
> index 9f98c3f..2bf9444 100644
> --- a/drivers/mmc/mvebu_mmc.c
> +++ b/drivers/mmc/mvebu_mmc.c
> @@ -72,8 +72,6 @@ static int mvebu_mmc_send_cmd(struct mmc *mmc, struct mmc_cmd *cmd,
>  	debug("cmdidx [0x%x] resp_type[0x%x] cmdarg[0x%x]\n",
>  	      cmd->cmdidx, cmd->resp_type, cmd->cmdarg);
>  
> -	udelay(10*1000);
> -
>  	debug("%s: cmd %d (hw state 0x%04x)\n", DRIVER_NAME,
>  	      cmd->cmdidx, mvebu_mmc_read(SDIO_HW_STATE));
>  
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20141126/68353cc3/attachment.pgp>