[U-Boot] mx53loco: compilation broken with 2015.01-rc2

[U-Boot] mx53loco: compilation broken with 2015.01-rc2

[Guillaume Gardet]

Hi,

mx53loco_defconfig is broken in 2015.01-rc2 (was ok with -rc1).

I have the following warning:
drivers/block/dwc_ahsata.c: In function 'reset_sata':
drivers/block/dwc_ahsata.c:611:2: warning: implicit declaration of function 'disable_sata_clock' [-Wimplicit-function-declaration]

And finally this error:
drivers/built-in.o: In function `reset_sata':
/home/abuild/rpmbuild/BUILD/u-boot-2015.01-rc2/drivers/block/dwc_ahsata.c:611: undefined reference to `disable_sata_clock'
ld.bfd: BFD (GNU Binutils; openSUSE 13.2) 2.24.0.20140403-6.1 assertion fail ../../bfd/elf32-arm.c:7696
ld.bfd: error: required section '.rel.plt' not found in the linker script
ld.bfd: final link failed: Invalid operation
Makefile:1066: recipe for target 'u-boot' failed


Commit 10ee8ecafbb4405ac77f6df081325630617aa7cd : "sata: implement reset_sata for dwc_ahsata" is probably the problem.
mx6 is fixed by commit 8d29cef5887887157f54f98493440ce5c824d5cb : "arm: mx6: introduce disable_sata_clock", but nothing for mx5.


Guillaume

[U-Boot] mx53loco: compilation broken with 2015.01-rc2

[Stefano Babic]

Hi Guillaume,

On 26/11/2014 10:50, Guillaume Gardet wrote:
> Hi,
> 
> mx53loco_defconfig is broken in 2015.01-rc2 (was ok with -rc1).
> 
> I have the following warning:
> drivers/block/dwc_ahsata.c: In function 'reset_sata':
> drivers/block/dwc_ahsata.c:611:2: warning: implicit declaration of
> function 'disable_sata_clock' [-Wimplicit-function-declaration]
> 
> And finally this error:
> drivers/built-in.o: In function `reset_sata':
> /home/abuild/rpmbuild/BUILD/u-boot-2015.01-rc2/drivers/block/dwc_ahsata.c:611:
> undefined reference to `disable_sata_clock'
> ld.bfd: BFD (GNU Binutils; openSUSE 13.2) 2.24.0.20140403-6.1 assertion
> fail ../../bfd/elf32-arm.c:7696
> ld.bfd: error: required section '.rel.plt' not found in the linker script
> ld.bfd: final link failed: Invalid operation
> Makefile:1066: recipe for target 'u-boot' failed
> 
> 
> Commit 10ee8ecafbb4405ac77f6df081325630617aa7cd : "sata: implement
> reset_sata for dwc_ahsata" is probably the problem.
> mx6 is fixed by commit 8d29cef5887887157f54f98493440ce5c824d5cb : "arm:
> mx6: introduce disable_sata_clock", but nothing for mx5.

You're right. This is also connected to the thread:

https://www.mail-archive.com/u-boot at lists.denx.de/msg155590.html

As Soeren reports crash if sata_init() is not called, patch fixes an
issue but opens a new one on i.MX6. That means, even with i.MX6 is still
open. Soeren promised to send a patch for i.MX6, and after that we can
decide the best way to take for MX5.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================