public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Make "usb start" only start / scan usb once ?
Date: Wed, 26 Nov 2014 13:44:23 +0100	[thread overview]
Message-ID: <5475CB27.7000704@redhat.com> (raw)

Hi,

Currently we've this magic in include/config_distro_bootcmd.h to avoid
scanning the usb bus multiple times.

And it does not work when also using an usb keyboard because then the
preboot command has already scanned the bus, so we're still scanning it
twice.

While discussing my latest attempt at fixing this:

http://patchwork.ozlabs.org/patch/413394/
http://patchwork.ozlabs.org/patch/413395/

With Ian, Ian said why not simply make "usb start" keep track of if it
already has started things, and then we can remove all the magic for it
from include/config_distro_bootcmd.h and just call it unconditionally.

This would also cause "usb start" and "usb reset" to actually do something
different, where as currently they are 100% the same.

I must say I like this idea, the only downside is, that it could be seen
as a break of the u-boot cmdline API, one could easily argue it is not,
because usb will be started by "usb start" if necessary, and people can
still force a rescan with "usb reset".

So any input on this, specifically would a patch-set to make "usb start"
start usb only once (per boot) be acceptable ?

Regards,

Hans

             reply	other threads:[~2014-11-26 12:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 12:44 Hans de Goede [this message]
2014-12-31 18:05 ` [U-Boot] Make "usb start" only start / scan usb once ? Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5475CB27.7000704@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox