[U-Boot] [PATCH] sunxi: Align PSCI stack calculation to comment

[U-Boot] [PATCH] sunxi: Align PSCI stack calculation to comment

[Jan Kiszka]

0x400 is true 1K.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

Hans, are you collecting sunxi-related patches? This is just a trivial
one, there will be more.

 arch/arm/cpu/armv7/sunxi/psci.S | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/cpu/armv7/sunxi/psci.S b/arch/arm/cpu/armv7/sunxi/psci.S
index b9ea78b..a84807d 100644
--- a/arch/arm/cpu/armv7/sunxi/psci.S
+++ b/arch/arm/cpu/armv7/sunxi/psci.S
@@ -68,7 +68,7 @@ psci_arch_init:
 
 	mrc	p15, 0, r4, c0, c0, 5	@ MPIDR
 	and	r4, r4, #3		@ cpu number in cluster
-	mov	r5, #400		@ 1kB of stack per CPU
+	mov	r5, #0x400		@ 1kB of stack per CPU
 	mul	r4, r4, r5
 
 	adr	r5, text_end		@ end of text
-- 
1.8.4.5

[U-Boot] [PATCH] sunxi: Align PSCI stack calculation to comment

[Marc Zyngier]

On 27/11/14 08:38, Jan Kiszka wrote:
> 0x400 is true 1K.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> Hans, are you collecting sunxi-related patches? This is just a trivial
> one, there will be more.
> 
>  arch/arm/cpu/armv7/sunxi/psci.S | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/cpu/armv7/sunxi/psci.S b/arch/arm/cpu/armv7/sunxi/psci.S
> index b9ea78b..a84807d 100644
> --- a/arch/arm/cpu/armv7/sunxi/psci.S
> +++ b/arch/arm/cpu/armv7/sunxi/psci.S
> @@ -68,7 +68,7 @@ psci_arch_init:
>  
>  	mrc	p15, 0, r4, c0, c0, 5	@ MPIDR
>  	and	r4, r4, #3		@ cpu number in cluster
> -	mov	r5, #400		@ 1kB of stack per CPU
> +	mov	r5, #0x400		@ 1kB of stack per CPU
>  	mul	r4, r4, r5
>  
>  	adr	r5, text_end		@ end of text
> 

(with a brown paper bag on)

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

[U-Boot] [PATCH] sunxi: Align PSCI stack calculation to comment

[Ian Campbell]

On Thu, 2014-11-27 at 09:38 +0100, Jan Kiszka wrote:
> 0x400 is true 1K.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Thanks. Applied to u-boot-sunxi#next. I don't think this is so urgent as
to require a PR for v2015.01 in its own right, but if we do one for
another reason I think we should include this trivial fix. Hans, sound
ok?

> Hans, are you collecting sunxi-related patches? This is just a trivial
> one, there will be more.

Were there any more in the end? If yes then I've not seen them/can't
find them. In general please CC both Hans and myself on sunxi patches.

Thanks,
Ian.

[U-Boot] [PATCH] sunxi: Align PSCI stack calculation to comment

[Hans de Goede]

Hi,

On 13-12-14 18:03, Ian Campbell wrote:
> On Thu, 2014-11-27 at 09:38 +0100, Jan Kiszka wrote:
>> 0x400 is true 1K.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>
> Thanks. Applied to u-boot-sunxi#next. I don't think this is so urgent as
> to require a PR for v2015.01 in its own right, but if we do one for
> another reason I think we should include this trivial fix. Hans, sound
> ok?

Sounds fine to me.

Regards,

Hans

[U-Boot] [PATCH] sunxi: Align PSCI stack calculation to comment

[Jan Kiszka]

On 2014-12-13 18:03, Ian Campbell wrote:
> On Thu, 2014-11-27 at 09:38 +0100, Jan Kiszka wrote:
>> 0x400 is true 1K.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Thanks. Applied to u-boot-sunxi#next. I don't think this is so urgent as
> to require a PR for v2015.01 in its own right, but if we do one for
> another reason I think we should include this trivial fix. Hans, sound
> ok?

This is only a cosmetic fix.

> 
>> Hans, are you collecting sunxi-related patches? This is just a trivial
>> one, there will be more.
> 
> Were there any more in the end? If yes then I've not seen them/can't
> find them. In general please CC both Hans and myself on sunxi patches.

They got delayed. I only now finished full PSCI v0.2 support for the
A20. Will CC you all when sending those out.

Jan

-- 
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux