public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Sanchayan Maity <maitysanchayan@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd/nand/vf610_nfc: Disable subpage writes
Date: Fri, 28 Nov 2014 09:54:23 +0530	[thread overview]
Message-ID: <5477F8F7.4050204@gmail.com> (raw)
In-Reply-To: <497a7815d53afd4a6a3c351e8008a73647d7098e.1416806438.git.maitysanchayan@gmail.com>

On Monday 24 November 2014 11:03 AM, Sanchayan Maity wrote:
> This patch disables subpage writes for vf610_nfc nand
> driver. This is required, as without this fix, writing
> unaligned u-boot images with DFU results in a hang.
> Trying to write unalgined binary images also results
> in a hang, without disabling subpage writes.
> 
> Patch has been tested on a Colibri VF61 module.
> 
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
>  drivers/mtd/nand/vf610_nfc.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
> index 7feb3a7..928d58b 100644
> --- a/drivers/mtd/nand/vf610_nfc.c
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -611,6 +611,9 @@ static int vf610_nfc_nand_init(int devnum, void __iomem *addr)
>  		vf610_nfc_clear(mtd, NFC_FLASH_CONFIG, CONFIG_16BIT);
>  	}
>  
> +	/* Disable subpage writes as we do not provide ecc->hwctl */
> +	chip->options |= NAND_NO_SUBPAGE_WRITE;
> +
>  	chip->dev_ready = vf610_nfc_dev_ready;
>  	chip->cmdfunc = vf610_nfc_command;
>  	chip->read_byte = vf610_nfc_read_byte;
> 

Ping? 

-Regards,
Sanchayan.

      reply	other threads:[~2014-11-28  4:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-24  5:33 [U-Boot] [PATCH] mtd/nand/vf610_nfc: Disable subpage writes Sanchayan Maity
2014-11-28  4:24 ` Sanchayan Maity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5477F8F7.4050204@gmail.com \
    --to=maitysanchayan@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox