* [U-Boot] [PATCH] mtd/nand/vf610_nfc: Disable subpage writes
@ 2014-11-24 5:33 Sanchayan Maity
2014-11-28 4:24 ` Sanchayan Maity
0 siblings, 1 reply; 2+ messages in thread
From: Sanchayan Maity @ 2014-11-24 5:33 UTC (permalink / raw)
To: u-boot
This patch disables subpage writes for vf610_nfc nand
driver. This is required, as without this fix, writing
unaligned u-boot images with DFU results in a hang.
Trying to write unalgined binary images also results
in a hang, without disabling subpage writes.
Patch has been tested on a Colibri VF61 module.
Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
---
drivers/mtd/nand/vf610_nfc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
index 7feb3a7..928d58b 100644
--- a/drivers/mtd/nand/vf610_nfc.c
+++ b/drivers/mtd/nand/vf610_nfc.c
@@ -611,6 +611,9 @@ static int vf610_nfc_nand_init(int devnum, void __iomem *addr)
vf610_nfc_clear(mtd, NFC_FLASH_CONFIG, CONFIG_16BIT);
}
+ /* Disable subpage writes as we do not provide ecc->hwctl */
+ chip->options |= NAND_NO_SUBPAGE_WRITE;
+
chip->dev_ready = vf610_nfc_dev_ready;
chip->cmdfunc = vf610_nfc_command;
chip->read_byte = vf610_nfc_read_byte;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] mtd/nand/vf610_nfc: Disable subpage writes
2014-11-24 5:33 [U-Boot] [PATCH] mtd/nand/vf610_nfc: Disable subpage writes Sanchayan Maity
@ 2014-11-28 4:24 ` Sanchayan Maity
0 siblings, 0 replies; 2+ messages in thread
From: Sanchayan Maity @ 2014-11-28 4:24 UTC (permalink / raw)
To: u-boot
On Monday 24 November 2014 11:03 AM, Sanchayan Maity wrote:
> This patch disables subpage writes for vf610_nfc nand
> driver. This is required, as without this fix, writing
> unaligned u-boot images with DFU results in a hang.
> Trying to write unalgined binary images also results
> in a hang, without disabling subpage writes.
>
> Patch has been tested on a Colibri VF61 module.
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> drivers/mtd/nand/vf610_nfc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/nand/vf610_nfc.c b/drivers/mtd/nand/vf610_nfc.c
> index 7feb3a7..928d58b 100644
> --- a/drivers/mtd/nand/vf610_nfc.c
> +++ b/drivers/mtd/nand/vf610_nfc.c
> @@ -611,6 +611,9 @@ static int vf610_nfc_nand_init(int devnum, void __iomem *addr)
> vf610_nfc_clear(mtd, NFC_FLASH_CONFIG, CONFIG_16BIT);
> }
>
> + /* Disable subpage writes as we do not provide ecc->hwctl */
> + chip->options |= NAND_NO_SUBPAGE_WRITE;
> +
> chip->dev_ready = vf610_nfc_dev_ready;
> chip->cmdfunc = vf610_nfc_command;
> chip->read_byte = vf610_nfc_read_byte;
>
Ping?
-Regards,
Sanchayan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-28 4:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 5:33 [U-Boot] [PATCH] mtd/nand/vf610_nfc: Disable subpage writes Sanchayan Maity
2014-11-28 4:24 ` Sanchayan Maity
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox