From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] mxs_ocotp: check for errors from the OTP controller after writing
Date: Mon, 01 Dec 2014 10:35:43 +0100 [thread overview]
Message-ID: <547C366F.3080509@denx.de> (raw)
In-Reply-To: <1416588884-21701-2-git-send-email-hector.palacios@digi.com>
On 21/11/2014 17:54, Hector Palacios wrote:
> The write operation may fail when trying to write to a locked area. In
> this case the ERROR bit is set in the CTRL register. Check for that
> condition and return an error.
>
> Signed-off-by: Hector Palacios <hector.palacios@digi.com>
> ---
> drivers/misc/mxs_ocotp.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/misc/mxs_ocotp.c b/drivers/misc/mxs_ocotp.c
> index 09002814f2f0..1659ee6a5eec 100644
> --- a/drivers/misc/mxs_ocotp.c
> +++ b/drivers/misc/mxs_ocotp.c
> @@ -221,6 +221,13 @@ static int mxs_ocotp_write_fuse(uint32_t addr, uint32_t mask)
> goto fail;
> }
>
> + /* Check for errors */
> + if (readl(&ocotp_regs->hw_ocotp_ctrl) & OCOTP_CTRL_ERROR) {
> + puts("Failed writing fuses!\n");
> + ret = -EPERM;
> + goto fail;
> + }
> +
> fail:
> mxs_ocotp_scale_vddio(0, &vddio_val);
> if (mxs_ocotp_scale_hclk(0, &hclk_val))
>
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2014-12-01 9:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 16:54 [U-Boot] [PATCH 1/3] mxs_ocotp: prevent error path from returning success Hector Palacios
2014-11-21 16:54 ` [U-Boot] [PATCH 2/3] mxs_ocotp: check for errors from the OTP controller after writing Hector Palacios
2014-11-21 17:10 ` Fabio Estevam
2014-11-21 18:04 ` Hector Palacios
2014-11-22 19:29 ` Fabio Estevam
2014-11-22 19:31 ` Fabio Estevam
2014-11-22 19:31 ` Fabio Estevam
2014-12-01 9:35 ` Stefano Babic [this message]
2014-11-21 16:54 ` [U-Boot] [PATCH 3/3] mxs_ocotp: clear the error flag before initiating write operation Hector Palacios
2014-12-01 9:35 ` Stefano Babic
2014-12-01 9:35 ` [U-Boot] [PATCH 1/3] mxs_ocotp: prevent error path from returning success Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C366F.3080509@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox