[U-Boot] [PATCH 1/2] config_fallbacks: Add a default entry for CONFIG_SYS_PBSIZE

[U-Boot] [PATCH 1/2] config_fallbacks: Add a default entry for CONFIG_SYS_PBSIZE

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into
the console and hitting enter afterwards, causes a hang in the system because
CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'".

Provide a default size for CONFIG_SYS_PBSIZE so that it can store the error 
message and allows the error message to be printed correctly with no hang.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/config_fallbacks.h | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h
index 7d8daa2..508db56 100644
--- a/include/config_fallbacks.h
+++ b/include/config_fallbacks.h
@@ -79,6 +79,10 @@
 #define CONFIG_SYS_PROMPT	"=> "
 #endif
 
+#ifndef CONFIG_SYS_PBSIZE
+#define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + 128)
+#endif
+
 #ifndef CONFIG_FIT_SIGNATURE
 #define CONFIG_IMAGE_FORMAT_LEGACY
 #endif
-- 
1.9.1

[U-Boot] [PATCH 2/2] mx6sabre_common: Use the default CONFIG_SYS_PBSIZE

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@freescale.com>

Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into
the console and hitting enter afterwards, causes a hang in the system because
CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
"Unknown command '' - try 'help'".

Use the default CONFIG_SYS_PBSIZE definition from config_fallbacks.h to solve
this problem.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 include/configs/mx6sabre_common.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
index 9fdd841..f0f721e 100644
--- a/include/configs/mx6sabre_common.h
+++ b/include/configs/mx6sabre_common.h
@@ -220,9 +220,6 @@
 #define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
 #define CONFIG_AUTO_COMPLETE
 #define CONFIG_SYS_CBSIZE              256
-
-/* Print Buffer Size */
-#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
 #define CONFIG_SYS_MAXARGS             16
 #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
 
-- 
1.9.1

[U-Boot] [PATCH 1/2] config_fallbacks: Add a default entry for CONFIG_SYS_PBSIZE

[Stefano Babic]

On 27/11/2014 23:41, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into
> the console and hitting enter afterwards, causes a hang in the system because
> CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
> "Unknown command '' - try 'help'".
> 
> Provide a default size for CONFIG_SYS_PBSIZE so that it can store the error 
> message and allows the error message to be printed correctly with no hang.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/config_fallbacks.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/config_fallbacks.h b/include/config_fallbacks.h
> index 7d8daa2..508db56 100644
> --- a/include/config_fallbacks.h
> +++ b/include/config_fallbacks.h
> @@ -79,6 +79,10 @@
>  #define CONFIG_SYS_PROMPT	"=> "
>  #endif
>  
> +#ifndef CONFIG_SYS_PBSIZE
> +#define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + 128)
> +#endif
> +
>  #ifndef CONFIG_FIT_SIGNATURE
>  #define CONFIG_IMAGE_FORMAT_LEGACY
>  #endif
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

[U-Boot] [PATCH 2/2] mx6sabre_common: Use the default CONFIG_SYS_PBSIZE

[Stefano Babic]

On 27/11/2014 23:41, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Entering the maximum number of characters defined by CONFIG_SYS_CBSIZE into
> the console and hitting enter afterwards, causes a hang in the system because
> CONFIG_SYS_PBSIZE is not capable of storing the characters of the error message:
> "Unknown command '' - try 'help'".
> 
> Use the default CONFIG_SYS_PBSIZE definition from config_fallbacks.h to solve
> this problem.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  include/configs/mx6sabre_common.h | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/include/configs/mx6sabre_common.h b/include/configs/mx6sabre_common.h
> index 9fdd841..f0f721e 100644
> --- a/include/configs/mx6sabre_common.h
> +++ b/include/configs/mx6sabre_common.h
> @@ -220,9 +220,6 @@
>  #define CONFIG_SYS_PROMPT_HUSH_PS2     "> "
>  #define CONFIG_AUTO_COMPLETE
>  #define CONFIG_SYS_CBSIZE              256
> -
> -/* Print Buffer Size */
> -#define CONFIG_SYS_PBSIZE (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16)
>  #define CONFIG_SYS_MAXARGS             16
>  #define CONFIG_SYS_BARGSIZE CONFIG_SYS_CBSIZE
>  
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================