From: Vince Hsu <vinceh@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] fdt: Fix regression in fdt_pack_reg()
Date: Mon, 1 Dec 2014 21:21:22 +0800 [thread overview]
Message-ID: <547C6B52.1090408@nvidia.com> (raw)
In-Reply-To: <1417181031-10004-1-git-send-email-hdegoede@redhat.com>
Hi,
On 11/28/2014 09:23 PM, Hans de Goede wrote:
> After commit 933cdbb479: "fdt: Try to use fdt_address_cells()/fdt_size_cells()"
> I noticed that allwinner boards would no longer boot.
>
> Switching to fdt_address_cells / fdt_size_cells changes the result from
> bytes to 32 bit words, so when we increment pointers into the blob, we must
> do so by 32 bit words now.
>
> This commit makes allwinner boards boot again.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> Changes in v2:
> -Improved patch subject
> -s/_len/_cells/ to indicated that adress_cells and size_cells are in cells now
> ---
I just hit this problem on jetson tk1 and tried the same fix. So
Tested-by: Vince Hsu <vinceh@nvidia.com>
Thanks,
Vince
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
prev parent reply other threads:[~2014-12-01 13:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 13:23 [U-Boot] [PATCH v2] fdt: Fix regression in fdt_pack_reg() Hans de Goede
2014-11-28 16:46 ` Masahiro YAMADA
2014-11-30 3:05 ` Simon Glass
2014-12-01 12:31 ` Stefan Roese
2014-12-01 13:21 ` Vince Hsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C6B52.1090408@nvidia.com \
--to=vinceh@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox