From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Kiryanov Date: Tue, 02 Dec 2014 13:34:03 +0200 Subject: [U-Boot] [PATCH V2 06/12] lcd: replace CONSOLE_(ROWS|COLS) with variables In-Reply-To: References: <1417350585-22669-1-git-send-email-nikita@compulab.co.il> <1417350585-22669-7-git-send-email-nikita@compulab.co.il> Message-ID: <547DA3AB.5020908@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Simon, On 11/30/2014 09:25 PM, Simon Glass wrote: > On 30 November 2014 at 05:29, Nikita Kiryanov wrote: >> Replace CONSOLE_(ROWS|COLS) macros with variables, and assign the >> original macro values. >> >> This is a preparatory step for extracting lcd console code into its own >> file. >> >> Signed-off-by: Nikita Kiryanov >> Cc: Anatolij Gustschin >> Cc: Simon Glass >> --- >> Changes in V2: >> - New patch. > > Are you intended to want to support multiple displays, or just to > change the resolution after start? This did cross my mind as possible future work, but for this patch set the change was driven by the goal of decoupling lcd_console stuff as much as possible from the rest of the code, which meant that I did not want to bring panel_info references into lcd_console.c (there's actually one use of panel_info still remaining in console_scrollup() but I'll get rid of it if/when this series is applied). In the case of console_cols and console_rows, the idea was that the use of panel_info can be avoided if lcd.c would pass the values as parameters to lcd_init_console() (introduced in a later patch), which meant that the macros had to be replaced with variables. > > Acked-by: Simon Glass > > Tested on pit, LCD works fine. > > Tested-by: Simon Glass > This mail did not reach mainline, so I'm Cc-ing the mailing list. I don't know if patchworks will register the Ack and Tested-by though, can you maybe resend them in a separate reply? -- Regards, Nikita Kiryanov