* [U-Boot] [PATCH v1] tools/kwboot: Allow just -t to function
@ 2014-11-25 21:59 Suriyan Ramasami
2014-12-03 18:16 ` Suriyan Ramasami
0 siblings, 1 reply; 3+ messages in thread
From: Suriyan Ramasami @ 2014-11-25 21:59 UTC (permalink / raw)
To: u-boot
When kwboot is invoked with -t <tty> the code implicitly assumes that one
of -b (boot message) or -d (debug message) with an image file is specified.
This is not necessarily true.
This allows kwboot -t <tty> to function.
Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
---
Changes in v1:
- First try
tools/kwboot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/kwboot.c b/tools/kwboot.c
index 1368b4c..449564e 100644
--- a/tools/kwboot.c
+++ b/tools/kwboot.c
@@ -785,7 +785,7 @@ main(int argc, char **argv)
perror("debugmsg");
goto out;
}
- } else {
+ } else if (bootmsg) {
rc = kwboot_bootmsg(tty, bootmsg);
if (rc) {
perror("bootmsg");
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v1] tools/kwboot: Allow just -t to function
2014-11-25 21:59 [U-Boot] [PATCH v1] tools/kwboot: Allow just -t to function Suriyan Ramasami
@ 2014-12-03 18:16 ` Suriyan Ramasami
2014-12-04 10:58 ` Stefan Roese
0 siblings, 1 reply; 3+ messages in thread
From: Suriyan Ramasami @ 2014-12-03 18:16 UTC (permalink / raw)
To: u-boot
Just a gentle ping to see if this can be commented on/Acked/Merged ?
Thanks
- Suiryan
On Tue, Nov 25, 2014 at 1:59 PM, Suriyan Ramasami <suriyan.r@gmail.com> wrote:
> When kwboot is invoked with -t <tty> the code implicitly assumes that one
> of -b (boot message) or -d (debug message) with an image file is specified.
> This is not necessarily true.
>
> This allows kwboot -t <tty> to function.
>
> Signed-off-by: Suriyan Ramasami <suriyan.r@gmail.com>
> ---
>
> Changes in v1:
> - First try
>
> tools/kwboot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/kwboot.c b/tools/kwboot.c
> index 1368b4c..449564e 100644
> --- a/tools/kwboot.c
> +++ b/tools/kwboot.c
> @@ -785,7 +785,7 @@ main(int argc, char **argv)
> perror("debugmsg");
> goto out;
> }
> - } else {
> + } else if (bootmsg) {
> rc = kwboot_bootmsg(tty, bootmsg);
> if (rc) {
> perror("bootmsg");
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH v1] tools/kwboot: Allow just -t to function
2014-12-03 18:16 ` Suriyan Ramasami
@ 2014-12-04 10:58 ` Stefan Roese
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2014-12-04 10:58 UTC (permalink / raw)
To: u-boot
On 03.12.2014 19:16, Suriyan Ramasami wrote:
> Just a gentle ping to see if this can be commented on/Acked/Merged ?
Acked-by: Stefan Roese <sr@denx.de>
Thanks,
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-04 10:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-25 21:59 [U-Boot] [PATCH v1] tools/kwboot: Allow just -t to function Suriyan Ramasami
2014-12-03 18:16 ` Suriyan Ramasami
2014-12-04 10:58 ` Stefan Roese
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox