public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] km/km82xx: remove CONFIG_SYS_RAMBOOT
@ 2014-11-06 13:54 Holger Brunck
  2014-12-05 16:23 ` York Sun
  0 siblings, 1 reply; 2+ messages in thread
From: Holger Brunck @ 2014-11-06 13:54 UTC (permalink / raw)
  To: u-boot

This define is never set in our setup, so we can remove it safely. The
former code causes cppcheck to complain about:
[board/keymile/km82xx/km82xx.c:311]: (error) Uninitialized variable:
psize

Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
cc: Valentin Longchamp <valentin.longchamp@keymile.com>
cc: Wolfgang Denk <wd@denx.de>
---
 board/keymile/km82xx/km82xx.c | 2 --
 include/configs/km82xx.h      | 3 ---
 2 files changed, 5 deletions(-)

diff --git a/board/keymile/km82xx/km82xx.c b/board/keymile/km82xx/km82xx.c
index dfbfab8..cb13a0b 100644
--- a/board/keymile/km82xx/km82xx.c
+++ b/board/keymile/km82xx/km82xx.c
@@ -300,11 +300,9 @@ phys_size_t initdram(int board_type)
 	out_8(&memctl->memc_psrt, CONFIG_SYS_PSRT);
 	out_be16(&memctl->memc_mptpr, CONFIG_SYS_MPTPR);
 
-#ifndef CONFIG_SYS_RAMBOOT
 	/* 60x SDRAM setup:
 	 */
 	psize = probe_sdram(memctl);
-#endif /* CONFIG_SYS_RAMBOOT */
 
 	icache_enable();
 
diff --git a/include/configs/km82xx.h b/include/configs/km82xx.h
index 029c348..220975d 100644
--- a/include/configs/km82xx.h
+++ b/include/configs/km82xx.h
@@ -204,9 +204,6 @@
 	""
 
 #define CONFIG_SYS_MONITOR_BASE	CONFIG_SYS_TEXT_BASE
-#if (CONFIG_SYS_MONITOR_BASE < CONFIG_SYS_FLASH_BASE)
-#define CONFIG_SYS_RAMBOOT
-#endif
 
 #define CONFIG_SYS_MONITOR_LEN		(768 << 10)
 
-- 
2.1.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] km/km82xx: remove CONFIG_SYS_RAMBOOT
  2014-11-06 13:54 [U-Boot] [PATCH] km/km82xx: remove CONFIG_SYS_RAMBOOT Holger Brunck
@ 2014-12-05 16:23 ` York Sun
  0 siblings, 0 replies; 2+ messages in thread
From: York Sun @ 2014-12-05 16:23 UTC (permalink / raw)
  To: u-boot

On 11/06/2014 05:54 AM, Holger Brunck wrote:
> This define is never set in our setup, so we can remove it safely. The
> former code causes cppcheck to complain about:
> [board/keymile/km82xx/km82xx.c:311]: (error) Uninitialized variable:
> psize
> 
> Signed-off-by: Holger Brunck <holger.brunck@keymile.com>
> cc: Valentin Longchamp <valentin.longchamp@keymile.com>
> cc: Wolfgang Denk <wd@denx.de>
> ---

Applied to u-boot-mpc85xx, awaiting upstream.

York

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2014-12-05 16:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-06 13:54 [U-Boot] [PATCH] km/km82xx: remove CONFIG_SYS_RAMBOOT Holger Brunck
2014-12-05 16:23 ` York Sun

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox