From mboxrd@z Thu Jan 1 00:00:00 1970 From: York Sun Date: Fri, 5 Dec 2014 08:49:59 -0800 Subject: [U-Boot] [PATCH v7] net/phy: Add support for CS4315/CS4340 PHY In-Reply-To: References: <1415615549-5952-1-git-send-email-Shengzhou.Liu@freescale.com> <5481DCF1.8040401@freescale.com> Message-ID: <5481E237.5030900@freescale.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 12/05/2014 08:29 AM, Joe Hershberger wrote: > Hi York, > > On Fri, Dec 5, 2014 at 10:27 AM, York Sun > wrote: >> >> On 11/10/2014 02:32 AM, Shengzhou Liu wrote: >> > Add support for Cortina CS4315/CS4340 10G PHY. >> > - This driver loads CS43xx firmware from NOR/NAND/SPI/SD device >> > to initialize Cortina PHY. >> > - Cortina PHY has non-standard offset of PHY ID registers, thus >> > we define own get_phy_id() to override default get_phy_id(). >> > - To define macro CONFIG_PHY_CORTINA will enable this driver. >> > >> > Signed-off-by: Shengzhou Liu > >> > --- >> > v7: reorder it in alphabetical order in Makefile >> > v6: polish it in phy.c and phy.h in alphabetical order >> > v5: fix unclaimed variable in case of nand boot. >> > v4: add support for loading cortina phy ucode from NAND/SPI/SD >> > v3: move devad as '0' in cortina.c instead of in phy.c >> > v2: no change. >> > >> Applied to u-boot-mpc85xx, awaiting upstream. > > Were my concerns from Nov 25 addressed? > No. Somehow I missed your comment. My apology. Shengzhou, please follow up and address the comments. Please send additional patch if needed. York