public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Patrice CHOTARD <patrice.chotard@st.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cmd: pxe: execute the cls command only when supported
Date: Tue, 3 Dec 2019 09:02:29 +0000	[thread overview]
Message-ID: <548341a1-9cea-40d4-a6e2-e84eb56d0366@st.com> (raw)
In-Reply-To: <20191203083835.6898-1-patrick.delaunay@st.com>

Hi Patrick

On 12/3/19 9:38 AM, Patrick Delaunay wrote:
> Execute the command cls (for clear screen), when the "menu background"
> keyword is present in extlinux.conf file, only if the command is supported.
>
> This patch avoid the warning "Unknown command 'cls'"
> with "menu background" in extlinux.conf when CONFIG_CMD_BMP is activated
> and CONFIG_CMD_CLS not activated (default for CONFIG_DM_VIDEO).
>
> Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
> ---
>
>  cmd/pxe.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/cmd/pxe.c b/cmd/pxe.c
> index 2059975446..b62cb79b3a 100644
> --- a/cmd/pxe.c
> +++ b/cmd/pxe.c
> @@ -1592,7 +1592,8 @@ static void handle_pxe_menu(cmd_tbl_t *cmdtp, struct pxe_menu *cfg)
>  	/* display BMP if available */
>  	if (cfg->bmp) {
>  		if (get_relfile(cmdtp, cfg->bmp, load_addr)) {
> -			run_command("cls", 0);
> +			if (CONFIG_IS_ENABLED(CMD_CLS))
> +				run_command("cls", 0);
>  			bmp_display(load_addr,
>  				    BMP_ALIGN_CENTER, BMP_ALIGN_CENTER);
>  		} else {

Reviewed-by: Patrice Chotard <patrice.chotard@st.com>

Thanks

  reply	other threads:[~2019-12-03  9:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03  8:38 [U-Boot] [PATCH] cmd: pxe: execute the cls command only when supported Patrick Delaunay
2019-12-03  9:02 ` Patrice CHOTARD [this message]
2020-01-23 21:57 ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548341a1-9cea-40d4-a6e2-e84eb56d0366@st.com \
    --to=patrice.chotard@st.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox