public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH RFC] arm: mx6: Add CCGR0 configuration to default DCD (spl_sd.cfg)
Date: Mon, 08 Dec 2014 16:42:31 +0100	[thread overview]
Message-ID: <5485C6E7.2060403@denx.de> (raw)
In-Reply-To: <CAOMZO5Am3zXndQ8jwUR=0XDnZtkiGo8_DeRD937UMLU=8v2P+A@mail.gmail.com>

On 08.12.2014 16:36, Fabio Estevam wrote:
>>>> Could you test this on one of your board? If your board also fails to
>>>> boot
>>>> via the "bmode mmc0" command if the CCGR0 register value is missing?
>>>
>>>
>>> I am currently out of the office without access to my mx6 board,
>>
>>
>> I see. Perhaps you could do that once you are back in the office...
>
> Sure, I will test it and will let you know how it goes.

Thanks!

> In the meantime, I am wondering if the change below would allow your
> board to boot:
>
> --- a/arch/arm/cpu/armv7/mx6/soc.c
> +++ b/arch/arm/cpu/armv7/mx6/soc.c
> @@ -105,6 +105,10 @@ void init_aips(void)
>   #ifdef CONFIG_MX6SX
>          struct aipstz_regs *aips3;
>   #endif
> +       struct mxc_ccm_reg *ccm = (struct mxc_ccm_reg *)CCM_BASE_ADDR;
> +
> +       /* Turn on AIPS1 and AIPS2 clocks */
> +       setbits_le32(&ccm->CCGR0, 0xf);
>
>          aips1 = (struct aipstz_regs *)AIPS1_BASE_ADDR;
>          aips2 = (struct aipstz_regs *)AIPS2_BASE_ADDR;

I just tested it. And it doesn't help. I really think this code is not 
reached in this failure case. As the SPL is not loaded completely.

Thanks,
Stefan

  reply	other threads:[~2014-12-08 15:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 13:31 [U-Boot] [PATCH RFC] arm: mx6: Add CCGR0 configuration to default DCD (spl_sd.cfg) Stefan Roese
2014-12-08 14:15 ` Fabio Estevam
2014-12-08 14:32   ` Stefan Roese
2014-12-08 14:51     ` Fabio Estevam
2014-12-08 15:19       ` Stefan Roese
2014-12-08 15:36         ` Fabio Estevam
2014-12-08 15:42           ` Stefan Roese [this message]
2014-12-08 16:13             ` Fabio Estevam
2014-12-08 16:27               ` Stefan Roese
2014-12-18 13:27                 ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5485C6E7.2060403@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox