From: Bo Shen <voice.shen@atmel.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 13/13] ARM: atmel: sama5d4_xplained: enable spl support
Date: Thu, 11 Dec 2014 09:21:22 +0800 [thread overview]
Message-ID: <5488F192.20702@atmel.com> (raw)
In-Reply-To: <CAOCHtYjxQFe9DfH69MU4F1U2BpxgzcmyWNmx554C5wKj3OveGA@mail.gmail.com>
Hi Robert Nelson,
On 12/11/2014 05:35 AM, Robert Nelson wrote:
>> +
>> >+#ifdef CONFIG_SYS_USE_MMC
>> >+#define CONFIG_SPL_LDSCRIPT arch/arm/cpu/at91-common/u-boot-spl.lds
>> >+#define CONFIG_SPL_MMC_SUPPORT
>> >+#define CONFIG_SYS_U_BOOT_MAX_SIZE_SECTORS 0x400
>> >+#define CONFIG_SYS_MMCSD_RAW_MODE_U_BOOT_SECTOR 0x200
>> >+#define CONFIG_SYS_MMC_SD_FS_BOOT_PARTITION 1
> Hi Bo,
>
> You have an extra "_" there: (MMC_SD) -> (MMCSD), it should be:
>
> #define CONFIG_SYS_MMCSD_FS_BOOT_PARTITION 1
>
> build error:
>
> common/spl/spl_mmc.c: In function ?spl_mmc_load_image?:
> common/spl/spl_mmc.c:135:6: error:
> ?CONFIG_SYS_MMCSD_FS_BOOT_PARTITION? undeclared (first use in this
> function)
> CONFIG_SYS_MMCSD_FS_BOOT_PARTITION,
> ^
> common/spl/spl_mmc.c:135:6: note: each undeclared identifier is
> reported only once for each function it appears in
> scripts/Makefile.build:275: recipe for target 'spl/common/spl/spl_mmc.o' failed
> make[2]: *** [spl/common/spl/spl_mmc.o] Error 1
> scripts/Makefile.spl:212: recipe for target 'spl/common/spl' failed
> make[1]: *** [spl/common/spl] Error 2
> make[1]: *** Waiting for unfinished jobs....
Do you test this patch series based on u-boot master branch?
I use "git grep CONFIG_SYS_MMCSD_FS_BOOT_PARTITION", and don't find any
information about it.
Using "git grep CONFIG_SYS_MMC_SD_FS_BOOT_PARTITION" show many files use
it. And the following commit introduced this name:
--->8---
commit 205b4f33cfe58268df7d433f2da515fe660afd9c
Author: Guillaume GARDET <guillaume.gardet@free.fr>
Date: Wed Oct 15 17:53:11 2014 +0200
Rename some defines containing FAT in their name to be filesystem
generic
Rename some defines containing FAT in their name to be filesystem
generic:
MMCSD_MODE_FAT => MMCSD_MODE_FS
CONFIG_SPL_FAT_LOAD_ARGS_NAME => CONFIG_SPL_FS_LOAD_ARGS_NAME
CONFIG_SPL_FAT_LOAD_PAYLOAD_NAME => CONFIG_SPL_FS_LOAD_PAYLOAD_NAME
CONFIG_SYS_MMC_SD_FAT_BOOT_PARTITION =>
CONFIG_SYS_MMC_SD_FS_BOOT_PARTITION
Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
Cc: Tom Rini <trini@ti.com>
---8<---
>
> Regards,
>
> -- Robert Nelson http://www.rcn-ee.com/
Best Regards,
Bo Shen
next prev parent reply other threads:[~2014-12-11 1:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 6:09 [U-Boot] [PATCH 0/13] ARM: atmel: enable spl for sama5d4 related boards Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 01/13] ARM: atmel: clock: make it possible to configure HMX32 Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 02/13] ARM: atmel: sama5: add bus matrix header file Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 03/13] ARM: atmel: sama5: add sfr register " Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 04/13] ARM: atmel: spl: add weak bus matrix init function Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 05/13] ARM: atmel: spl: add saic to aic redirect function Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 06/13] ARM: atmel: spl: can not disable osc for sama5d4 Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 07/13] ARM: atmel: sama5d4: add matrix1 base addr definition Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 08/13] ARM: atmel: sama5d4: add bus matrix init function Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 09/13] ARM: atmel: sama5d4: add interrupt redirec function Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 10/13] ARM: atmel: sama5d4: can access DDR in interleave mode Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 11/13] ARM: atmel: sama5d4: build related file when enable SPL Bo Shen
2014-12-08 6:09 ` [U-Boot] [PATCH 12/13] ARM: atmel: sama5d4ek: enable SPL support Bo Shen
2014-12-10 21:38 ` Robert Nelson
2014-12-08 6:09 ` [U-Boot] [PATCH 13/13] ARM: atmel: sama5d4_xplained: enable spl support Bo Shen
2014-12-10 21:35 ` Robert Nelson
2014-12-11 1:21 ` Bo Shen [this message]
2014-12-11 1:29 ` Bo Shen
2014-12-11 1:56 ` Robert Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5488F192.20702@atmel.com \
--to=voice.shen@atmel.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox