public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mtd: nand: mxs: fix PIO_WORD number
Date: Fri, 12 Dec 2014 09:43:41 +0100	[thread overview]
Message-ID: <548AAABD.9000806@denx.de> (raw)
In-Reply-To: <1418199884-2430-1-git-send-email-luca.ellero@brickedbrain.com>

Hi Luca,

On 10.12.2014 09:24, Luca Ellero wrote:
> There is only one pio_word in this DMA transaction so data field must be 1.
>
> Signed-off-by: Luca Ellero <luca.ellero@brickedbrain.com>
> ---
>   drivers/mtd/nand/mxs_nand.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/mxs_nand.c b/drivers/mtd/nand/mxs_nand.c
> index 7a064ab..616c9ca 100644
> --- a/drivers/mtd/nand/mxs_nand.c
> +++ b/drivers/mtd/nand/mxs_nand.c
> @@ -305,7 +305,7 @@ static void mxs_nand_cmd_ctrl(struct mtd_info *mtd, int data, unsigned int ctrl)
>   	d->cmd.data =
>   		MXS_DMA_DESC_COMMAND_DMA_READ | MXS_DMA_DESC_IRQ |
>   		MXS_DMA_DESC_CHAIN | MXS_DMA_DESC_DEC_SEM |
> -		MXS_DMA_DESC_WAIT4END | (3 << MXS_DMA_DESC_PIO_WORDS_OFFSET) |
> +		MXS_DMA_DESC_WAIT4END | (1 << MXS_DMA_DESC_PIO_WORDS_OFFSET) |
>   		(nand_info->cmd_queue_len << MXS_DMA_DESC_BYTES_OFFSET);

What error or problem does this incorrect setup cause in your case? I'm 
asking since I'm also using this driver in some mx6 system and have not 
seen any issues.

Thanks,
Stefan

  reply	other threads:[~2014-12-12  8:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-10  8:24 [U-Boot] [PATCH] mtd: nand: mxs: fix PIO_WORD number Luca Ellero
2014-12-12  8:43 ` Stefan Roese [this message]
2014-12-12 12:40   ` Luca Ellero
2014-12-12 12:43     ` Stefan Roese
2014-12-12 12:58       ` Marek Vasut
2014-12-12 15:03         ` Luca Ellero
2014-12-13 13:12           ` Marek Vasut
2014-12-15  8:45             ` Luca Ellero
2014-12-15 11:14               ` Marek Vasut
2014-12-16  8:06                 ` Luca Ellero
2014-12-16 11:45                   ` Marek Vasut
2015-02-10 13:14                   ` Stefano Babic
2015-02-10 15:18                     ` Luca Ellero
2015-02-10 15:47                       ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=548AAABD.9000806@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox