public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] arm: mx6: gw_ventana: Change clock init to enable NAND related clocks
@ 2014-12-04 12:04 Stefan Roese
  2014-12-04 12:35 ` Fabio Estevam
  2014-12-19 14:45 ` Stefano Babic
  0 siblings, 2 replies; 3+ messages in thread
From: Stefan Roese @ 2014-12-04 12:04 UTC (permalink / raw)
  To: u-boot

Otherwise NAND booting is likely to fail. Since this disables the NAND related
clocks and SPL can't load the main U-Boot from NAND.

This problem was introduced with this patch:

e25fbe3f (gw_ventana: Move the DCD settings to spl code)

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Tim Harvey <tharvey@gateworks.com>
Cc: Stefano Babic <sbabic@denx.de>
---
 board/gateworks/gw_ventana/gw_ventana_spl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/gateworks/gw_ventana/gw_ventana_spl.c b/board/gateworks/gw_ventana/gw_ventana_spl.c
index d6a5847..9712812 100644
--- a/board/gateworks/gw_ventana/gw_ventana_spl.c
+++ b/board/gateworks/gw_ventana/gw_ventana_spl.c
@@ -401,7 +401,7 @@ static void ccgr_init(void)
 	writel(0x0030FC03, &ccm->CCGR1);
 	writel(0x0FFFC000, &ccm->CCGR2);
 	writel(0x3FF00000, &ccm->CCGR3);
-	writel(0x00FFF300, &ccm->CCGR4);
+	writel(0xFFFFF300, &ccm->CCGR4);	/* enable NAND/GPMI/BCH clks */
 	writel(0x0F0000C3, &ccm->CCGR5);
 	writel(0x000003FF, &ccm->CCGR6);
 }
-- 
2.2.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] arm: mx6: gw_ventana: Change clock init to enable NAND related clocks
  2014-12-04 12:04 [U-Boot] [PATCH] arm: mx6: gw_ventana: Change clock init to enable NAND related clocks Stefan Roese
@ 2014-12-04 12:35 ` Fabio Estevam
  2014-12-19 14:45 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2014-12-04 12:35 UTC (permalink / raw)
  To: u-boot

Hi Stefan,

On Thu, Dec 4, 2014 at 10:04 AM, Stefan Roese <sr@denx.de> wrote:
> Otherwise NAND booting is likely to fail. Since this disables the NAND related
> clocks and SPL can't load the main U-Boot from NAND.
>
> This problem was introduced with this patch:
>
> e25fbe3f (gw_ventana: Move the DCD settings to spl code)
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Stefano Babic <sbabic@denx.de>

Thanks for the fix!

Reviewed-by: Fabio Estevam <fabio.estevam@freescale.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH] arm: mx6: gw_ventana: Change clock init to enable NAND related clocks
  2014-12-04 12:04 [U-Boot] [PATCH] arm: mx6: gw_ventana: Change clock init to enable NAND related clocks Stefan Roese
  2014-12-04 12:35 ` Fabio Estevam
@ 2014-12-19 14:45 ` Stefano Babic
  1 sibling, 0 replies; 3+ messages in thread
From: Stefano Babic @ 2014-12-19 14:45 UTC (permalink / raw)
  To: u-boot

On 04/12/2014 13:04, Stefan Roese wrote:
> Otherwise NAND booting is likely to fail. Since this disables the NAND related
> clocks and SPL can't load the main U-Boot from NAND.
> 
> This problem was introduced with this patch:
> 
> e25fbe3f (gw_ventana: Move the DCD settings to spl code)
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Cc: Stefano Babic <sbabic@denx.de>
> ---

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-12-19 14:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-04 12:04 [U-Boot] [PATCH] arm: mx6: gw_ventana: Change clock init to enable NAND related clocks Stefan Roese
2014-12-04 12:35 ` Fabio Estevam
2014-12-19 14:45 ` Stefano Babic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox