[U-Boot] [PATCH] Exynos: Move down common USB configuration

[U-Boot] [PATCH] Exynos: Move down common USB configuration

[Sjoerd Simons]

USB is a pretty common feature on exynos 5 board, so it seems sensible
to configure it directly from exynos5-common. As a side-effect this
makes USB available from u-boot on exynos 5420 based boards.

While there enable support for common USB ethernet cards to make it more
likely the default config allows booting for network and enable XHCI on
SMDK5420 which has it defined in the dts but not in its config.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 include/configs/arndale.h           |  4 ----
 include/configs/exynos5-common.h    | 10 ++++++++++
 include/configs/exynos5250-common.h |  5 -----
 include/configs/exynos5420-common.h |  2 --
 include/configs/smdk5420.h          |  4 ++++
 5 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/include/configs/arndale.h b/include/configs/arndale.h
index 81e8a7c..6bd27a2 100644
--- a/include/configs/arndale.h
+++ b/include/configs/arndale.h
@@ -24,10 +24,6 @@
 #define CONFIG_USB_EHCI
 #define CONFIG_USB_EHCI_EXYNOS
 
-#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS	3
-#define CONFIG_USB_HOST_ETHER
-#define CONFIG_USB_ETHER_ASIX
-
 /* MMC SPL */
 #define CONFIG_EXYNOS_SPL
 
diff --git a/include/configs/exynos5-common.h b/include/configs/exynos5-common.h
index 8f9b780..ad63f3c 100644
--- a/include/configs/exynos5-common.h
+++ b/include/configs/exynos5-common.h
@@ -174,6 +174,16 @@
 
 #define CONFIG_CMD_GPIO
 
+/* USB */
+#define CONFIG_CMD_USB
+#define CONFIG_USB_STORAGE
+#define CONFIG_SYS_USB_EHCI_MAX_ROOT_PORTS	3
+#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS	2
+
+#define CONFIG_USB_HOST_ETHER
+#define CONFIG_USB_ETHER_ASIX
+#define CONFIG_USB_ETHER_SMSC95XX
+
 /* USB boot mode */
 #define CONFIG_USB_BOOTING
 #define EXYNOS_COPY_USB_FNPTR_ADDR	0x02020070
diff --git a/include/configs/exynos5250-common.h b/include/configs/exynos5250-common.h
index a0107e8..6714313 100644
--- a/include/configs/exynos5250-common.h
+++ b/include/configs/exynos5250-common.h
@@ -22,11 +22,6 @@
 
 #define CONFIG_SPL_MAX_FOOTPRINT	(14 * 1024)
 
-/* USB */
-#define CONFIG_CMD_USB
-#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS	2
-#define CONFIG_USB_STORAGE
-
 #define CONFIG_SPL_TEXT_BASE	0x02023400
 
 #define CONFIG_IRAM_STACK	0x02050000
diff --git a/include/configs/exynos5420-common.h b/include/configs/exynos5420-common.h
index ef6e155..50159d6 100644
--- a/include/configs/exynos5420-common.h
+++ b/include/configs/exynos5420-common.h
@@ -47,8 +47,6 @@
 
 #define CONFIG_BOARD_REV_GPIO_COUNT	2
 
-#define CONFIG_SYS_USB_XHCI_MAX_ROOT_PORTS	2
-
 /*
  * Put the initial stack pointer 1KB below this to allow room for the
  * SPL marker. This value is arbitrary, but gd_t is placed starting here.
diff --git a/include/configs/smdk5420.h b/include/configs/smdk5420.h
index 5c9a3c0..7cd8ace 100644
--- a/include/configs/smdk5420.h
+++ b/include/configs/smdk5420.h
@@ -23,6 +23,10 @@
 #define CONFIG_IDENT_STRING	" for SMDK5420"
 #define CONFIG_DEFAULT_CONSOLE		"console=ttySAC1,115200n8\0"
 
+/* USB */
+#define CONFIG_USB_XHCI
+#define CONFIG_USB_XHCI_EXYNOS
+
 /* DRAM Memory Banks */
 #define CONFIG_NR_DRAM_BANKS	7
 #define SDRAM_BANK_SIZE		(512UL << 20UL)	/* 512 MB */
-- 
2.1.3

[U-Boot] [PATCH] Exynos: Move down common USB configuration

[Simon Glass]

On 5 December 2014 at 13:01, Sjoerd Simons
<sjoerd.simons@collabora.co.uk> wrote:
>
> USB is a pretty common feature on exynos 5 board, so it seems sensible
> to configure it directly from exynos5-common. As a side-effect this
> makes USB available from u-boot on exynos 5420 based boards.
>
> While there enable support for common USB ethernet cards to make it more
> likely the default config allows booting for network and enable XHCI on
> SMDK5420 which has it defined in the dts but not in its config.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>  include/configs/arndale.h           |  4 ----
>  include/configs/exynos5-common.h    | 10 ++++++++++
>  include/configs/exynos5250-common.h |  5 -----
>  include/configs/exynos5420-common.h |  2 --
>  include/configs/smdk5420.h          |  4 ++++
>  5 files changed, 14 insertions(+), 11 deletions(-)
>

I think this is a good idea.

Acked-by: Simon Glass <sjg@chromium.org>

Tested on Pi (exynos5420/5800)
Tested-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH] Exynos: Move down common USB configuration

[Minkyu Kang]

Dear Sjoerd Simons,

On 06/12/14 05:01, Sjoerd Simons wrote:
> USB is a pretty common feature on exynos 5 board, so it seems sensible
> to configure it directly from exynos5-common. As a side-effect this
> makes USB available from u-boot on exynos 5420 based boards.
> 
> While there enable support for common USB ethernet cards to make it more
> likely the default config allows booting for network and enable XHCI on
> SMDK5420 which has it defined in the dts but not in its config.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>  include/configs/arndale.h           |  4 ----
>  include/configs/exynos5-common.h    | 10 ++++++++++
>  include/configs/exynos5250-common.h |  5 -----
>  include/configs/exynos5420-common.h |  2 --
>  include/configs/smdk5420.h          |  4 ++++
>  5 files changed, 14 insertions(+), 11 deletions(-)
> 

Could please rebase this patch?

Thanks,
Minkyu Kang.