[U-Boot] [PATCH] ARM: exynos5420: Leave VBUS GPIO configuration up to common code

[U-Boot] [PATCH] ARM: exynos5420: Leave VBUS GPIO configuration up to common code

[Sjoerd Simons]

Since commit 4a271cb1b4ffdf330 (exynos: usb: Switch USB VBUS GPIOs to be
device tree configured) it's not needed for the board specific files to
turn on the VBUS GPIO by hand as that gets done based on device tree. So
drop the redundant code from the SMDK5420 board file.

Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
 board/samsung/smdk5420/smdk5420.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/board/samsung/smdk5420/smdk5420.c b/board/samsung/smdk5420/smdk5420.c
index a691222..06cba80 100644
--- a/board/samsung/smdk5420/smdk5420.c
+++ b/board/samsung/smdk5420/smdk5420.c
@@ -21,24 +21,8 @@
 
 DECLARE_GLOBAL_DATA_PTR;
 
-#ifdef CONFIG_USB_EHCI_EXYNOS
-static int board_usb_vbus_init(void)
-{
-	/* Enable VBUS power switch */
-	gpio_direction_output(EXYNOS5420_GPIO_X26, 1);
-
-	/* VBUS turn ON time */
-	mdelay(3);
-
-	return 0;
-}
-#endif
-
 int exynos_init(void)
 {
-#ifdef CONFIG_USB_EHCI_EXYNOS
-	board_usb_vbus_init();
-#endif
 	return 0;
 }
 
-- 
2.1.3

[U-Boot] [PATCH] ARM: exynos5420: Leave VBUS GPIO configuration up to common code

[Simon Glass]

On 5 December 2014 at 13:46, Sjoerd Simons
<sjoerd.simons@collabora.co.uk> wrote:
> Since commit 4a271cb1b4ffdf330 (exynos: usb: Switch USB VBUS GPIOs to be
> device tree configured) it's not needed for the board specific files to
> turn on the VBUS GPIO by hand as that gets done based on device tree. So
> drop the redundant code from the SMDK5420 board file.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>  board/samsung/smdk5420/smdk5420.c | 16 ----------------
>  1 file changed, 16 deletions(-)

Acked-by: Simon Glass <sjg@chromium.org>

Tested on Pi (exynos5420/5800)
Tested-by: Simon Glass <sjg@chromium.org>

[U-Boot] [PATCH] ARM: exynos5420: Leave VBUS GPIO configuration up to common code

[Minkyu Kang]

On 06/12/14 05:46, Sjoerd Simons wrote:
> Since commit 4a271cb1b4ffdf330 (exynos: usb: Switch USB VBUS GPIOs to be
> device tree configured) it's not needed for the board specific files to
> turn on the VBUS GPIO by hand as that gets done based on device tree. So
> drop the redundant code from the SMDK5420 board file.
> 
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
> ---
>  board/samsung/smdk5420/smdk5420.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/board/samsung/smdk5420/smdk5420.c b/board/samsung/smdk5420/smdk5420.c
> index a691222..06cba80 100644
> --- a/board/samsung/smdk5420/smdk5420.c
> +++ b/board/samsung/smdk5420/smdk5420.c
> @@ -21,24 +21,8 @@
>  
>  DECLARE_GLOBAL_DATA_PTR;
>  
> -#ifdef CONFIG_USB_EHCI_EXYNOS
> -static int board_usb_vbus_init(void)
> -{
> -	/* Enable VBUS power switch */
> -	gpio_direction_output(EXYNOS5420_GPIO_X26, 1);
> -
> -	/* VBUS turn ON time */
> -	mdelay(3);
> -
> -	return 0;
> -}
> -#endif
> -
>  int exynos_init(void)
>  {
> -#ifdef CONFIG_USB_EHCI_EXYNOS
> -	board_usb_vbus_init();
> -#endif
>  	return 0;
>  }
>  
> 


applied to u-boot-samsung.

Thanks,
Minkyu Kang.